From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.161.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029718; b=KUKv0SzpBQGzEss2o9I2H1nM02knpaYCOsmsrCg2fG1KJFK1ya03xd0h5b4ZB7xQhh++ VlO0eJOOG70b/nZH1YgE+XqC7zPUNIq0yh8h/Y8F90Iky7oxEL8S8Xh8F2N9iDkFyKvfQ VrlyfKkfboQAxsK9fcxEISHyCHJcAe/sPFu8AtdamoCfzk9IcbxnlRbU9RF9PKDfBY5R/ AoVN6Mc5+CWLi2auCOouOc7LQ7QUjIz4ih+v41Tb50UMjNWtjAKi/FUxJuPOuw5Gj+gO0 xiy/KsmS/8Zcq4CLbvXnzjX7avQ4HE8gONWlKafv8k4PpTDyq67dLDUQXiWgnVUV7Ww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029718; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=jgUdZaGhqWrc4BAHJXZyBPZNLZ60f3XoK2Gog1q3Uc8=; b=JVwuLcOCDrpMhTxj4Agop3v6X6wpXSSAlKxEAbczqE6fWAPrpwFZcoJQRZtO7Mdu0NkO Hhx0GTlPg1urIeOJbIFddwfMmleqituoiqQCebY9xoxlKSSlDfwwqVdT6/J8tovsjiwL5 74753BjYIGxSpTz2ozHSkROuxDGbTF71cNWpswTVlgEtPCttPXDtafUeRJzQoWolVSasv BDDOCX/ypwd1TFyfktQh/rG3JlX2NDTNlSH1YPm/SRXOhPoSNqX7wFtlJoYbMQ8I6epwy 83cDq2YFMbhCrNFty7q5l8v4PyD+rRPE40psRVHhGRrAeLrRAMzWbbNagaVbhPAh2/g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yI8HTaaa; arc=none smtp.remote-ip=209.85.161.41 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D14606A32C for ; Wed, 18 Nov 2026 19:21:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 72D14606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=yI8HTaaa Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-71ac9e15640so804575eaf.3 for ; Wed, 18 Nov 2026 11:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795029717; x=1795634517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jgUdZaGhqWrc4BAHJXZyBPZNLZ60f3XoK2Gog1q3Uc8=; b=yI8HTaaazGJaUYg5WhDxOS7Rg8PhG0gAnpdax7E/NX3/QKoTxQ1f1JXiBdlu15HonI Od4XBKu01ksjpvVuSK5CuVuhzVxj3mDdcdu0mucQfJ7rEZb7oSbZhLsJmBP4FjRdXqXn R5Q2Nj+BVrXukRpyECJEO6eTdFowg+Jr/KICVdHNK4GK7+6yvnzRota4Q3DNEaFdScB7 2ADwqejrlfFjjCP6+zV56OME4wnxrEJcfMyBwMTWxwoRvp8SY+nSC9Fn90EhDxFMGdTe 6RuIHpFNBqVUjEHi9rAnSAhOVlvpBcS74RwIHCFoKgSnhXfNKdbsNDsEpzF8p0+HQJVU i3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795029717; x=1795634517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jgUdZaGhqWrc4BAHJXZyBPZNLZ60f3XoK2Gog1q3Uc8=; b=V9AnmPtcH7vz0IA3bZcK4TbuAmTn7HFs66D1lfKIGlPy5E6cBHZC9GQG95wXQ+ZKTo 1m1FEf/L9QS5kiZng6lPNmnQ4P8VVy/sRaUR3kqk/oEsGxEf4itiwNdToy+LfLIMBJ/s pdtLVAA2jvsbW/qpbhcZwBNPWvau4UIQ5RzCejK5ht5GSkV4en6HBRkiuEKOH6DXyvCk U4rkcv71kT0LoDCZriZWXz5wWgwXsez8v3IZpuVjoxJQlD2wEynq3vyEHnLO0gUl53HA xv2Ymz0R+lhTpP84oAx6RAIg1w+RoaZmBqisdcznVcgQlQQs9i4PfRSedu8WWp03fo6z TwfQ== X-Gm-Message-State: APuU4Z/0mimRPWhjicaASyhdpWT9CCYMr4n5GbSXDNzPj9i70NYbibsW updVV7DsJyw5UuO71n/crhe27omiMHQt9sijaFnLFn2EoGR3Y5dT3mE= X-Gm-Gg: AYBFou0JxEegUzDELl/iGfktfsXbx7vryiHFWQxdfsINpWqxZ92SZocOoeUQh8veCKU l6e1MvRwnHavMjI1xXf7XfKF4dNS2kL91BPSBjyCje+7MjLnR4k651uuBXFX1kWqX7gOaZYEfbb /8tzWU9y33TJmLduLblJPbDWAVICU9sAOo8FCUJLjJP2c5g0fmSIgVd7xBLBwgrUUPShNlnCRvW pE+iDSqXD6M/kUSwklfdSlzbdQxDNiQ4Ghp0Ohd3JcOEPHgzu6fZHwXvo9i6ofTucc3Fbb3QxIc /9JwFL/nLgi6uESJ9lqjPAigMYRhK3I6zgBVd/YiM8QXr1BXJoiSdgVahTul2Gn7QiNJgqIkTFV G3hjoJTiSqv1uSfaR0UaApTuilDpyNmyixi7WM4M28Ng/XOppCbUroSYZSeh3M3NqWA5R+9Rkl4 o9TNnEPRvg5a4C7NNH9vrIVdwQchgqM5kFkkd2RN9qLaI32UKHVIUE8n9YDQ86RmW4PzZAtVYle G9YWuTdd22pHRxbfegtb3kMDMe84NI2ueGs3YHLxM1vq9rEWbMQLLXzI5BwUSaoJdWzXq1gIoS0 JmCsT+8oMGfGFKXJQHe0vow6mOpM4k+5ZnJsERhoICGCr6/7S3d0YgxM X-Received: by 2002:a05:6820:7085:20b0:71b:6f9:2171 with SMTP id 006d021491bc7-71b18785a50mr1982499eaf.62.1795029717243; Wed, 18 Nov 2026 11:21:57 -0800 (PST) Received: from miso.lan ([136.62.61.36]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-71b195c0bafsm2376912eaf.14.2026.11.18.11.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 11:21:56 -0800 (PST) From: Matthew Laux To: Mauro Carvalho Chehab , Hans Verkuil , Mehdi Djait Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Matthew Laux , Paul Kocialkowski Subject: [PATCH v5 1/8] media: tw9900: Disable regulator on runtime resume failure Date: Wed, 18 Nov 2026 13:21:17 -0600 Message-ID: <20261118192124.23330-2-matthew.laux@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118192124.23330-1-matthew.laux@gmail.com> References: <20261118192124.23330-1-matthew.laux@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If writing the initialization registers fails, put the chip back in reset and disable the regulator before returning the error. Fixes this warning: WARNING: drivers/regulator/core.c:2657 at regulator_put+0x61/0x70 RIP: 0010:regulator_put+0x61/0x70 Call Trace: release_nodes+0x46/0xd0 devres_release_group+0x11f/0x150 i2c_device_remove+0x41/0xb0 device_release_driver_internal+0x19c/0x200 bus_remove_device+0xca/0x140 device_del+0x160/0x3e0 device_unregister+0x17/0x70 v4l2_device_unregister+0x9c/0xd0 [videodev] usb3hdcap_release+0x26/0x40 [usb3hdcap] v4l2_device_put+0x37/0x60 [videodev] release_card_device+0x51/0x90 [snd] device_release+0x37/0x90 kobject_put+0x8e/0x210 snd_card_file_remove+0x174/0x190 [snd] snd_ctl_release+0x14d/0x160 [snd] __fput+0xe6/0x2a0 __x64_sys_close+0x3d/0x80 do_syscall_64+0x120/0x1610 ? do_syscall_64+0x15e/0x1610 ? irqentry_exit+0x7b/0x590 entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: 918b14a26b12 ("media: i2c: Introduce a driver for the Techwell TW9900 decoder") Cc: Paul Kocialkowski Signed-off-by: Matthew Laux --- drivers/media/i2c/tw9900.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/tw9900.c b/drivers/media/i2c/tw9900.c index 60c102aba750..e07924faa84b 100644 --- a/drivers/media/i2c/tw9900.c +++ b/drivers/media/i2c/tw9900.c @@ -624,13 +624,20 @@ static int tw9900_runtime_resume(struct device *dev) ret = tw9900_write_array(tw9900->client, tw9900_init_regs, ARRAY_SIZE(tw9900_init_regs)); + if (ret) { + if (tw9900->reset_gpio) + gpiod_set_value_cansleep(tw9900->reset_gpio, 1); + regulator_disable(tw9900->regulator); + mutex_unlock(&tw9900->mutex); + return ret; + } mutex_unlock(&tw9900->mutex); /* This sleep is needed for the Horizontal Sync PLL to lock. */ msleep(300); - return ret; + return 0; } static int tw9900_runtime_suspend(struct device *dev) -- 2.47.3