From: Matthew Laux <matthew.laux@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Mehdi Djait <mehdi.djait@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Matthew Laux <matthew.laux@gmail.com>
Subject: [PATCH v5 4/8] media: tw9900: use runtime PM autosuspend and power down on suspend
Date: Wed, 18 Nov 2026 13:21:20 -0600 [thread overview]
Message-ID: <20261118192124.23330-5-matthew.laux@gmail.com> (raw)
In-Reply-To: <20261118192124.23330-1-matthew.laux@gmail.com>
Add support for autosuspend to the tw9900 driver. This is so that initial
bursts of register writes for configuration don't suspend after every
write and cause the init to take a long time.
Signed-off-by: Matthew Laux <matthew.laux@gmail.com>
---
drivers/media/i2c/tw9900.c | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/tw9900.c b/drivers/media/i2c/tw9900.c
index d365432e8f89..4d0d437d02f3 100644
--- a/drivers/media/i2c/tw9900.c
+++ b/drivers/media/i2c/tw9900.c
@@ -34,6 +34,9 @@
#define TW9900_REG_CKHY_HSDLY 0x04
#define TW9900_REG_OUT_CTRL_I 0x05
#define TW9900_REG_ANALOG_CTL 0x06
+#define TW9900_REG_ANALOG_CTL_CLK_PDN BIT(3)
+#define TW9900_REG_ANALOG_CTL_Y_PDN BIT(2)
+#define TW9900_REG_ANALOG_CTL_C_PDN BIT(1)
#define TW9900_REG_CROP_HI 0x07
#define TW9900_REG_VDELAY_LO 0x08
#define TW9900_REG_VACTIVE_LO 0x09
@@ -48,6 +51,7 @@
#define TW9900_REG_HUE 0x15
#define TW9900_REG_VBI_CNTL 0x19
#define TW9900_REG_ANAL_CTL_II 0x1A
+#define TW9900_REG_ANAL_CTL_II_PLL_PDN BIT(6)
#define TW9900_REG_OUT_CTRL_II 0x1B
#define TW9900_REG_STD 0x1C
#define TW9900_REG_STD_AUTO_PROGRESS BIT(7)
@@ -64,6 +68,7 @@
#define TW9900_STD_AUTO 7
#define TW9900_VIDEO_POLL_TRIES 20
+#define TW9900_AUTOSUSPEND_DELAY_MS 1000
struct regval {
u8 addr;
@@ -338,14 +343,14 @@ static int tw9900_s_stream(struct v4l2_subdev *sd, int on)
mutex_unlock(&tw9900->mutex);
- pm_runtime_put(&client->dev);
+ pm_runtime_put_autosuspend(&client->dev);
}
return 0;
err_unlock:
mutex_unlock(&tw9900->mutex);
- pm_runtime_put(&client->dev);
+ pm_runtime_put_autosuspend(&client->dev);
return ret;
}
@@ -522,7 +527,7 @@ static int tw9900_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
out_unlock:
mutex_unlock(&tw9900->mutex);
- pm_runtime_put(&tw9900->client->dev);
+ pm_runtime_put_autosuspend(&tw9900->client->dev);
return ret;
}
@@ -558,7 +563,7 @@ static int tw9900_g_input_status(struct v4l2_subdev *sd, u32 *status)
ret = tw9900_read_reg(tw9900->client, TW9900_REG_CHIP_STATUS);
mutex_unlock(&tw9900->mutex);
- pm_runtime_put(&tw9900->client->dev);
+ pm_runtime_put_autosuspend(&tw9900->client->dev);
if (ret < 0)
return ret;
@@ -613,7 +618,7 @@ static int tw9900_check_id(struct tw9900 *tw9900,
ret = tw9900_read_reg(client, TW9900_REG_CHIP_ID);
mutex_unlock(&tw9900->mutex);
- pm_runtime_put(&tw9900->client->dev);
+ pm_runtime_put_autosuspend(&tw9900->client->dev);
if (ret < 0)
return ret;
@@ -683,6 +688,13 @@ static int tw9900_runtime_suspend(struct device *dev)
mutex_lock(&tw9900->mutex);
+ tw9900_write_reg(tw9900->client, TW9900_REG_ANALOG_CTL,
+ TW9900_REG_ANALOG_CTL_CLK_PDN |
+ TW9900_REG_ANALOG_CTL_Y_PDN |
+ TW9900_REG_ANALOG_CTL_C_PDN);
+ tw9900_write_reg(tw9900->client, TW9900_REG_ANAL_CTL_II,
+ TW9900_REG_ANAL_CTL_II_PLL_PDN);
+
if (tw9900->reset_gpio)
gpiod_set_value_cansleep(tw9900->reset_gpio, 1);
@@ -693,6 +705,15 @@ static int tw9900_runtime_suspend(struct device *dev)
return 0;
}
+static void tw9900_pm_cleanup(struct device *dev)
+{
+ pm_runtime_dont_use_autosuspend(dev);
+ pm_runtime_disable(dev);
+ if (!pm_runtime_status_suspended(dev))
+ tw9900_runtime_suspend(dev);
+ pm_runtime_set_suspended(dev);
+}
+
static int tw9900_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
@@ -757,6 +778,8 @@ static int tw9900_probe(struct i2c_client *client)
goto err_free_handler;
pm_runtime_set_suspended(dev);
+ pm_runtime_set_autosuspend_delay(dev, TW9900_AUTOSUSPEND_DELAY_MS);
+ pm_runtime_use_autosuspend(dev);
pm_runtime_enable(dev);
ret = tw9900_check_id(tw9900, client);
@@ -772,7 +795,7 @@ static int tw9900_probe(struct i2c_client *client)
return 0;
err_disable_pm:
- pm_runtime_disable(dev);
+ tw9900_pm_cleanup(dev);
media_entity_cleanup(&tw9900->subdev.entity);
err_free_handler:
v4l2_ctrl_handler_free(hdl);
@@ -791,7 +814,7 @@ static void tw9900_remove(struct i2c_client *client)
media_entity_cleanup(&sd->entity);
v4l2_ctrl_handler_free(sd->ctrl_handler);
- pm_runtime_disable(&client->dev);
+ tw9900_pm_cleanup(&client->dev);
mutex_destroy(&tw9900->mutex);
}
--
2.47.3
next prev parent reply other threads:[~2026-11-18 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 19:21 [PATCH v5 0/8] Add driver for StarTech USB3HDCAP capture device Matthew Laux
2026-11-18 19:21 ` [PATCH v5 1/8] media: tw9900: Disable regulator on runtime resume failure Matthew Laux
2026-11-18 19:21 ` [PATCH v5 2/8] media: tw9900: accept the TW9910 chip ID Matthew Laux
2026-11-18 19:21 ` [PATCH v5 3/8] media: tw9900: add saturation, hue and sharpness controls Matthew Laux
2026-11-18 19:21 ` Matthew Laux [this message]
2026-11-18 19:21 ` [PATCH v5 5/8] media: tw9900: allow board-specific register tables via platform data Matthew Laux
2026-11-18 19:21 ` [PATCH v5 6/8] media: tw9900: add S-Video input and progressive source detection Matthew Laux
2026-11-18 19:21 ` [PATCH v5 7/8] media: Add subdevice driver for the Mstar MST3367 HDMI receiver Matthew Laux
2026-11-18 19:21 ` [PATCH v5 8/8] media: add driver for StarTech USB3HDCAP Matthew Laux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118192124.23330-5-matthew.laux@gmail.com \
--to=matthew.laux@gmail.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®