From: Gregory Williams <gregory.williams@amd.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Oded Gabbay <ogabbay@kernel.org>,
kishore Manne <nava.kishore.manne@amd.com>,
Izhar Ameer Shaikh <izhar.ameer.shaikh@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jay Buddhabhatti <jay.buddhabhatti@amd.com>,
Ronak Jain <ronak.jain@amd.com>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<dri-devel@lists.freedesktop.org>
Subject: [PATCH 00/15] accel: Add AMD Versal AI Engine driver (with Versal Gen 2 firmware support)
Date: Wed, 18 Nov 2026 15:31:56 -0800 [thread overview]
Message-ID: <20261118233211.4121361-1-gregory.williams@amd.com> (raw)
This series adds a driver for the AMD AI Engine (AIE) found on Versal
devices, together with the firmware changes the driver depends on. AI Engine
is a tile array based accelerator used for applications such as beamforming and
machine learning inference. Tiles are organised in columns, and groups of
columns form partitions that an application requests, initialises and releases.
Several registers in the AI Engine array (column and shim resets, memory
zeroisation, tile clock gating, NoC and interrupt routing) are privileged
and can only be written by the trusted firmware. The driver therefore
packs operations into a DMA buffer and hands it to the platform firmware,
which executes them in order.
Firmware patches included
-------------------------
Patches 1-10 are not part of the AI Engine driver itself, but the driver
cannot work without them, so they are included here to keep the series
self-contained and reviewable in one place:
- 1-5: zynqmp firmware driver refactoring and a va_start()/va_end()
fix (patch 2 carries Fixes: tags), preparing for the extended
SMCCC call format.
- 6-7: Versal Gen 2 compatible string and firmware support, where all
EEMI APIs use the extended SMCCC payload.
- 8-9: Versal Gen 2 clock binding and clk driver match entry.
- 10: firmware IOCTL support for the Versal Gen 2 AIE run time
operations, used by the driver.
I am happy to split out or reorder the firmware and clock patches if the
maintainers prefer to take them through their own trees, and would
appreciate guidance on how the series should be merged.
AI Engine driver
----------------
- 11: devicetree binding for the AI Engine.
- 12: driver core: device probe, partition request and release.
- 13: pm ops: building and sending firmware operation packets.
- 14: enabling and disabling tile clocks.
- 15: partition initialize and teardown (reset operations).
Previous submission
-------------------
This driver was posted for review a little over a year ago:
https://lore.kernel.org/dri-devel/20250702155630.1737227-1-gregory.williams@amd.com/
Since then the scope of what is proposed for upstream has changed, this series
is considerably different from that posting, in particular targeting only Versal
Gen 2 support. All comments received on the earlier posting have been addressed
or in this version.
Abhyuday Godhasara (1):
drivers: firmware: xilinx: Add IOCTL support for the AIE run time
operations
Gregory Williams (5):
dt-bindings: soc: xilinx: Add Versal AI Engine DT binding
accel/amd-ai-engine: Add AMD AI Engine device driver
accel/amd-ai-engine: Add pm ops for firmware calls
accel/amd-ai-engine: Add support to enable/disable tile clocks
accel/amd-ai-engine: Add reset operations
Naman Trivedi (1):
dt-bindings: clock: versal: add Versal Gen 2 compatible string
Senthil Nathan Thangaraj (8):
firmware: xilinx: Separate TF-A checking
firmware: xilinx: Call va_start after pm feature check
firmware: xilinx: Add comments about number of arguments
firmware: xilinx: Use match data for ZynqMP/Versal
firmware: xilinx: Rename zynqmp_pm_invoke_fw_fn()
dt-bindings: firmware: xilinx: Add Versal Gen 2 compatible string
firmware: xilinx: Add support for Versal Gen 2
clk: zynqmp: Add Versal Gen 2 compatible string
.../bindings/clock/xlnx,versal-clk.yaml | 5 +-
.../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 3 +
.../bindings/soc/xilinx/xlnx,ai-engine.yaml | 61 +++
MAINTAINERS | 9 +
drivers/accel/Kconfig | 1 +
drivers/accel/Makefile | 3 +-
drivers/accel/amd-ai-engine/Kconfig | 15 +
drivers/accel/amd-ai-engine/Makefile | 14 +
.../accel/amd-ai-engine/ai-engine-aiemlv2.c | 441 ++++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-clock.c | 154 ++++++
drivers/accel/amd-ai-engine/ai-engine-dev.c | 255 ++++++++++
.../accel/amd-ai-engine/ai-engine-internal.h | 377 ++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-part.c | 140 ++++++
drivers/accel/amd-ai-engine/ai-engine-pm.c | 472 ++++++++++++++++++
drivers/accel/amd-ai-engine/ai-engine-res.c | 184 +++++++
drivers/accel/amd-ai-engine/ai-engine-reset.c | 69 +++
drivers/clk/zynqmp/clkc.c | 1 +
drivers/firmware/xilinx/zynqmp.c | 340 +++++++++++--
include/linux/amd-ai-engine.h | 115 +++++
include/linux/firmware/xlnx-zynqmp.h | 65 ++-
20 files changed, 2679 insertions(+), 45 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml
create mode 100644 drivers/accel/amd-ai-engine/Kconfig
create mode 100644 drivers/accel/amd-ai-engine/Makefile
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-aiemlv2.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-clock.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-dev.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-internal.h
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-part.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-pm.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-res.c
create mode 100644 drivers/accel/amd-ai-engine/ai-engine-reset.c
create mode 100644 include/linux/amd-ai-engine.h
--
2.34.1
next reply other threads:[~2026-11-18 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:31 Gregory Williams [this message]
2026-11-18 23:31 ` [PATCH 01/15] firmware: xilinx: Separate TF-A checking Gregory Williams
2026-11-18 23:31 ` [PATCH 02/15] firmware: xilinx: Call va_start after pm feature check Gregory Williams
2026-11-18 23:31 ` [PATCH 03/15] firmware: xilinx: Add comments about number of arguments Gregory Williams
2026-11-18 23:32 ` [PATCH 04/15] firmware: xilinx: Use match data for ZynqMP/Versal Gregory Williams
2026-11-18 23:32 ` [PATCH 05/15] firmware: xilinx: Rename zynqmp_pm_invoke_fw_fn() Gregory Williams
2026-11-18 23:32 ` [PATCH 06/15] dt-bindings: firmware: xilinx: Add Versal Gen 2 compatible string Gregory Williams
2026-11-18 23:32 ` [PATCH 07/15] firmware: xilinx: Add support for Versal Gen 2 Gregory Williams
2026-11-18 23:32 ` [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string Gregory Williams
2026-11-18 23:32 ` [PATCH 09/15] clk: zynqmp: Add " Gregory Williams
2026-11-18 23:32 ` [PATCH 10/15] drivers: firmware: xilinx: Add IOCTL support for the AIE run time operations Gregory Williams
2026-11-18 23:32 ` [PATCH 11/15] dt-bindings: soc: xilinx: Add Versal AI Engine DT binding Gregory Williams
2026-11-18 23:32 ` [PATCH 12/15] accel/amd-ai-engine: Add AMD AI Engine device driver Gregory Williams
2026-11-18 23:32 ` [PATCH 13/15] accel/amd-ai-engine: Add pm ops for firmware calls Gregory Williams
2026-11-18 23:32 ` [PATCH 14/15] accel/amd-ai-engine: Add support to enable/disable tile clocks Gregory Williams
2026-11-18 23:32 ` [PATCH 15/15] accel/amd-ai-engine: Add reset operations Gregory Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118233211.4121361-1-gregory.williams@amd.com \
--to=gregory.williams@amd.com \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=izhar.ameer.shaikh@amd.com \
--cc=jay.buddhabhatti@amd.com \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nava.kishore.manne@amd.com \
--cc=ogabbay@kernel.org \
--cc=robh@kernel.org \
--cc=ronak.jain@amd.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®