From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: rva333@protonmail.com, "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: light: stk33xx: add power supply support
Date: Thu, 19 Nov 2026 16:37:28 +0000 [thread overview]
Message-ID: <20261119-giblet-epilogue-45f554c009ce@spud> (raw)
In-Reply-To: <20261119032903.4a0d3bf6@jic23-hlaptop>
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
On Thu, Nov 19, 2026 at 03:29:03AM +0000, Jonathan Cameron wrote:
> On Wed, 18 Nov 2026 18:12:30 +0000
> Conor Dooley <conor@kernel.org> wrote:
>
> > On Tue, Nov 17, 2026 at 08:08:35PM +0200, Roman Vivchar via B4 Relay wrote:
> > > From: Roman Vivchar <rva333@protonmail.com>
> > >
> > > On some boards, the chip shares a power rail with other components. If
> > > that rail is turned off, the chip can't function.
> >
> > With these issues in mind, probably it should be made required, even
> > though new required properties are an ABI break.
>
> I raised the same on v1. Seems it is used by various boards
> in tree where we don't know which supply it is. So whilst nice
> to fix we might just be creating some painful build warnings.
Yeah I don't really want to cause more warnings, but if it is actually
the source of issues, warning may get them resolved.
Up to Roman really I guess.
> Can go ahead and 'guess' I suppose or put a fixed supply on it
> in the upstream dts.
>
> Jonathan
>
> >
> > >
> > > Add vdd-supply property to document the chip power supply.
> > >
> > > Signed-off-by: Roman Vivchar <rva333@protonmail.com>
> > > ---
> > > Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > index f655a570aac7..114cf87eb54d 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> > > @@ -37,6 +37,8 @@ properties:
> > >
> > > proximity-near-level: true
> > >
> > > + vdd-supply: true
> > > +
> > > required:
> > > - compatible
> > > - reg
> > >
> > > --
> > > 2.56.1
> > >
> > >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-19 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:08 [PATCH v2 0/4] iio: light: stk3310: stk3337 support + vdd supply Roman Vivchar via B4 Relay
2026-11-17 18:08 ` [PATCH v2 1/4] dt-bindings: iio: light: stk33xx: add power supply support Roman Vivchar via B4 Relay
2026-11-18 18:12 ` Conor Dooley
2026-11-19 3:29 ` Jonathan Cameron
2026-11-19 16:37 ` Conor Dooley [this message]
2026-11-19 17:20 ` Roman Vivchar
2026-11-19 17:44 ` Conor Dooley
2026-11-17 18:08 ` [PATCH v2 2/4] dt-bindings: iio: light: stk33xx: add stk3337 Roman Vivchar via B4 Relay
2026-11-18 18:11 ` Conor Dooley
2026-11-17 18:08 ` [PATCH v2 3/4] iio: light: stk3310: add vdd regulator support Roman Vivchar via B4 Relay
2026-11-18 10:01 ` Joshua Crofts
2026-11-19 3:32 ` Jonathan Cameron
2026-11-19 16:33 ` Roman Vivchar
2026-11-17 18:08 ` [PATCH v2 4/4] iio: light: stk3310: add stk3337 support Roman Vivchar via B4 Relay
2026-11-18 10:03 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119-giblet-epilogue-45f554c009ce@spud \
--to=conor@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®