mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Hefei <3066883572@qq.com>
Cc: dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: backlight: add VIEWE I2C backlight binding
Date: Thu, 19 Nov 2026 17:51:07 +0000	[thread overview]
Message-ID: <20261119-gravity-unlighted-54fc29aa3dd8@spud> (raw)
In-Reply-To: <tencent_093E92ACAABFAB09F39EC07F4350A5C7BD09@qq.com>

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Thu, Nov 19, 2026 at 10:48:05AM +0800, Hefei wrote:
> Add the binding for the VIEWE panel backlight MCU on I2C.
> 
> Signed-off-by: Hefei <3066883572@qq.com>
> ---
>  .../leds/backlight/viewe,i2c-backlight.yaml   | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/viewe,i2c-backlight.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/viewe,i2c-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/viewe,i2c-backlight.yaml
> new file mode 100644
> index 0000000..ab60c2c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/viewe,i2c-backlight.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/viewe,i2c-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIEWE I2C panel backlight
> +
> +maintainers:
> +  - Hefei <3066883572@qq.com>
> +
> +description: |
> +  Simple I2C backlight used on VIEWE DSI modules. Default protocol is device
> +  address 0x45, register 0x86, brightness 0..255.
> +
> +allOf:
> +  - $ref: common.yaml#
> +
> +properties:
> +  compatible:
> +    const: viewe,i2c-backlight

This seems far too generic.
Do we not have access to a part number or something to better identify
this device?

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        backlight@45 {
> +            compatible = "viewe,i2c-backlight";
> +            reg = <0x45>;
> +            default-brightness = <200>;
> +        };
> +    };
> +...
> -- 
> 2.55.0.windows.5
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-11-19 17:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  2:48 Hefei
2026-11-19 17:51 ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119-gravity-unlighted-54fc29aa3dd8@spud \
    --to=conor@kernel.org \
    --cc=3066883572@qq.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®