From: Sander Speetjens <sander.speetjens@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Guenter Roeck <linux@roeck-us.net>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
Peter Robinson <pbrobinson@gmail.com>,
Sander Speetjens <sander.speetjens@gmail.com>
Subject: [PATCH v4 2/2] firmware: raspberrypi: Register PMIC hwmon driver on Pi 5
Date: Thu, 19 Nov 2026 20:55:31 +0100 [thread overview]
Message-ID: <20261119-hwmon-da9091-v4-2-0d6e345c3666@gmail.com> (raw)
In-Reply-To: <20261119-hwmon-da9091-v4-0-0d6e345c3666@gmail.com>
Register the raspberrypi-pmic-hwmon platform device
on BCM2712-based Raspberry Pi 5 systems,
including the BCM2712 D0 revision.
Store the registered device in the firmware state
and unregister it during driver removal
to ensure proper resource cleanup.
Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>
---
drivers/firmware/raspberrypi.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 68512224e3ce..a694ecc18f9c 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -34,6 +34,7 @@ struct rpi_firmware {
struct platform_device *hwmon_dev;
struct platform_device *clk_dev;
+ struct platform_device *pmic_dev;
struct platform_device *rtc_dev;
};
@@ -249,6 +250,23 @@ static void rpi_register_clk_driver(struct device *dev, struct rpi_firmware *fw)
fw->clk_dev = pdev;
}
+static void rpi_register_pmic_driver(struct device *dev, struct rpi_firmware *fw)
+{
+ struct platform_device *pdev;
+
+ /* Only present on Pi 5 (bcm2712) */
+ if (!(of_machine_is_compatible("brcm,bcm2712") ||
+ of_machine_is_compatible("brcm,bcm2712-d0")))
+ return;
+
+ pdev = platform_device_register_data(dev, "raspberrypi-pmic-hwmon",
+ -1, NULL, 0);
+ if (IS_ERR(pdev))
+ return;
+
+ fw->pmic_dev = pdev;
+}
+
static void rpi_register_rtc_driver(struct device *dev, struct rpi_firmware *fw)
{
struct platform_device *pdev;
@@ -371,6 +389,7 @@ static int rpi_firmware_probe(struct platform_device *pdev)
rpi_firmware_print_firmware_revision(fw);
rpi_register_hwmon_driver(dev, fw);
rpi_register_clk_driver(dev, fw);
+ rpi_register_pmic_driver(dev, fw);
rpi_register_rtc_driver(dev, fw);
rpi_register_reboot_mode(dev, fw);
@@ -395,6 +414,8 @@ static void rpi_firmware_remove(struct platform_device *pdev)
fw->hwmon_dev = NULL;
platform_device_unregister(fw->clk_dev);
fw->clk_dev = NULL;
+ platform_device_unregister(fw->pmic_dev);
+ fw->pmic_dev = NULL;
platform_device_unregister(fw->rtc_dev);
fw->rtc_dev = NULL;
--
2.56.1
prev parent reply other threads:[~2026-11-19 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 19:55 [PATCH v4 0/2] hwmon: add Raspberry Pi 5 PMIC driver Sander Speetjens
2026-11-19 19:55 ` [PATCH v4 1/2] hwmon: add Raspberry Pi " Sander Speetjens
2026-11-19 19:55 ` Sander Speetjens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119-hwmon-da9091-v4-2-0d6e345c3666@gmail.com \
--to=sander.speetjens@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=corbet@lwn.net \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=pbrobinson@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®