From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=148.251.105.195 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795100798; b=tIrxJ/4DBn6ULOQ6t/vmci0IPT+LB9y+1QNJGxqUjrSe3w7BnrpSBxQV3aQhkS1aVTlK 8gILAAq2JoJ33vo9fe+5DuiIL5Cc/ZoDFWu60zGxsp5fZzshydt0AzZN/RcpAE39kemKi whOcRxA6bXGM8qTfgUgNowoTyLdZ1y6xbgymo0m/OY7x9ecczdzr4BNvlUwLTC2hSzHXP 9b4wqB3vUCc/W1XdX4wvzL9a/SyiQ0crjURz6Du2JmpsQFSzoMnIQlPUmVpVduBr6uFLT Rm870SEa9rIrt0c9f7UvqPGhyNMNPIubA0YZBFqL1L3vAEOjnSSIvmo9lU5+pSEa8LQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795100798; h=DMARC-Filter:DKIM-Signature:Received:From:Date:Subject:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-Id:References: In-Reply-To:To:Cc:X-Mailer:X-Developer-Signature:X-Developer-Key; bh=Rqb/nEWEhR2vDN5CY9WDUH1E/ys8yi6jdvQyDazbxnA=; b=eXsIDrWPEjI2Sov/2UelWhO6g3ba0kcxjiw/fjMIuZ6N5lr5A2H32hSspu/ObJ2LVTmB zYSx+ENvG8e+axsLCKAjY0orWrXE2HiXDbjZaM+Stngkl958fB0cKevt4icpAesFMSbQz 6E0e/2NanYNgfLkg0vcev3VwkVhIxLEh2Dl+Jcd+ghkVw767mULmfZwUopY3mJVJhtUuA tYqJMHGum+MaWLmWmPIuy39kICV/GaSH1BGl1cH6d1OetgglAK85VX0JcO0TSzJEKMOyX dU0c9IibyAClpvt73hAhwOIg0PJWeJugv/SUX6+fyVX+VuisuZcd8qAI9MT5rVTMMAA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=eDqcu9OS; arc=none smtp.remote-ip=148.251.105.195 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FC20606A7E5; Thu, 19 Nov 2026 15:06:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4FC20606A7E5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=eDqcu9OS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1795100796; bh=4fzohD7Zh0GgLhlnn3k0pyDtJNEK0BIC0cFuRxs0H1U=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=eDqcu9OSV6hIXQnbuLWBQDH1LqiWC+XJDhT+yY4CBcZkwTjG6LyzjM8ZzFCF1GyY6 UNalOnDErp7U/vyNzPSNVv2X4lglc1mArBT0kmCOPaWadwcjYNb8DuBhYGutriYC3y hOutvojIT1I3D2bGE2bAdgCzD1yZDG9aNZ3LXceU3+wbSE+DxKqdlgNazlwDFm75q0 3tsUEtiDWLpDhwNwR4yNAWBvmpqVkbTRz7Si07KLqWOK2Trf9ppDT1O4q/ofCplCqy PBLbIqKIPO7HD9K9keR3b7g1ANOpdOkB0PqUroAYN0nmmsyEgZmDlWgiFINOtHpAI7 QucklFntHubmQ== Received: from yukiji.home (unknown [100.64.0.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id AD9CA17E0E04; Thu, 19 Nov 2026 16:06:35 +0100 (CET) From: Louis-Alexis Eyraud Date: Thu, 19 Nov 2026 16:06:05 +0100 Subject: [PATCH v15 17/23] scsi: ufs: mediatek: Clean up logging prints X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261119-mt8196-ufs-v15-17-aae1eb0382e8@collabora.com> References: <20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com> In-Reply-To: <20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com> To: Chunfeng Yun , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Peter Wang , Chaotian Jing , Alim Akhtar , Bart Van Assche , Bean Huo , Stanley Jhu , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nicolas Frattaroli , Louis-Alexis Eyraud X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1795100772; l=9061; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=oFpCBPkYO7zvk9FKOhxdqAiiZ6dRbJu1RPiq8/IdO3s=; b=vvtS/0HlyLsU7oSqK6AX3Hk6CQuMk98/PotCNPMdtr9oOgiprQ3d7FMG8orvJoSUfP9psDY6Z NxDlsPcpN77AB3GxBPhlaWWEfX7WGy9o16hf8qsJDYWhaznw3uk/tMk X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= From: Nicolas Frattaroli The Linux kernel's log buffer provides many levels of verbosity, associated with different semantic meanings. Care should be taken to only log useful information to the info level, and log errors to the error level. The MediaTek UFS driver does not do this. It freely logs verbose debug information to the info level, errors to the info level, and sometimes errors to the warning level. Adjust all the wrapped kprintf invocations to rectify this situation. Use user-friendly %pe format codes for printing errors where possible. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Peter Wang Signed-off-by: Nicolas Frattaroli Signed-off-by: Louis-Alexis Eyraud --- drivers/ufs/host/ufs-mediatek.c | 90 ++++++++++++++++++----------------------- 1 file changed, 40 insertions(+), 50 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 8c750dbd75e9..cbb0e716ce28 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include "ufshcd-pltfrm.h" @@ -194,8 +195,8 @@ static void ufs_mtk_crypto_enable(struct ufs_hba *hba) ufs_mtk_crypto_ctrl(res, 1); if (res.a0) { - dev_info(hba->dev, "%s: crypto enable failed, err: %lu\n", - __func__, res.a0); + dev_err(hba->dev, "%s: crypto enable failed with error %lu, disabling\n", + __func__, res.a0); hba->caps &= ~UFSHCD_CAP_CRYPTO; } } @@ -591,40 +592,38 @@ static void ufs_mtk_boost_crypt(struct ufs_hba *hba, bool boost) ret = clk_prepare_enable(cfg->clk_crypt_mux); if (ret) { - dev_info(hba->dev, "clk_prepare_enable(): %d\n", - ret); + dev_err(hba->dev, "%s: Failed to enable clk_crypt_mux: %pe\n", + __func__, ERR_PTR(ret)); return; } if (boost) { ret = regulator_set_voltage(reg, volt, INT_MAX); if (ret) { - dev_info(hba->dev, - "failed to set vcore to %d\n", volt); + dev_err(hba->dev, "%s: Failed to set vcore to %d: %pe\n", + __func__, volt, ERR_PTR(ret)); goto out; } - ret = clk_set_parent(cfg->clk_crypt_mux, - cfg->clk_crypt_perf); + ret = clk_set_parent(cfg->clk_crypt_mux, cfg->clk_crypt_perf); if (ret) { - dev_info(hba->dev, - "failed to set clk_crypt_perf\n"); + dev_err(hba->dev, "%s: Failed to reparent clk_crypt_perf: %pe\n", + __func__, ERR_PTR(ret)); regulator_set_voltage(reg, 0, INT_MAX); goto out; } } else { - ret = clk_set_parent(cfg->clk_crypt_mux, - cfg->clk_crypt_lp); + ret = clk_set_parent(cfg->clk_crypt_mux, cfg->clk_crypt_lp); if (ret) { - dev_info(hba->dev, - "failed to set clk_crypt_lp\n"); + dev_err(hba->dev, "%s: Failed to reparent clk_crypt_lp: %pe\n", + __func__, ERR_PTR(ret)); goto out; } ret = regulator_set_voltage(reg, 0, INT_MAX); if (ret) { - dev_info(hba->dev, - "failed to set vcore to MIN\n"); + dev_err(hba->dev, "%s: Failed to set vcore to minimum: %pe\n", + __func__, ERR_PTR(ret)); } } out: @@ -814,10 +813,8 @@ static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on, if (clk_pwr_off) { ufs_mtk_pwr_ctrl(hba, false); } else { - dev_warn(hba->dev, "Clock is not turned off, hba->ahit = 0x%x, AHIT = 0x%x\n", - hba->ahit, - ufshcd_readl(hba, - REG_AUTO_HIBERNATE_IDLE_TIMER)); + dev_warn(hba->dev, "Clock isn't off, hba->ahit = 0x%x, AHIT = 0x%x\n", + hba->ahit, ufshcd_readl(hba, REG_AUTO_HIBERNATE_IDLE_TIMER)); } ufs_mtk_mcq_disable_irq(hba); } else if (on && status == POST_CHANGE) { @@ -861,11 +858,11 @@ static void ufs_mtk_mcq_set_irq_affinity(struct ufs_hba *hba, unsigned int cpu) _cpu = (cpu == 0) ? 3 : cpu; ret = irq_set_affinity(irq, cpumask_of(_cpu)); if (ret) { - dev_err(hba->dev, "set irq %d affinity to CPU %d failed\n", + dev_err(hba->dev, "setting irq %d affinity to CPU %d failed\n", irq, _cpu); return; } - dev_info(hba->dev, "set irq %d affinity to CPU: %d\n", irq, _cpu); + dev_dbg(hba->dev, "set irq %d affinity to CPU %d\n", irq, _cpu); } static bool ufs_mtk_is_legacy_chipset(struct ufs_hba *hba, u32 hw_ip_ver) @@ -881,7 +878,8 @@ static bool ufs_mtk_is_legacy_chipset(struct ufs_hba *hba, u32 hw_ip_ver) default: break; } - dev_info(hba->dev, "legacy IP version - 0x%x, is legacy : %d", hw_ip_ver, is_legacy); + dev_dbg(hba->dev, "IP version 0x%x, legacy = %s", hw_ip_ver, + str_true_false(is_legacy)); return is_legacy; } @@ -986,15 +984,12 @@ static void ufs_mtk_init_clocks(struct ufs_hba *hba) } } - list_for_each_entry(clki, head, list) { - dev_info(hba->dev, "clk \"%s\" present", clki->name); - } + list_for_each_entry(clki, head, list) + dev_dbg(hba->dev, "clk \"%s\" present", clki->name); if (!ufs_mtk_is_clk_scale_ready(hba)) { hba->caps &= ~UFSHCD_CAP_CLK_SCALING; - dev_info(hba->dev, - "%s: Clk-scaling not ready. Feature disabled.", - __func__); + dev_info(hba->dev, "%s: Clock scaling unavailable", __func__); return; } @@ -1004,8 +999,8 @@ static void ufs_mtk_init_clocks(struct ufs_hba *hba) */ reg = devm_regulator_get_optional(dev, "dvfsrc-vcore"); if (IS_ERR(reg)) { - dev_info(dev, "failed to get dvfsrc-vcore: %ld", - PTR_ERR(reg)); + if (PTR_ERR(reg) != -ENODEV) + dev_err(dev, "Failed to get dvfsrc-vcore: %pe\n", reg); return; } @@ -1019,12 +1014,9 @@ static void ufs_mtk_init_clocks(struct ufs_hba *hba) host->mclk.vcore_volt = volt; /* If default boot is max gear, request vcore */ - if (reg && volt && host->clk_scale_up) { - if (regulator_set_voltage(reg, volt, INT_MAX)) { - dev_info(hba->dev, - "Failed to set vcore to %d\n", volt); - } - } + if (reg && volt && host->clk_scale_up) + if (regulator_set_voltage(reg, volt, INT_MAX)) + dev_err(hba->dev, "Failed to set vcore to %d\n", volt); } static void ufs_mtk_setup_clk_gating(struct ufs_hba *hba) @@ -1111,7 +1103,7 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba) } host->mcq_intr_info[i].hba = hba; host->mcq_intr_info[i].irq = irq; - dev_info(hba->dev, "get platform mcq irq: %d, %d\n", i, irq); + dev_dbg(hba->dev, "get platform mcq irq: %d, %d\n", i, irq); } return; @@ -1423,10 +1415,9 @@ static int ufs_mtk_pre_pwr_change(struct ufs_hba *hba, ret = ufshcd_uic_change_pwr_mode(hba, FASTAUTO_MODE << 4 | FASTAUTO_MODE); - if (ret) { - dev_err(hba->dev, "%s: HSG1B FASTAUTO failed ret=%d\n", + if (ret) + dev_err(hba->dev, "%s: HSG1B FASTAUTO failed: ret=%d\n", __func__, ret); - } } /* if already configured to the requested pwr_mode, skip adapt */ @@ -1476,7 +1467,7 @@ static int ufs_mtk_auto_hibern8_disable(struct ufs_hba *hba) out: if (ret) { - dev_warn(hba->dev, "exit h8 state fail, ret=%d\n", ret); + dev_err(hba->dev, "Failed to exit h8 state: %pe\n", ERR_PTR(ret)); ufshcd_force_error_recovery(hba); @@ -1680,12 +1671,12 @@ static int ufs_mtk_link_set_hpm(struct ufs_hba *hba) /* Check link state to make sure exit h8 success */ err = ufs_mtk_wait_idle_state(hba, 5); if (err) { - dev_warn(hba->dev, "wait idle fail, err=%d\n", err); + dev_err(hba->dev, "Failed to wait for idle: %pe\n", ERR_PTR(err)); return err; } err = ufs_mtk_wait_link_state(hba, VS_LINK_UP, 100); if (err) { - dev_warn(hba->dev, "exit h8 state fail, err=%d\n", err); + dev_err(hba->dev, "Failed to wait for link to be up: %pe\n", ERR_PTR(err)); return err; } ufshcd_set_link_active(hba); @@ -1989,20 +1980,19 @@ static void ufs_mtk_event_notify(struct ufs_hba *hba, /* Print details of UIC Errors */ if (evt <= UFS_EVT_DME_ERR) { - dev_info(hba->dev, - "Host UIC Error Code (%s): %08x\n", - ufs_uic_err_str[evt], val); + dev_err(hba->dev, "Host UIC Error Code (%s): %08x\n", + ufs_uic_err_str[evt], val); reg = val; } if (evt == UFS_EVT_PA_ERR) { for_each_set_bit(bit, ®, ARRAY_SIZE(ufs_uic_pa_err_str)) - dev_info(hba->dev, "%s\n", ufs_uic_pa_err_str[bit]); + dev_err(hba->dev, "%s\n", ufs_uic_pa_err_str[bit]); } if (evt == UFS_EVT_DL_ERR) { for_each_set_bit(bit, ®, ARRAY_SIZE(ufs_uic_dl_err_str)) - dev_info(hba->dev, "%s\n", ufs_uic_dl_err_str[bit]); + dev_err(hba->dev, "%s\n", ufs_uic_dl_err_str[bit]); } } @@ -2217,7 +2207,7 @@ static int ufs_mtk_mcq_config_resource(struct ufs_hba *hba) /* fail mcq initialization if interrupt is not filled properly */ if (!host->mcq_nr_intr) { - dev_info(hba->dev, "IRQs not ready. MCQ disabled."); + dev_err(hba->dev, "IRQs not ready. MCQ disabled."); return -EINVAL; } -- 2.56.1