From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH] NFSD: Reject a COPY whose source and destination are the same file
Date: Thu, 19 Nov 2026 09:42:56 -0800 [thread overview]
Message-ID: <20261119-nfsd-copy-same-file-v1-1-ef18e53a00d0@kernel.org> (raw)
RFC 7862 Section 15.2.3 says that COPY MUST fail with NFS4ERR_INVAL
when SAVED_FH and CURRENT_FH refer to the same file, whatever the
ranges. NFSD never checks for this. A same-file COPY with
non-overlapping ranges succeeds, and one with overlapping ranges fails
only because the VFS rejects it.
The overlap-only rule applies to CLONE (Section 15.13.3), so leave
nfsd4_verify_copy() alone. Instead, check in nfsd4_setup_intra_ssc(),
after both stateids are verified. For an inter-server copy, SAVED_FH
names a file on another server, so that path is not affected.
The Linux client never sends a same-file COPY, so this does not change
its behaviour. Found by pynfs COPY11.
Fixes: 29ae7f9dc21a ("NFSD: Implement the COPY call")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfsd/nfs4proc.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 9fba2b67cce2..27e9cd7ebf59 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -2107,9 +2107,23 @@ nfsd4_setup_intra_ssc(struct svc_rqst *rqstp,
struct nfsd4_compound_state *cstate,
struct nfsd4_copy *copy)
{
- return nfsd4_verify_copy(rqstp, cstate, ©->cp_src_stateid,
- ©->nf_src, ©->cp_dst_stateid,
- ©->nf_dst);
+ __be32 status;
+
+ status = nfsd4_verify_copy(rqstp, cstate, ©->cp_src_stateid,
+ ©->nf_src, ©->cp_dst_stateid,
+ ©->nf_dst);
+ if (status)
+ return status;
+
+ /*
+ * RFC 7862 Section 15.2.3: COPY MUST fail with NFS4ERR_INVAL when
+ * SAVED_FH and CURRENT_FH refer to the same file, whether or not the
+ * ranges overlap. The caller releases nf_src and nf_dst.
+ */
+ if (file_inode(copy->nf_src->nf_file) ==
+ file_inode(copy->nf_dst->nf_file))
+ return nfserr_inval;
+ return nfs_ok;
}
static void nfsd4_cb_offload_release(struct nfsd4_callback *cb)
---
base-commit: 00270637d0d956cd6343c41bfd9220ba90360fac
change-id: 20261119-nfsd-copy-same-file-2477054222d6
Best regards,
--
Jeff Layton <jlayton@kernel.org>
reply other threads:[~2026-11-19 17:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119-nfsd-copy-same-file-v1-1-ef18e53a00d0@kernel.org \
--to=jlayton@kernel.org \
--cc=Anna.Schumaker@netapp.com \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®