mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Venkat Yadlapati via B4 Relay <devnull+venkat.yadlapati.yahoo.com@kernel.org>
To: Venkat Yadlapati <venkat.yadlapati@yahoo.com>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,  Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, phone-devel@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] ASoC: Add the NXP TFA9865 amplifier
Date: Thu, 19 Nov 2026 14:01:45 +0530	[thread overview]
Message-ID: <20261119-vantage-tfa9865-v3-0-5257fa45df57@yahoo.com> (raw)

The Motorola Signature has two NXP (now Goodix) TFA9865 mono class-D
speaker amplifiers. This series adds the devicetree binding and a driver.

The chip has no DSP and a different register map than the TFA989x parts
of tfa989x.c. The driver applies the initialization sequence for the
device revision, selects the I2S slot feeding the amplifier and powers
the amplifier and its boost converter up and down. The register settings
come from the NXP tfa98xx driver. Only the B0 revision and the 32-bit I2S
slots configured at reset are supported for now.

Tested on a Motorola Signature: with the matching sound card the speaker
and the earpiece play audio. The register cache, rebinding both amplifiers
and switching an amplifier on and off during playback were tested too.

I used an LLM (Claude) to help write these patches and their commit
messages. I reviewed all of them and tested the result on the device.

---
Changes in v3:
- Driver: cache the registers (REGCACHE_MAPLE) as suggested by Mark Brown,
  thanks for the review.
  Only the registers the chip changes by itself (SYS_CTRL0 with the
  self-clearing I2CR, the status and interrupt flags, the unlock keys)
  stay volatile. The cache is dropped after the I2CR reset in the
  initialization, so a rebind does not use stale values.
- Link to v2: https://patch.msgid.link/20261116-vantage-tfa9865-v2-0-a93f976c9479@yahoo.com

Changes in v2:
- Binding: drop the redundant sound-name-prefix entry (comes from
  dai-common.yaml).
- Driver: no longer mute/unmute from the trigger callback, the register
  access sleeps. The amplifier is now enabled from mute_stream and a DAPM
  event on the AMPE widget, only while the path is powered and the stream
  is unmuted, so toggling "Amp Switch" during playback keeps it in sync.
- Driver: reset the registers (I2CR) at the start of the initialization,
  so a rebind without a reset GPIO does not find MANSCONF still set.
- Link to v1: https://patch.msgid.link/20261116-vantage-tfa9865-v1-0-e88f0dccc427@yahoo.com

---
Venkat Yadlapati (2):
      ASoC: dt-bindings: Add NXP TFA9865 amplifier
      ASoC: codecs: Add NXP TFA9865 amplifier driver

 .../devicetree/bindings/sound/nxp,tfa9865.yaml     |  63 ++++
 MAINTAINERS                                        |   7 +
 sound/soc/codecs/Kconfig                           |  14 +
 sound/soc/codecs/Makefile                          |   2 +
 sound/soc/codecs/tfa9865.c                         | 400 +++++++++++++++++++++
 5 files changed, 486 insertions(+)
---
base-commit: 4e019254b80b70f6fb90d17a50f211de1daf7ffe
change-id: 20261116-vantage-tfa9865-8885091e9443

Best regards,
--  
Venkat Yadlapati <venkat.yadlapati@yahoo.com>



             reply	other threads:[~2026-11-19  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:31 Venkat Yadlapati via B4 Relay [this message]
2026-11-19  8:31 ` [PATCH v3 1/2] ASoC: dt-bindings: Add " Venkat Yadlapati via B4 Relay
2026-11-19  8:31 ` [PATCH v3 2/2] ASoC: codecs: Add NXP TFA9865 amplifier driver Venkat Yadlapati via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119-vantage-tfa9865-v3-0-5257fa45df57@yahoo.com \
    --to=devnull+venkat.yadlapati.yahoo.com@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    --cc=venkat.yadlapati@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®