From: Jonathan Cameron <jic23@kernel.org>
To: Joseph Telaak <joseph@telaak.dev>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Peter Rosin" <peda@lysator.liu.se>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@analog.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] iio: potentiometer: mcp4018: Add Analog Devices AD5246
Date: Thu, 19 Nov 2026 03:45:36 +0000 [thread overview]
Message-ID: <20261119034536.6e5a3b9a@jic23-hlaptop> (raw)
In-Reply-To: <CAPY4CJ4zHV-wCszetvFnVNA=v5O_rhY1YAeMNhS8r3nWC5wJCw@mail.gmail.com>
On Tue, 17 Nov 2026 14:31:48 -0500
Joseph Telaak <joseph@telaak.dev> wrote:
> On Tue, Nov 17, 2026, Andy Shevchenko wrote:
> > Make it shorter and more generic, in this way you spread the same text to the
> > top comment in the file
> > ...
> > and to MODULE_DESCRIPTION().
>
> Will do in v2, with your wording.
>
> > And here make it list that is scalable to expand
>
> Will do.
>
> > Keep it sorted.
>
> Will do, for the DEVID comment, the enum and the cfg table.
>
> > Why signed? Can the HW return something negative?
>
> No, I'll make it unsigned int in v2.
>
> > Strictly speaking this patch can be split to two:
> > - adding 'div' member and providing it for the existing chips
> > - adding new chip support
>
> Will split it in v2.
Small process thing. Crop replies to where you want more
discussion. If you don't have anything that needs more
discussion then don't reply. What changed can wait for
the changelog of the next version.
Saves us all a bunch of email reading!
I send this mail pretty often. It is kind of a request
to be less polite in the interests of efficiency!
Thanks,
Jonathan
next prev parent reply other threads:[~2026-11-19 3:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:59 [PATCH 0/5] " Joseph Telaak
2026-11-16 22:59 ` [PATCH 1/5] iio: ABI: Move out_resistance_raw_available to sysfs-bus-iio Joseph Telaak
2026-11-17 8:10 ` Andy Shevchenko
2026-11-17 8:20 ` Joseph Telaak
2026-11-16 22:59 ` [PATCH 2/5] iio: potentiometer: mcp4018: Report the available wiper positions Joseph Telaak
2026-11-17 8:13 ` Andy Shevchenko
2026-11-17 19:35 ` Joseph Telaak
2026-11-16 22:59 ` [PATCH 3/5] dt-bindings: iio: potentiometer: Add Analog Devices AD5246 Joseph Telaak
2026-11-17 17:43 ` Conor Dooley
2026-11-17 20:04 ` Joseph Telaak
2026-11-18 18:07 ` Conor Dooley
2026-11-16 22:59 ` [PATCH 4/5] iio: potentiometer: mcp4018: Turn on the vdd supply Joseph Telaak
2026-11-17 8:16 ` Andy Shevchenko
2026-11-17 8:25 ` Joseph Telaak
2026-11-16 22:59 ` [PATCH 5/5] iio: potentiometer: mcp4018: Add Analog Devices AD5246 Joseph Telaak
2026-11-17 8:27 ` Andy Shevchenko
2026-11-17 19:31 ` Joseph Telaak
2026-11-19 3:45 ` Jonathan Cameron [this message]
2026-11-19 3:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119034536.6e5a3b9a@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=peda@lysator.liu.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®