From: Siqi Chen <chensiqi@uniontech.com>
To: jagathjog1996@gmail.com, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: imu: bmi323: check i2c_transfer() return value
Date: Thu, 19 Nov 2026 15:08:37 +0800 [thread overview]
Message-ID: <20261119070837.3844364-1-chensiqi@uniontech.com> (raw)
i2c_transfer() returns the number of messages transferred or a negative
error code. The BMI323 I2C read path only checks for negative values and
maps all errors to -EIO.
If only the register-address message is transferred, the function copies
data from the receive buffer and reports success even though the read
message was not completed.
Require both messages to be transferred, preserve negative error codes,
and return -EIO for a short transfer.
OpenCode was used to identify the issue and draft the code and changelog.
Compile-tested with CONFIG_BMI323_I2C=m using:
make O=/tmp/opencode/linux-build-bmi323 W=1 \
drivers/iio/imu/bmi323/bmi323_i2c.o
No hardware or I2C fault-injection testing was performed.
Fixes: 8a636db3aa57 ("iio: imu: Add driver for BMI323 IMU")
Signed-off-by: Siqi Chen <chensiqi@uniontech.com>
---
drivers/iio/imu/bmi323/bmi323_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
index e025c88c30b4..18f05f119961 100644
--- a/drivers/iio/imu/bmi323/bmi323_i2c.c
+++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
@@ -40,8 +40,8 @@ static int bmi323_regmap_i2c_read(void *context, const void *reg_buf,
msgs[1].flags = priv->i2c->flags | I2C_M_RD;
ret = i2c_transfer(priv->i2c->adapter, msgs, ARRAY_SIZE(msgs));
- if (ret < 0)
- return -EIO;
+ if (ret != ARRAY_SIZE(msgs))
+ return ret < 0 ? ret : -EIO;
memcpy(val_buf, priv->i2c_rx_buffer + BMI323_I2C_DUMMY, val_size);
base-commit: c1b99c6982dccade0199879966a2d97f27a0a110
--
2.20.1
next reply other threads:[~2026-11-19 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:08 Siqi Chen [this message]
2026-11-19 9:27 ` Joshua Crofts
2026-11-19 9:30 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119070837.3844364-1-chensiqi@uniontech.com \
--to=chensiqi@uniontech.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®