From: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
To: lars@metafoo.de, perex@perex.cz, tiwai@suse.de
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Subject: [PATCH] ALSA: dmaengine: Check DMA submission errors
Date: Thu, 19 Nov 2026 07:10:43 +0000 [thread overview]
Message-ID: <20261119071043.2943-1-sreekuttan2156239@gmail.com> (raw)
The dmaengine_pcm_prepare_and_submit() function does not check
the return value of dmaengine_submit().
dmaengine_submit() can return a negative DMA cookie if the
submission fails. However, the function currently returns
success unconditionally.
This makes the PCM trigger path believe that DMA has been
successfully submitted, even when the submission has failed.
Use dma_submit_error() to check the returned DMA cookie and
propagate the error to the caller.
This ensures that DMA submission failures are properly
reported instead of allowing the PCM stream to continue
as if the DMA transfer had started successfully.
Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
---
sound/core/pcm_dmaengine.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
index 1306b04be171..5b9fdad4d9a4 100644
--- a/sound/core/pcm_dmaengine.c
+++ b/sound/core/pcm_dmaengine.c
@@ -154,6 +154,7 @@ static int dmaengine_pcm_prepare_and_submit(struct snd_pcm_substream *substream)
struct dma_async_tx_descriptor *desc;
enum dma_transfer_direction direction;
unsigned long flags = DMA_CTRL_ACK;
+ int ret;
direction = snd_pcm_substream_to_dma_direction(substream);
@@ -172,6 +173,9 @@ static int dmaengine_pcm_prepare_and_submit(struct snd_pcm_substream *substream)
desc->callback = dmaengine_pcm_dma_complete;
desc->callback_param = substream;
prtd->cookie = dmaengine_submit(desc);
+ ret = dma_submit_error(prtd->cookie);
+ if (ret)
+ return ret;
return 0;
}
--
2.55.0
next reply other threads:[~2026-11-19 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:10 Sreeraj S Kurup [this message]
2026-11-19 7:36 ` [PATCH v2] " Sreeraj S Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119071043.2943-1-sreekuttan2156239@gmail.com \
--to=sreekuttan2156239@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®