From: Orgad Shaneh <orgads@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: dwmw2@infradead.org, richard@nod.at, miquel.raynal@bootlin.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] jffs2: reschedule between the data CRC checks of an inode
Date: Thu, 19 Nov 2026 08:01:49 +0000 [thread overview]
Message-ID: <20261119080149.311902-1-orgads@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-222025@kernel.org>
> Should this include: Fixes: df8e96f39103 ("[JFFS2] Improve read_inode
> memory usage, v2.")
Yes. Before that commit, the loop in jffs2_do_read_inode_internal()
called cond_resched() before each node it added to the fragtree, data
check included; the loop that replaced it in
jffs2_build_inode_fragtree() has none.
Richard, can you add the tag when applying, or do you prefer a v2?
Fixes: df8e96f39103 ("[JFFS2] Improve read_inode memory usage, v2.")
prev parent reply other threads:[~2026-11-19 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 21:40 [PATCH 1/2] jffs2: check the data CRC of a node in RAM, not through point() Orgad Shaneh
2026-11-18 21:40 ` [PATCH 2/2] jffs2: reschedule between the data CRC checks of an inode Orgad Shaneh
[not found] ` <sashiko-outbox-222025@kernel.org>
2026-11-19 8:01 ` Orgad Shaneh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119080149.311902-1-orgads@gmail.com \
--to=orgads@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®