From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=148.251.105.195 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795074749; b=fXx63E1zLZZW9g7ZJ20EKafbmsEuxYPtjezgZ5GMBVkYQPdRzUw7m5SKrHF8uCqPs/og 0vCz04n1oHxVWvoX8yD1BGCeFt5KDKifHYcpiaxK/OLcKu5dbx0gf+y4fHDxMYTLpaHRG po+vhf+z3XECKVP7RAiXOR3vOo6FEPluBhMF4uT0vsr2evkXDqwzx6Ca+CNDeyoT2EDss dLDVyxdUqUF+1KOBhvoYc+2DI+JAtGruyU4u0AdNSAPKwmlnX96riTJJek5dOYH3MPb4s CeH32Wv3bwwn8aiR71I5Xc3AMi/5g9IeZB6jYSLHdTfXy8CEyaen2k7smH0L/dlhG6g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795074749; h=DMARC-Filter:DKIM-Signature:Received:Date:From:To:Cc:Subject: Message-ID:In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=2Sr5PSorXFPiZTIgL+esYlLaqyXGsyfpobS6SIpcVCo=; b=VJsflQvSaDCs39k0GdxERVp8wc4bi3kh67QXGpQ/98Hl+ShSr1gKuUj+r4Mxv1KVXa/y RKBmnQpRjQLNuJRo5rTiuB/MtD1WX33dU2M5wy3YU5HlqUKWOtVHY9hJYon+ZgmigAmSM ++7LTLbUzq3lUvRTjEqnzK8k/Yfs8WJQbm5Z2b9P6tcjoN4vREnDDE52D0kGHJnZpFY7N WdqGP+nOoiv1t/7/MVD5H+QH9VsfVOcNxpv9oFkzhbHvWP1S0ixJ4qVh/vq649KJE+Ot0 uHjelXSQo57j5YDZlIgOX6xMaFsy19i6kXD5L5Di2oxwJxu39RvTQFxQm8/d9MIGq6g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=b8wh1A5q; arc=none smtp.remote-ip=148.251.105.195 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC4A606A320 for ; Thu, 19 Nov 2026 07:52:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org ADC4A606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=b8wh1A5q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1795074746; bh=z3gDAv4QNYmxE66TTQpSpU4usvXBzFzl9h/ykF/+X9w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b8wh1A5qYU6sryQ73tQQyo3/FpagnSEyevlpSIe8MMJKez3aibJCdFH7jhxeZo/5D zly8Y7JQf5EbH4z2pMxA139eMtG2a69QU5Ip5DF+Q9QQYFVTFUshkwBKHpdBsLiCJ8 v+lRRXzwGjlo17jvirXYqLq3fx1fUojMwE6X1btc7WDzuTHZA9lf+g7zl2NkkNVz+N qc5utInd8dGVdOXtWum+9yt8yykUVjfca0IEMWcD/EbRBgRb6k1UgffJeKY/1RUBD8 Y3ijeBniXES7nm+5AN15uu3eZ+PlpR1bi28rPUYC0aGvppcwZ8DERt+d7YBsms9MVC y3DffkcRb5T0Q== Received: from fedora1.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5E37817E00E8; Thu, 19 Nov 2026 08:52:26 +0100 (CET) Date: Thu, 19 Nov 2026 08:52:20 +0100 From: Boris Brezillon To: Karunika Choo Cc: dri-devel@lists.freedesktop.org, nd@arm.com, Steven Price , Liviu Dudau , linux-kernel@vger.kernel.org, Akash Goel , Lukas Zapolskas , Chris Diamand , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 02/10] drm/panthor: Rename neural accelerator feature macro to NX Message-ID: <20261119085220.033b47d5@fedora1.home> In-Reply-To: <20261118175332.519657-3-karunika.choo@arm.com> References: <20261118175332.519657-1-karunika.choo@arm.com> <20261118175332.519657-3-karunika.choo@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 18 Nov 2026 17:53:18 +0000 Karunika Choo wrote: > Rename GPU_FEATURES_NEURAL_ENGINE to GPU_FEATURES_NX. > Update the panthor_hw helper to use the new name. > > Signed-off-by: Karunika Choo Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panthor/panthor_gpu_regs.h | 2 +- > drivers/gpu/drm/panthor/panthor_hw.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_gpu_regs.h b/drivers/gpu/drm/panthor/panthor_gpu_regs.h > index 5340966caef37..c7581b6d4c5be 100644 > --- a/drivers/gpu/drm/panthor/panthor_gpu_regs.h > +++ b/drivers/gpu/drm/panthor/panthor_gpu_regs.h > @@ -67,7 +67,7 @@ > > #define GPU_FEATURES 0x60 > #define GPU_FEATURES_RAY_INTERSECTION BIT(2) > -#define GPU_FEATURES_NEURAL_ENGINE BIT(4) > +#define GPU_FEATURES_NX BIT(4) > #define GPU_FEATURES_RAY_TRAVERSAL BIT(5) > > #define GPU_TIMESTAMP_OFFSET 0x88 > diff --git a/drivers/gpu/drm/panthor/panthor_hw.h b/drivers/gpu/drm/panthor/panthor_hw.h > index eeca936f44bae..f770dc40e6216 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.h > +++ b/drivers/gpu/drm/panthor/panthor_hw.h > @@ -64,7 +64,7 @@ static inline bool panthor_hw_has_pwr_ctrl(struct panthor_device *ptdev) > static inline bool panthor_hw_has_neural(struct panthor_device *ptdev) > { > return (GPU_ARCH_MAJOR(ptdev->gpu_info.gpu_id) >= 14 && > - ptdev->gpu_info.gpu_features & GPU_FEATURES_NEURAL_ENGINE); > + ptdev->gpu_info.gpu_features & GPU_FEATURES_NX); > } > > #endif /* __PANTHOR_HW_H__ */