From: Peter Zijlstra <peterz@infradead.org>
To: Fushuai Wang <fushuai.wang@linux.dev>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, kprateek.nayak@amd.com,
sshegde@linux.ibm.com, linux-kernel@vger.kernel.org,
wangfushuai@baidu.com
Subject: Re: [PATCH v2] sched/core: Fix a TOCTOU bug in sched_non_preferred_cpu_push_stop()
Date: Thu, 19 Nov 2026 10:07:28 +0100 [thread overview]
Message-ID: <20261119090728.GN2668804@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261118065921.98260-1-fushuai.wang@linux.dev>
On Wed, Nov 18, 2026 at 02:59:21PM +0800, Fushuai Wang wrote:
> From: Fushuai Wang <wangfushuai@baidu.com>
>
> sched_push_current_non_preferred_cpu() is called in irq context. It
> checks is_migration_disabled() before queuing the stopper.
>
> migrate_disable() sets p->migration_disabled in preempt_disable() section.
> An irq can hit after preempt_disable() but before p->migration_disabled=1.
> After the irq returns, the task cannot be preempted by stopper becuase
> preemption is disabled, so it finishes setting p->migration_disabled=1
> before the stopper runs.
>
> It may be like:
> task context: irq context:
> migrate_disable()
> preempt_disable()
> is_migration_disabled()
> migration_disabled = 1
> preempt_enable()
>
> So recheck is_migration_disabled() in sched_non_preferred_cpu_push_stop()
> before calling __migrate_task().
>
*sigh*:
https://lore.kernel.org/r/20260925074953.GG4121339@noisy.programming.kicks-ass.net
> Fixes: 74699f56ebcf ("sched/core: Push current task from non preferred CPU")
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
> v1->v2: No code changes, just improve the commit message.
>
> kernel/sched/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 5ed660f099a5..6f9374aa3f19 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -11314,7 +11314,8 @@ static int sched_non_preferred_cpu_push_stop(void *arg)
> rq->npc_push_work_pending = false;
> update_rq_clock(rq);
>
> - if (task_rq(p) == rq && task_on_rq_queued(p)) {
> + if (task_rq(p) == rq && task_on_rq_queued(p) &&
> + !is_migration_disabled(p)) {
> struct rq *dest_rq = __migrate_task(rq, &rf, p, cpu);
>
> if (rq != dest_rq)
I think I like a comment with this. Perhaps add something like:
/*
* Racy: is_migration_disabled(current) isn't stable.
*/
if (is_migration_disabled(push_task))
return;
in sched_push_current_non_preferred_cpu().
Also, I wonder if you'd find more of this if you stick something like:
lockdep_assert(!task_on_cpu(p) || in_task());
inside is_migration_disabled().
prev parent reply other threads:[~2026-11-19 9:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:59 Fushuai Wang
2026-11-18 9:06 ` Shrikanth Hegde
2026-11-19 9:07 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119090728.GN2668804@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fushuai.wang@linux.dev \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®