From: Lee Jones <lee@kernel.org>
To: lee@kernel.org, Mark Brown <broonie@kernel.org>,
Johan Hovold <johan@kernel.org>,
Johannes Thumshirn <jth@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: [PATCH 03/10] spi: ch341: Limit transfers to the hardware packet size
Date: Thu, 19 Nov 2026 09:17:15 +0000 [thread overview]
Message-ID: <20261119091810.3440619-4-lee@kernel.org> (raw)
In-Reply-To: <20261119091810.3440619-1-lee@kernel.org>
ch341_transfer_one() clamps each transfer to CH341_PACKET_LENGTH bytes,
of which the first is the command byte, so at most 31 data bytes are
moved. It nevertheless reports success for the whole transfer.
The driver does not provide a max_transfer_size() callback, so the SPI
core never splits longer transfers. The remainder of the data is
silently dropped, and on the receive side the caller sees whatever was
already in its buffer. For spidev this means stale or uninitialised
kernel heap from its bounce buffer is copied out to user space.
Report the real limit through max_transfer_size() so that the SPI core
splits long transfers into chunks the hardware can handle.
Fixes: 8846739f52af ("spi: add ch341a usb2spi driver")
Closes: https://sashiko.dev/#/bug/linux-a21e23dc-14b5-4ed1-bfba-f508132e11a0
Cc: stable@vger.kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
drivers/spi/spi-ch341.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/spi/spi-ch341.c b/drivers/spi/spi-ch341.c
index 56a5caa5975a..0783a2d39a61 100644
--- a/drivers/spi/spi-ch341.c
+++ b/drivers/spi/spi-ch341.c
@@ -63,6 +63,11 @@ static void ch341_set_cs(struct spi_device *spi, bool is_high)
"error sending USB message for setting CS (%d)\n", err);
}
+static size_t ch341_max_transfer_size(struct spi_device *spi)
+{
+ return CH341_PACKET_LENGTH - 1;
+}
+
static int ch341_transfer_one(struct spi_controller *host,
struct spi_device *spi,
struct spi_transfer *trans)
@@ -187,6 +192,7 @@ static int ch341_probe(struct usb_interface *intf,
ctrl->bus_num = -1;
ctrl->mode_bits = SPI_CPHA;
ctrl->transfer_one = ch341_transfer_one;
+ ctrl->max_transfer_size = ch341_max_transfer_size;
ctrl->set_cs = ch341_set_cs;
ctrl->auto_runtime_pm = false;
/*
--
2.56.1.708.g77570a6a1d-goog
next prev parent reply other threads:[~2026-11-19 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:17 [PATCH 00/10] spi: Fix data corruption, uninitialised data leaks and bounds checks Lee Jones
2026-11-19 9:17 ` [PATCH 01/10] spi: fsl-cpm: Map the zero page's address, not its struct page Lee Jones
2026-11-19 9:17 ` [PATCH 02/10] spi: bcm2835: Store native chip-select GPIO descriptor per device Lee Jones
2026-11-19 9:17 ` Lee Jones [this message]
2026-11-19 9:17 ` [PATCH 04/10] spi: sprd-adi: Do not copy uninitialised data to rx_buf on read failure Lee Jones
2026-11-19 9:17 ` [PATCH 05/10] spi: topcliff-pch: Advance tx_buf between DMA chunks Lee Jones
2026-11-19 9:17 ` [PATCH 06/10] spi: cadence-quadspi: Bound chip select against f_pdata array size Lee Jones
2026-11-19 9:17 ` [PATCH 07/10] spi: cadence-xspi: Zero the tail word in m_iowriteq() Lee Jones
2026-11-19 9:17 ` [PATCH 08/10] spi: fsl-qspi: Propagate clock errors from fsl_qspi_select_mem() Lee Jones
2026-11-19 9:17 ` [PATCH 09/10] spi: cadence-xspi: Advance tx pointer between Marvell b0 chunks Lee Jones
2026-11-19 9:17 ` [PATCH 10/10] spi: cadence-xspi: Skip tail read for qword-aligned Marvell b0 receives Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119091810.3440619-4-lee@kernel.org \
--to=lee@kernel.org \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®