From: Ping Li <leeonion.muyu@gmail.com>
To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
leeonion.muyu@gmail.com
Subject: Re: [RFC PATCH 1/1] mtd: mtdchar: use kvmalloc() for large read/write buffers
Date: Thu, 19 Nov 2026 17:38:01 +0800 [thread overview]
Message-ID: <20261119093801.1447618-1-leeonion.muyu@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-222838@kernel.org>
From: leeonion.muyu@gmail.com
Hi,
Thanks for the review. I verified the three findings in the tree and
all of them check out.
1. powernv_flash registers _read/_write directly and passes __pa(buf)
down to OPAL (powernv_flash.c:69, :220), so a vmalloc'd buffer
would hand firmware a bogus physical address. fsmc_nand.c:505,
intel-nand-controller.c:312 and r852.c:196 dma_map_single() the
buffer without any virt_addr_valid() check. This also explains
why the 2022 ioctl conversion (83208e106a8e8) was safe: MEMREAD
and MEMWRITE require _read_oob/_write_oob, which these drivers do
not implement.
2. Agreed on the low-memory regression: kvmalloc() makes a single
kmalloc() attempt and then goes straight to vmalloc(), so the
size backoff that used to make progress under fragmentation is
gone. The stale comment above mtdchar_read() is my oversight.
3. Agreed that "shrink first, vmalloc last" is the right shape;
jumping to vmalloc while intermediate contiguous sizes are still
available trades a cheap shrink for an expensive bounce path.
So the answer to the cover letter's question is: quite concerned.
Plain kvmalloc() in the _read/_write path is a no-go as long as
drivers assume a linear-map buffer.
The options I see from here:
a) a small pre-cleanup series making the affected drivers
vmalloc-safe (bounce or reject), then converting
mtdchar_read()/mtdchar_write() with the size backoff kept and
vmalloc only as a last resort;
b) keeping the current halving-only behavior and dropping this
RFC.
I am happy to work on (a) if that direction is acceptable;
otherwise I will withdraw the RFC.
Thanks,
Ping
next prev parent reply other threads:[~2026-11-19 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <sashiko-outbox-222838@kernel.org>
2026-11-19 9:37 ` Ping Li
2026-11-19 9:38 ` Ping Li [this message]
2026-11-19 9:39 ` Ping Li
2026-11-19 9:00 [RFC PATCH 0/1] mtdchar: kvmalloc() for large read/write buffers? ping.li
2026-11-19 9:08 ` [RFC PATCH 1/1] mtd: mtdchar: use kvmalloc() for large read/write buffers Ping Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119093801.1447618-1-leeonion.muyu@gmail.com \
--to=leeonion.muyu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®