From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: a0282524688@gmail.com
Cc: lee@kernel.org, Ming Yu <tmyu0@nuvoton.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, mfd@lists.linux.dev,
linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH v10 05/13] mfd: nct6694: Drop the unused IRQ enable mask
Date: Thu, 19 Nov 2026 11:12:33 +0100 [thread overview]
Message-ID: <20261119101233.Z-LmZvya@linutronix.de> (raw)
In-Reply-To: <20261118081625.2399247-6-a0282524688@gmail.com>
On 2026-11-18 16:16:16 [+0800], a0282524688@gmail.com wrote:
> From: Ming Yu <a0282524688@gmail.com>
>
> The .irq_enable and .irq_disable callbacks only update the irq_enable
> bitmask under irq_lock, which is a spinlock_t. Nothing ever reads that
> bitmask, so the callbacks do not mask anything. They also take irq_lock
> while the IRQ core holds desc->lock, a raw spinlock. On PREEMPT_RT this
> is an invalid wait context.
>
> Remove both callbacks, along with irq_enable and irq_lock, and keep
> IRQCHIP_SKIP_SET_WAKE. Without .irq_disable, the IRQ core falls back to
> lazy disable, and handle_simple_irq() keeps a disabled interrupt pending
> instead of calling its handler. The behaviour is therefore unchanged.
>
> Fixes: 51dad33ede63 ("mfd: Add core driver for Nuvoton NCT6694")
> Signed-off-by: Ming Yu <a0282524688@gmail.com>
This sort of makes sense. But how does this work? If the interrupt keeps
coming the irq-core will just suppress it?
If that is your whole business why not use dummy_irq_chip?
As far as the change goes,
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2026-11-19 10:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:16 [PATCH v10 00/13] mfd: nct6694: Refactor transport layer and add HIF (eSPI) support a0282524688
2026-11-18 8:16 ` [PATCH v10 01/13] mfd: nct6694: Validate the USB endpoints a0282524688
2026-11-18 8:16 ` [PATCH v10 02/13] mfd: nct6694: Check the length of received USB packets a0282524688
2026-11-18 8:16 ` [PATCH v10 03/13] mfd: nct6694: Ignore interrupts without a mapping a0282524688
2026-11-18 8:16 ` [PATCH v10 04/13] mfd: nct6694: Transfer data packets via a dedicated buffer a0282524688
2026-11-18 8:16 ` [PATCH v10 05/13] mfd: nct6694: Drop the unused IRQ enable mask a0282524688
2026-11-19 10:12 ` Sebastian Andrzej Siewior [this message]
2026-11-18 8:16 ` [PATCH v10 06/13] mfd: nct6694: Move module type macros to shared header a0282524688
2026-11-18 8:16 ` [PATCH v10 07/13] mfd: nct6694: Refactor USB-specific data into nct6694_usb_data a0282524688
2026-11-18 8:16 ` [PATCH v10 08/13] mfd: nct6694: Rename USB transport functions with _usb_ prefix a0282524688
2026-11-18 8:16 ` [PATCH v10 09/13] mfd: nct6694: Rename driver to nct6694-usb a0282524688
2026-11-18 8:16 ` [PATCH v10 10/13] mfd: nct6694: Extract core device management into a separate module a0282524688
2026-11-18 8:16 ` [PATCH v10 11/13] mfd: nct6694: Introduce regmap-based transport abstraction a0282524688
2026-11-18 8:16 ` [PATCH v10 12/13] mfd: nct6694: Add a Kconfig symbol for the USB transport a0282524688
2026-11-18 8:16 ` [PATCH v10 13/13] mfd: nct6694: Add Host Interface (HIF) eSPI transport driver a0282524688
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119101233.Z-LmZvya@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=a0282524688@gmail.com \
--cc=clrkwllms@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mfd@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=tmyu0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®