mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: David Hildenbrand <david@kernel.org>
Cc: Yeoreum Yun <yeoreum.yun@arm.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lorenzo Stoakes <ljs@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Peter Xu <peterx@redhat.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	Mike Rapoport <rppt@kernel.org>, Michal Hocko <mhocko@suse.com>
Subject: [PATCH] mm/gup: unshare-check every page of a pte batch
Date: Thu, 19 Nov 2026 10:57:01 -0500	[thread overview]
Message-ID: <20261119105701.3f57ac54@fangorn> (raw)

A write pin over a PTE batch can hand back pages that a later
write fault replaces under the pin holder: the process writes to
the copy, the holder keeps the old page:

    pin holder                          process (mm owner)
    pin all 16 for write
      batch passes unchecked
                                        write to a tail page
                                          fault copies it elsewhere
    read pinned page -> stale

For every FOLL_WRITE call the helper returns the whole run on
the head page's credentials, never reaching the per-page loop below.
After fork, a FOLL_FORCE write unsharing only the head leaves
the tail pages read-only and non-exclusive behind identical
PTEs, which batching (PTE bits only, never the exclusivity flag)
covers at once.

A page pinned for write must be exclusive to the pinning process,
and one vetted PTE proves that for one page only. FOLL_GET and
single-page FOLL_WRITE keep the shortcut; multi-page callers run
the per-page check. Writable batches and GUP-fast are unchanged.

Without this fix, the pin holder sees stale page content,
with it the pin and program address map the same page.

Signed-off-by: Rik van Riel <riel@surriel.com>
---
This fix applies on gup-7.5-ptebatch in mm/core.git

 mm/gup.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index b0a0019de80a..6b6e4c6f8144 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -639,15 +639,25 @@ static unsigned long gup_pages_not_requiring_unshare(
 {
 	unsigned int i;
 
+	/* A short term reference does not need the pages to be exclusive. */
+	if (!(flags & FOLL_PIN))
+		return nr_pages;
+
 	/*
-	 * FOLL_WRITE is implicitly handled correctly as the page table entry
-	 * has to be writable -- and if it references (part of) an anonymous
-	 * folio, that part is required to be marked exclusive.
+	 * FOLL_WRITE for a single page is checked by the caller, which
+	 * checked that the page table entry is writable, or FOLL_FORCE
+	 * on an exclusive anonymous page; if it references (part of) an
+	 * anonymous folio, that is exclusive.
 	 */
-	if ((flags & (FOLL_WRITE | FOLL_PIN)) != FOLL_PIN)
+	if ((flags & FOLL_WRITE) && nr_pages == 1)
 		return nr_pages;
 
-	/* folio_test_anon(folio) is stable until folio gets freed. */
+	/*
+	 * Check each page for suitability below. The caller may have
+	 * only checked the page tables.
+	 *
+	 * folio_test_anon(folio) is stable until folio gets freed.
+	 */
 	if (!folio_test_anon(folio)) {
 		/*
 		 * We only care about R/O long-term pining: R/O short-term
-- 
2.56.0


             reply	other threads:[~2026-11-19 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:57 Rik van Riel [this message]
2026-11-19 16:16 ` David Hildenbrand (Arm)
2026-11-19 16:20   ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119105701.3f57ac54@fangorn \
    --to=riel@surriel.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®