mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pushpendra Singh <pushpendra.singh@oss.qualcomm.com>
To: krzk@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
	abelvesa@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pushpendra Singh <pushpendra.singh@oss.qualcomm.com>
Subject: [PATCH v4] devfreq: qcom: bwmon: Reduce zone1 threshold count to 3
Date: Thu, 19 Nov 2026 17:14:26 +0530	[thread overview]
Message-ID: <20261119114426.4050161-1-pushpendra.singh@oss.qualcomm.com> (raw)

Reduce zone1_thres_count from 16 to 3 so the driver can lower the bus
vote after 3 sample windows instead of waiting for 16. The previous
16‑window delay (~64 ms) is too long at higher FPS workloads,
causing delayed decision making and measurable power regression.

Power and performance measurements were collected for
zone1_thres_count = 3 and 16, with the following results:

Usecase                         zone1_cnt=16	zone1_cnt=3       Delta
YouTube streaming (power)	4126.49 mW	3991.30 mW      -3.28%
Google Meet audio (power)	3058.79 mW	2929.73 mW      -4.22%
Speedometer 3.1(perf)		25.8		26.5            +2.7%
Geekbench 6.5 ST(perf)		3907		3905            -0.1%
Geekbench 6.5 MT(perf)		18636		18680           +0.2%

The reduced threshold therefore allows BWMON to react sooner to falling
bandwidth demand, providing measurable power savings in the tested
workloads without a meaningful performance regression.

Signed-off-by: Pushpendra Singh <pushpendra.singh@oss.qualcomm.com>

Changes in v4:
- Rework the commit message to clarify why reducing zone1_thres_count
  improves BWMON downscaling responsiveness.
- Clarify the empirical selection of 3 compared with lower and higher
  threshold values.
- Add power and performance measurements comparing zone1_thres_count=16
  and zone1_thres_count=3.
- Link to V3 : https://lore.kernel.org/lkml/14d9e262-c3e6-41b4-a408-3d12185b0d48@oss.qualcomm.com/

Chages in v3:
- Update commit message
- Link to v2: https://lore.kernel.org/lkml/d72182bc-f8d4-4314-b2f1-c9242618eb67@quicinc.com/

Changes in v2:
- Update commit message
- Link to v1: https://lore.kernel.org/lkml/463eb7c8-00fc-4441-91d1-6e48f6b052c8@quicinc.com
---
 drivers/soc/qcom/icc-bwmon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index 1ee9f5ce35cd..4cf1bf30d6d2 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -830,7 +830,7 @@ static const struct icc_bwmon_data msm8998_bwmon_data = {
 static const struct icc_bwmon_data sdm845_cpu_bwmon_data = {
 	.sample_ms = 4,
 	.count_unit_kb = 64,
-	.zone1_thres_count = 16,
+	.zone1_thres_count = 3,
 	.zone3_thres_count = 1,
 	.quirks = BWMON_HAS_GLOBAL_IRQ,
 	.regmap_fields = sdm845_cpu_bwmon_reg_fields,
@@ -849,7 +849,7 @@ static const struct icc_bwmon_data sdm845_llcc_bwmon_data = {
 static const struct icc_bwmon_data sc7280_llcc_bwmon_data = {
 	.sample_ms = 4,
 	.count_unit_kb = 64,
-	.zone1_thres_count = 16,
+	.zone1_thres_count = 3,
 	.zone3_thres_count = 1,
 	.quirks = BWMON_NEEDS_FORCE_CLEAR,
 	.regmap_fields = sdm845_llcc_bwmon_reg_fields,
-- 
2.34.1


             reply	other threads:[~2026-11-19 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:44 Pushpendra Singh [this message]
2026-11-19 12:07 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119114426.4050161-1-pushpendra.singh@oss.qualcomm.com \
    --to=pushpendra.singh@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®