mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: joseph@telaak.dev
Cc: "Pavel Machek" <pavel@kernel.org>,
	"Griffin Kroah-Hartman" <griffin@kroah.com>,
	"Kees Cook" <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 07/11] leds: rgb: ktd202x: Add Etek ET6326 support
Date: Thu, 19 Nov 2026 12:33:24 +0000	[thread overview]
Message-ID: <20261119123324.GQ98456@joneslee-macbookpro.roam.internal> (raw)
In-Reply-To: <20261109-ktd202x-et6326-v2-7-56e97c226658@telaak.dev>

On Mon, 09 Nov 2026, Joseph Telaak via B4 Relay wrote:

Please review, explain or fix the Sashiko review(s).
If this is a set, this request includes the other patches too.

> From: Joseph Telaak <joseph@telaak.dev>
> 
> The Etek ET6326 is a KTD2026 with a different flash period encoding:
> Reg1 = n selects (n + 1) * 128 ms, from 128 ms to 16.38 s, where the
> KTD202x selects 256 ms + n * 128 ms and uses Reg1 = 127 for one shot
> mode.
> 
> Move the number of LEDs and the flash period limits into per chip data
> and add the ET6326, so the timer trigger gets the delays it asked for.
> 
> Report the on time rounded to the nearest millisecond rather than down.
> The shortest ET6326 period is 128 ms, and 1/256 of it rounded down is
> 0 ms, which the timer trigger passes back with the next delay_off
> write, where an on time of 0 turns the LED off. Rounded, the delays
> read back also give the same on time when they are written again.
> 
> Link: https://www.etekmicro.com/wp-content/uploads/datasheets/ET6326_datasheet.pdf
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>
> ---
>  drivers/leds/rgb/Kconfig        |  3 +-
>  drivers/leds/rgb/leds-ktd202x.c | 72 ++++++++++++++++++++++++++++++++---------
>  2 files changed, 58 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 6e9ab5f60714..3a57e5819eeb 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -20,7 +20,8 @@ config LEDS_KTD202X
>  	select REGMAP_I2C
>  	help
>  	  This option enables support for the Kinetic KTD2026/KTD2027
> -	  RGB/White LED driver found in different BQ mobile phones.
> +	  RGB/White LED driver found in different BQ mobile phones, and
> +	  for the compatible Etek ET6326.
>  	  It is a 3 or 4 channel LED driver programmed via an I2C interface.
>  
>  	  To compile this driver as a module, choose M here: the module
> diff --git a/drivers/leds/rgb/leds-ktd202x.c b/drivers/leds/rgb/leds-ktd202x.c
> index 042de16c28bc..2650573b6c5a 100644
> --- a/drivers/leds/rgb/leds-ktd202x.c
> +++ b/drivers/leds/rgb/leds-ktd202x.c
> @@ -5,6 +5,7 @@
>   * Copyright 2023 André Apitzsch <git@apitzsch.eu>
>   *
>   * Datasheet: https://www.kinet-ic.com/uploads/KTD2026-7-04h.pdf
> + * Datasheet: https://www.etekmicro.com/wp-content/uploads/datasheets/ET6326_datasheet.pdf

Please avoid adding external URLs to source file headers, as they tend to
bit-rot.

>   */
>  
>  #include <linux/i2c.h>
> @@ -65,9 +66,7 @@
>  /* Register 6-9 */
>  #define KTD202X_LED_CURRENT_10_mA		0x4f
>  
> -#define KTD202X_FLASH_PERIOD_MIN_MS 256
>  #define KTD202X_FLASH_PERIOD_STEP_MS 128
> -#define KTD202X_FLASH_PERIOD_MAX_STEPS 126
>  #define KTD202X_FLASH_ON_MAX 256
>  
>  #define KTD202X_MAX_BRIGHTNESS 192
> @@ -86,6 +85,33 @@ static const struct reg_default ktd202x_reg_defaults[] = {
>  	{ KTD202X_REG_LED_IOUT(3), KTD202X_LED_CURRENT_10_mA },
>  };
>  
> +struct ktd202x_info {
> +	unsigned long num_leds;
> +	/* Flash period encoded by a Reg1 value of 0 */

???

What even is Reg1, and why would a reader worry about it?

> +	unsigned int flash_period_min_ms;
> +	unsigned int flash_period_max_steps;
> +};
> +
> +/* Reg1 = 127 selects one shot mode on the KTD202x */

Why is this useful?

> +static const struct ktd202x_info ktd2026_info = {
> +	.num_leds = KTD2026_NUM_LEDS,
> +	.flash_period_min_ms = 256,
> +	.flash_period_max_steps = 126,
> +};
> +
> +static const struct ktd202x_info ktd2027_info = {
> +	.num_leds = KTD2027_NUM_LEDS,
> +	.flash_period_min_ms = 256,
> +	.flash_period_max_steps = 126,
> +};
> +
> +/* The ET6326 flash period is (Reg1 + 1) * 128 ms, up to 16.38 s */

If this struct needs this additional information, perhaps it's not
self-describing enough - just a thought?

> +static const struct ktd202x_info et6326_info = {
> +	.num_leds = KTD2026_NUM_LEDS,
> +	.flash_period_min_ms = 128,
> +	.flash_period_max_steps = 127,
> +};
> +
>  struct ktd202x_led {
>  	struct ktd202x *chip;
>  	union {
> @@ -100,6 +126,7 @@ struct ktd202x {
>  	struct regulator_bulk_data regulators[2];
>  	struct device *dev;
>  	struct regmap *regmap;
> +	const struct ktd202x_info *info;

'info' overly generic and could mean anything.  What about 'chip_data' or 'caps'?

Also, do we need num_leds twice?

>  	bool enabled;
>  	unsigned long num_leds;
>  	struct ktd202x_led leds[] __counted_by(num_leds);
> @@ -271,6 +298,7 @@ static int ktd202x_blink_set(struct ktd202x_led *led, unsigned long *delay_on,
>  			     unsigned long *delay_off, struct mc_subled *subleds,
>  			     unsigned int num_channels)
>  {
> +	const struct ktd202x_info *info = led->chip->info;
>  	unsigned long delay_total_ms;
>  	int ret, num_steps, on;
>  	u8 ctrl_mask = 0;
> @@ -304,11 +332,11 @@ static int ktd202x_blink_set(struct ktd202x_led *led, unsigned long *delay_on,
>  	/* Integer representation of time of flash period */
>  	if (check_add_overflow(*delay_on, *delay_off, &delay_total_ms))
>  		delay_total_ms = ULONG_MAX;
> -	if (delay_total_ms < KTD202X_FLASH_PERIOD_MIN_MS)
> +	if (delay_total_ms < info->flash_period_min_ms)
>  		num_steps = 0;
>  	else
> -		num_steps = min_t(unsigned long, KTD202X_FLASH_PERIOD_MAX_STEPS,
> -				  (delay_total_ms - KTD202X_FLASH_PERIOD_MIN_MS) /
> +		num_steps = min_t(unsigned long, info->flash_period_max_steps,
> +				  (delay_total_ms - info->flash_period_min_ms) /
>  				  KTD202X_FLASH_PERIOD_STEP_MS);
>  
>  	/*
> @@ -319,8 +347,14 @@ static int ktd202x_blink_set(struct ktd202x_led *led, unsigned long *delay_on,
>  	on = clamp(on, 1, KTD202X_FLASH_ON_MAX - 1);
>  
>  	/* Actually used delay_{on,off} values */
> -	delay_total_ms = num_steps * KTD202X_FLASH_PERIOD_STEP_MS + KTD202X_FLASH_PERIOD_MIN_MS;
> -	*delay_on = (delay_total_ms * on) / KTD202X_FLASH_ON_MAX;
> +	delay_total_ms = num_steps * KTD202X_FLASH_PERIOD_STEP_MS + info->flash_period_min_ms;
> +	/*
> +	 * Rounded to the nearest ms, so that the delays give the same on time
> +	 * when written back. Rounded down, 1/256 of the 128 ms ET6326 period
> +	 * would be 0 ms, which means never on.
> +	 */
> +	*delay_on = clamp(DIV_ROUND_CLOSEST(delay_total_ms * on, KTD202X_FLASH_ON_MAX),
> +			  1UL, delay_total_ms - 1);
>  	*delay_off = delay_total_ms - *delay_on;
>  
>  	/* Set timings */
> @@ -548,8 +582,8 @@ static const struct regmap_config ktd202x_regmap_config = {
>  static int ktd202x_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
> +	const struct ktd202x_info *info;
>  	struct ktd202x *chip;
> -	unsigned long num_leds;
>  	int count;
>  	int ret;
>  
> @@ -557,13 +591,17 @@ static int ktd202x_probe(struct i2c_client *client)
>  	if (!count || count > KTD202X_MAX_LEDS)
>  		return dev_err_probe(dev, -EINVAL, "Incorrect number of leds (%d)", count);
>  
> +	info = i2c_get_match_data(client);
> +	if (!info)
> +		return -ENODEV;
> +
>  	/* Loops over the LEDs go up to the number of channels, not of child nodes */
> -	num_leds = (unsigned long)i2c_get_match_data(client);
> -	chip = devm_kzalloc(dev, struct_size(chip, leds, num_leds), GFP_KERNEL);
> +	chip = devm_kzalloc(dev, struct_size(chip, leds, info->num_leds), GFP_KERNEL);
>  	if (!chip)
>  		return -ENOMEM;
>  
> -	chip->num_leds = num_leds;
> +	chip->info = info;
> +	chip->num_leds = info->num_leds;
>  	chip->dev = dev;
>  	i2c_set_clientdata(client, chip);
>  
> @@ -623,15 +661,17 @@ static void ktd202x_shutdown(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id ktd202x_id[] = {
> -	{ .name = "ktd2026", .driver_data = KTD2026_NUM_LEDS },
> -	{ .name = "ktd2027", .driver_data = KTD2027_NUM_LEDS },
> +	{ .name = "et6326", .driver_data = (kernel_ulong_t)&et6326_info },
> +	{ .name = "ktd2026", .driver_data = (kernel_ulong_t)&ktd2026_info },
> +	{ .name = "ktd2027", .driver_data = (kernel_ulong_t)&ktd2027_info },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, ktd202x_id);
>  
>  static const struct of_device_id ktd202x_match_table[] = {
> -	{ .compatible = "kinetic,ktd2026", .data = (void *)KTD2026_NUM_LEDS },
> -	{ .compatible = "kinetic,ktd2027", .data = (void *)KTD2027_NUM_LEDS },
> +	{ .compatible = "etekmicro,et6326", .data = &et6326_info },
> +	{ .compatible = "kinetic,ktd2026", .data = &ktd2026_info },
> +	{ .compatible = "kinetic,ktd2027", .data = &ktd2027_info },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, ktd202x_match_table);
> @@ -649,5 +689,5 @@ static struct i2c_driver ktd202x_driver = {
>  module_i2c_driver(ktd202x_driver);
>  
>  MODULE_AUTHOR("André Apitzsch <git@apitzsch.eu>");
> -MODULE_DESCRIPTION("Kinetic KTD2026/7 LED driver");
> +MODULE_DESCRIPTION("Kinetic KTD2026/7 and Etek ET6326 LED driver");
>  MODULE_LICENSE("GPL");
> 
> -- 
> Git-155)
> 
> 

-- 
Lee Jones

  reply	other threads:[~2026-11-19 12:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 19:03 [PATCH v2 00/11] leds: ktd202x: Add Etek ET6326, hardware breathing and fixes Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 01/11] leds: rgb: ktd202x: Fix the flash period of short blinks on 32 bit Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 02/11] leds: rgb: ktd202x: Fix an out-of-bounds read with unused channels Joseph Telaak via B4 Relay
2026-11-19 10:22   ` Lee Jones
2026-11-09 19:03 ` [PATCH v2 03/11] leds: rgb: ktd202x: Never program an on time of zero Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 04/11] leds: rgb: ktd202x: Fix a division by zero with long blinks Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 05/11] leds: rgb: ktd202x: Keep the unlit colors of a blinking LED off Joseph Telaak via B4 Relay
2026-11-19 10:37   ` Lee Jones
2026-11-09 19:03 ` [PATCH v2 06/11] dt-bindings: leds: kinetic,ktd202x: Add Etek ET6326 Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 07/11] leds: rgb: ktd202x: Add Etek ET6326 support Joseph Telaak via B4 Relay
2026-11-19 12:33   ` Lee Jones [this message]
2026-11-09 19:03 ` [PATCH v2 08/11] leds: rgb: ktd202x: Add hardware pattern support Joseph Telaak via B4 Relay
2026-11-19 10:20   ` Lee Jones
2026-11-09 19:03 ` [PATCH v2 09/11] leds: rgb: ktd202x: Limit the LED current to led-max-microamp Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 10/11] leds: rgb: ktd202x: Fail the probe when the chip does not answer Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 11/11] leds: rgb: ktd202x: Don't let a blinking LED retime another one Joseph Telaak via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119123324.GQ98456@joneslee-macbookpro.roam.internal \
    --to=lee@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=git@apitzsch.eu \
    --cc=griffin@kroah.com \
    --cc=gustavoars@kernel.org \
    --cc=joseph@telaak.dev \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®