mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cunyuan Liu <cunyuan.liu@cixtech.com>
To: boris.brezillon@collabora.com, steven.price@arm.com,
	liviu.dudau@arm.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, gary.yang@cixtech.com,
	fugang.duan@cixtech.com, daniel.almeida@collabora.com,
	aliceryhl@google.com, p.zabel@pengutronix.de,
	daniel@fooishbar.org
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	cix-kernel-upstream@cixtech.com, robin.wang@cixtech.com,
	cunyuan.liu@cixtech.com
Subject: [PATCH v3 0/7] Add initial GPU support for CIX Sky1
Date: Thu, 19 Nov 2026 20:38:43 +0800	[thread overview]
Message-ID: <20261119123850.2994625-1-cunyuan.liu@cixtech.com> (raw)

This series adds initial support for the Mali GPU on CIX Sky1 and
enables it on the Radxa Orion O6 board.

The GPU requires an external reset before the driver first accesses
the hardware. Add optional reset support to Panthor to perform this reset
during initialization.

This initial version keeps the PM firmware default clock settings and
skips devfreq. It does not read OPPs or request a performance level.
The firmware sets the default GPU frequency to 1 GHz. No devfreq
governor or GPU cooling device is registered.

Without an OPP table, the driver can only run when neither mali-supply
nor sram-supply is present and the platform provides working clocks and
power.

Configure the system-level cache before L2 power-on using the policies
from the working CIX Sky1 driver. On Sky1, devices on the MMHUB bus
cannot access the system-level cache, so buffers shared between the GPU
and MMHUB devices require a specific system-level cache policy. Without
this configuration, the GPU display output is corrupted.

The system-cache support is a separate patch and reads the policies from
DT. The proposed format is <source-id read-policy write-policy>, so the
DT only lists sources with nonzero policies. When the property is absent,
the driver leaves the registers unchanged. The format and zero-default
semantics are included for review.

The series contains seven patches:
[1/7] drm/panthor: Add optional external reset support
[2/7] drm/panthor: Allow operation without an OPP table
[3/7] dt-bindings: gpu: arm,mali-valhall-csf: Add system-cache policies
[4/7] drm/panthor: Add system-cache allocation policy support
[5/7] dt-bindings: gpu: Add CIX Sky1 Mali support
[6/7] drm/panthor: Add CIX Sky1 compatible
[7/7] arm64: dts: cix: Add GPU support for Sky1 Orion O6

Tested on Radxa Orion O6:
  - Offscreen rendering with pixel readback
  - kmscube
  - glmark2 at 1080p
  - Runtime suspend and resume with a retained EGL context
  - Reset-worker operations
  - Module unload and reload


Changes in v3:
  - Split optional reset, no-OPP operation and system-cache support into
    separate patches, as suggested by Liviu Dudau.
  - Remove the Sky1-specific skip_devfreq flag. Use the generic no-OPP
    path.
    Limit this fallback to configurations without GPU supply properties,
    retaining probe failure for supplies without an OPP table.
  - Move system-cache policies to DT and use separate read/write values,
    as suggested by Liviu Dudau and Daniel Stone. Add explicit source IDs
    so that unused entries can be omitted.
  - Validate the architecture, source IDs and policies. Restore the
    configuration through the common L2 power-on entry.
  - Drop Conor Dooley's Acked-by because the Sky1 binding now requires
    the new arm,sysc-alloc property. Please review the updated binding.

Changes in v2:
  - Use devm_reset_control_get_optional_exclusive() unconditionally,
    remove the redundant NULL check before reset_control_reset(), and
    drop needs_external_reset, as suggested by Philipp Zabel.
  - Add Conor Dooley's Acked-by to the then-unchanged binding patch.


Link to v2:
https://lore.kernel.org/all/20261109120902.125242-1-cunyuan.liu@cixtech.com/

Link to v1:
https://lore.kernel.org/all/20261106104735.1651267-1-cunyuan.liu@cixtech.com/


Best regards,
Cunyuan

Cunyuan Liu (7):
  drm/panthor: Add optional external reset support
  drm/panthor: Allow operation without an OPP table
  dt-bindings: gpu: arm,mali-valhall-csf: Add system-cache policies
  drm/panthor: Add system-cache allocation policy support
  dt-bindings: gpu: Add CIX Sky1 Mali support
  drm/panthor: Add CIX Sky1 compatible
  arm64: dts: cix: Add GPU support for Sky1 Orion O6

 .../bindings/gpu/arm,mali-valhall-csf.yaml    |  79 ++++++++
 arch/arm64/boot/dts/cix/sky1-orion-o6.dts     |   4 +
 arch/arm64/boot/dts/cix/sky1.dtsi             |  19 ++
 drivers/gpu/drm/panthor/panthor_devfreq.c     |  13 +-
 drivers/gpu/drm/panthor/panthor_device.c      |  13 ++
 drivers/gpu/drm/panthor/panthor_device.h      |   7 +-
 drivers/gpu/drm/panthor/panthor_drv.c         |   1 +
 drivers/gpu/drm/panthor/panthor_gpu.c         | 187 ++++++++++++++++++
 drivers/gpu/drm/panthor/panthor_gpu.h         |   1 +
 drivers/gpu/drm/panthor/panthor_gpu_regs.h    |  58 ++++++
 drivers/gpu/drm/panthor/panthor_hw.c          |  13 ++
 drivers/gpu/drm/panthor/panthor_hw.h          |   5 +-
 12 files changed, 394 insertions(+), 6 deletions(-)


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
-- 
2.53.0


             reply	other threads:[~2026-11-19 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 12:38 Cunyuan Liu [this message]
2026-11-19 12:38 ` [PATCH v3 1/7] drm/panthor: Add optional external reset support Cunyuan Liu
2026-11-19 12:38 ` [PATCH v3 2/7] drm/panthor: Allow operation without an OPP table Cunyuan Liu
2026-11-19 12:38 ` [PATCH v3 3/7] dt-bindings: gpu: arm,mali-valhall-csf: Add system-cache policies Cunyuan Liu
2026-11-22 16:58   ` Krzysztof Kozlowski
2026-11-19 12:38 ` [PATCH v3 4/7] drm/panthor: Add system-cache allocation policy support Cunyuan Liu
2026-11-19 12:38 ` [PATCH v3 5/7] dt-bindings: gpu: Add CIX Sky1 Mali support Cunyuan Liu
2026-11-22 17:01   ` Krzysztof Kozlowski
2026-11-19 12:38 ` [PATCH v3 6/7] drm/panthor: Add CIX Sky1 compatible Cunyuan Liu
2026-11-19 12:38 ` [PATCH v3 7/7] arm64: dts: cix: Add GPU support for Sky1 Orion O6 Cunyuan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119123850.2994625-1-cunyuan.liu@cixtech.com \
    --to=cunyuan.liu@cixtech.com \
    --cc=aliceryhl@google.com \
    --cc=boris.brezillon@collabora.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=daniel@fooishbar.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fugang.duan@cixtech.com \
    --cc=gary.yang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=robin.wang@cixtech.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=steven.price@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®