mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: pavel@kernel.org, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] leds: class: Split led_classdev_register_ext()
Date: Thu, 19 Nov 2026 15:09:20 +0000	[thread overview]
Message-ID: <20261119150920.GU98456@joneslee-macbookpro.roam.internal> (raw)
In-Reply-To: <983f521e-0e83-4600-b59b-08675a8d0d70@gmx.de>

--- checkpatch.pl (3 issues) ---
Line 4: WARNING: 'seperate' may be misspelled - perhaps 'separate'?
Line 55: ERROR: open brace '{' following function definitions go on the next line
Line 79: ERROR: that open brace { should be on the previous line
----------------------------------

On Tue, 10 Nov 2026, Armin Wolf wrote:

> Am 18.10.26 um 15:46 schrieb Armin Wolf:
> > Split led_classdev_register_ext() into two seperate internal functions

Typo: 'seperate' should be 'separate'.

> > to prepare for future changes around LED class device initialization.
> > 
> > Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> > ---
> >   drivers/leds/led-class.c | 105 +++++++++++++++++++++++++++++++--------
> >   drivers/leds/leds.h      |   3 ++
> >   2 files changed, 88 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> > index 77a0fce03952..ace417a2388e 100644
> > --- a/drivers/leds/led-class.c
> > +++ b/drivers/leds/led-class.c
> > @@ -228,9 +228,15 @@ static struct led_classdev *led_module_get(struct device *led_dev)
> >   	return led_cdev;
> >   }
> > +static void led_classdev_release(struct device *dev)
> > +{
> > +	kfree(dev);
> > +}
> > +
> >   static const struct class leds_class = {
> >   	.name = "leds",
> >   	.dev_groups = led_groups,
> > +	.dev_release = led_classdev_release,
> >   	.pm = &leds_class_dev_pm_ops,
> >   };
> > @@ -465,16 +471,21 @@ static int led_classdev_next_name(const char *init_name, char *name,
> >   }
> >   /**
> > - * led_classdev_register_ext - register a new object of led_classdev class
> > - *			       with init data.
> > - *
> > - * @parent: parent of LED device
> > + * led_classdev_init - Initialize a new LED class device.
> > + * @parent: parent of LED device.
> >    * @led_cdev: the led_classdev structure for this device.
> > - * @init_data: LED class device initialization data
> > + * @init_data: LED class device initialization data.
> > + *
> > + * Initializes a new LED class device, but does not register with the
> > + * subsystem yet. Useful for performing additional initialization before
> > + * adding the LED class device to the subsystem using led_classdev_add().
> > + * After calling this function put_device() needs to be called on the dev
> > + * field inside the LED class device in order to dispose it.
> > + *
> > + * Return: Zero on success or a negative error code on failure.
> >    */
> > -int led_classdev_register_ext(struct device *parent,
> > -			      struct led_classdev *led_cdev,
> > -			      struct led_init_data *init_data)
> > +int led_classdev_init(struct device *parent, struct led_classdev *led_cdev,
> > +		      struct led_init_data *init_data)
> >   {
> >   	char composed_name[LED_MAX_NAME_SIZE];
> >   	char final_name[LED_MAX_NAME_SIZE];
> > @@ -539,23 +550,54 @@ int led_classdev_register_ext(struct device *parent,
> >   	if (!led_cdev->max_brightness)
> >   		led_cdev->max_brightness = LED_FULL;
> > -	mutex_lock(&led_cdev->led_access);
> > -	led_cdev->dev = device_create_with_groups(&leds_class, parent, 0, led_cdev,
> > -						  led_cdev->groups, "%s", final_name);
> > -	if (IS_ERR(led_cdev->dev)) {
> > -		mutex_unlock(&led_cdev->led_access);
> > -		return PTR_ERR(led_cdev->dev);
> > +	led_cdev->dev = kzalloc_obj(*led_cdev->dev);
> > +	if (!led_cdev->dev)
> > +		return -ENOMEM;
> > +
> > +	device_initialize(led_cdev->dev);
> > +	led_cdev->dev->class = &leds_class;
> > +	led_cdev->dev->parent = parent;
> > +	led_cdev->dev->groups = led_cdev->groups;
> > +	dev_set_drvdata(led_cdev->dev, led_cdev);
> > +	ret = kobject_set_name(&led_cdev->dev->kobj, "%s", final_name);
> > +	if (ret < 0)

Please use if (ret) to check for errors, not if (ret < 0), as positive return
values do not have a specific meaning here.

> > +	{

The open brace '{' following an 'if' statement should be on the previous line.

> > +		put_device(led_cdev->dev);
> > +		return ret;
> >   	}
> >   	if (init_data && init_data->fwnode)
> >   		device_set_node(led_cdev->dev, init_data->fwnode);
> 
> Sashiko has the following complain about this:
> 
> Because led_cdev->dev is a class device that never binds to a driver:
> 
> 1. __fw_devlink_link_to_consumers(led_cdev->dev) converts consumer
> fwnode_links
>     on init_data->fwnode into managed device links with
> led_cdev->dev as the
>     supplier instead of the parent LED controller. During boot (while
>     fw_devlink_drv_reg_done is false), consumers remain blocked with
>     -EPROBE_DEFER until fw_devlink_drivers_done() runs, and are
> never linked to
>     the parent controller for runtime PM, suspend/resume, or unbind
> ordering.
> 
> 2. __fw_devlink_link_to_suppliers(led_cdev->dev, fwnode) creates
> managed device
>     links with led_cdev->dev as the consumer for any supplier
> properties on the
>     child LED node (such as gpios in gpio-leds or pwms in pwm-leds).
> Since
>     led_cdev->dev never probes a driver, those links stay in
> DL_STATE_AVAILABLE
>     and prevent the GPIO or PWM suppliers from reaching sync_state().
> 
> I have no experience with devicetree, so i cannot verify if this is
> true, why do we call device_set_node() in the first place after having
> already registered the device?

As requested:

  Sashiko is spot on here.
  
  Previously, led_classdev_register_ext() used device_create_with_groups(), which
  calls device_add() internally before returning.  Because of that,
  device_set_node() was only ever called *after* device_add() had already run with
  a NULL 'fwnode', meaning fw_devlink_link_device() was completely bypassed.
  
  The fwnode still needs to be attached to 'led_cdev->dev' so that in-kernel LED
  consumers (such as of_led_get() / fwnode_led_get() via
  class_find_device_by_fwnode()) can look up the LED class device by its DT/fwnode
  handle, and so the 'of_node' sysfs symlink can be populated.
  
  However, moving device_set_node() before device_add() causes device_add() ->
  fw_devlink_link_device() to see a non-NULL 'fwnode' on a class device that has
  no 'bus' and never binds to a driver:
  
  1. 'init_data->fwnode->dev' gets set to 'led_cdev->dev' before registration,
  hijacking consumer fwnode links away from the parent controller device (which
  actually probes a driver) onto the driverless class device.  2. Any supplier
  properties on the child LED node (like 'gpios' or 'pwms') get linked with
  'led_cdev->dev' as the consumer, leaving those device links stuck in
  'DL_STATE_AVAILABLE' forever and blocking suppliers' sync_state() callbacks.
  
  Notice also that setting the node after device_add() was the reason
  'drivers/leds/led-class.c' historically never got the automatic 'of_node' sysfs
  link created during device_add() unless handled carefully, and why 'fwnode->dev'
  remained NULL (as device_add() is what assigns 'dev->fwnode->dev = dev' when
  'fwnode->dev' is not yet set!).
  
  To preserve the existing behaviour and avoid breaking fw_devlink(), keep the
  device_set_node() call in led_classdev_add() *after* device_add() (or pass
  'fwnode' into led_classdev_add()), rather than calling it in
  led_classdev_init().



-- 
Lee Jones

  reply	other threads:[~2026-11-19 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 13:46 [PATCH 00/10] leds: class: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-10-18 13:46 ` [PATCH 01/10] leds: class: Constify sysfs attributes Armin Wolf
2026-10-18 13:46 ` [PATCH 02/10] leds: multicolor: " Armin Wolf
2026-10-18 13:46 ` [PATCH 03/10] leds: flash: " Armin Wolf
2026-10-18 13:46 ` [PATCH 04/10] leds: class: Create "brightness_hw_changed" attribute atomically Armin Wolf
2026-10-19 11:51   ` Rong Zhang
2026-10-20 20:55     ` Armin Wolf
2026-10-18 13:46 ` [PATCH 05/10] leds: class: Fix race condition when creating the device Armin Wolf
2026-10-18 13:46 ` [PATCH 06/10] leds: class: Take the LED access lock when reading brightness_hw_changed Armin Wolf
2026-10-18 13:46 ` [PATCH 07/10] leds: class: Use correct type for brightness_hw_changed field Armin Wolf
2026-10-18 13:46 ` [PATCH 08/10] leds: class: Split led_classdev_register_ext() Armin Wolf
2026-11-10 15:32   ` Armin Wolf
2026-11-19 15:09     ` Lee Jones [this message]
2026-10-18 13:46 ` [PATCH 09/10] leds: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-10-19 11:53   ` Rong Zhang
2026-10-20 20:57     ` Armin Wolf
2026-10-18 13:46 ` [PATCH 10/10] leds: multicolor: Adjust maximum subled intensity during initialization Armin Wolf
2026-10-19 11:54   ` Rong Zhang
2026-10-20 20:59     ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119150920.GU98456@joneslee-macbookpro.roam.internal \
    --to=lee@kernel.org \
    --cc=W_Armin@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®