From: Joshua Machauer <machaujo@amazon.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <nh-open-source@amazon.com>
Subject: [PATCH] PCI: Skip the CXL state update for a VF
Date: Thu, 19 Nov 2026 16:42:19 +0000 [thread overview]
Message-ID: <20261119164219.51540-1-machaujo@amazon.de> (raw)
set_pcie_cxl() runs for every device that is added. It first updates
the CXL state of the upstream bridge, which walks that bridge's
extended capabilities and recurses up to the root port. It then walks
the device's own extended capabilities for the Flex Bus Port DVSEC.
For a VF neither walk can change anything. A CXL device exposes its
Flex Bus Port DVSEC through Function 0 (CXL 4.0, section 8.1.8), so
the search in a VF finds nothing and the VF's is_cxl stays false.
pci_upstream_bridge() resolves a VF through its PF, so the bridge is
the one that was already updated when the PF was added.
Enabling SR-IOV adds the VFs one after another, and each add repeats
both walks against the same bridges.
On an NVIDIA Vera system, enabling 256 VFs on a PF whose upstream
bridge has 18 extended capabilities takes 296 ms instead of 402 ms.
Enabling 32 VFs on a Rubin GPU takes 218 ms instead of 235 ms. The
times are for the write to sriov_numvfs, with the PF bound to
pci-pf-stub and VF driver autoprobe disabled, so no VF driver probes.
Return early for a VF. Every device keeps the is_cxl value it gets
today.
Signed-off-by: Joshua Machauer <machaujo@amazon.de>
---
drivers/pci/probe.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 9a178e0e5f7f..34acebd1c706 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1717,6 +1717,14 @@ static void set_pcie_cxl(struct pci_dev *dev)
if (!pci_is_pcie(dev))
return;
+ /*
+ * A CXL device exposes its Flex Bus Port DVSEC through Function 0,
+ * so a VF has none. Its upstream bridge is the PF's, which was
+ * updated when the PF was added.
+ */
+ if (dev->is_virtfn)
+ return;
+
/*
* Update parent's CXL state because alternate protocol training
* may have changed
--
2.47.3
next reply other threads:[~2026-11-19 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 16:42 Joshua Machauer [this message]
2026-11-19 16:50 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119164219.51540-1-machaujo@amazon.de \
--to=machaujo@amazon.de \
--cc=bhelgaas@google.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nh-open-source@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®