From: Ian Rogers <irogers@google.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Elkin Cruz <elkin@google.com>,
Ian Rogers <irogers@google.com>
Subject: [PATCH] remoteproc: core: Format firmware carveout rsc->name with %.*s
Date: Thu, 19 Nov 2026 09:05:05 -0800 [thread overview]
Message-ID: <20261119170505.1515029-1-irogers@google.com> (raw)
In rproc_handle_carveout(), rsc->name is a 32-byte u8 array inside the
firmware resource table. It is passed directly as the printf format string
to both rproc_find_carveout_by_name() and rproc_mem_entry_init() (which
call vsnprintf() with zero varargs), and printed via "%s" in dev_dbg()
without verifying NUL termination within sizeof(rsc->name). A malformed or
corrupt firmware resource table containing '%' specifiers or lacking a NUL
byte in rsc->name can trigger out-of-bounds reads or invalid vararg stack
accesses.
Pass "%.*s" bounded by (int)sizeof(rsc->name) at all three sites in
rproc_handle_carveout().
Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
-Wformat-security enabled; fix and changelog drafted with an AI coding
assistant. Verified with an ASan/UBSan C test and build-tested under
LLVM=1 W=1 and -Wformat-security; not runtime-tested with remoteproc
firmware images.
Fixes: 72029c901a02 ("remoteproc: add helper function to allocate and init rproc_mem_entry struct")
Fixes: ffa5f9c84810 ("remoteproc: modify rproc_handle_carveout to support pre-registered region")
Signed-off-by: Ian Rogers <irogers@google.com>
---
drivers/remoteproc/remoteproc_core.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 23f8539a99bd..1b1743093edc 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -837,14 +837,17 @@ static int rproc_handle_carveout(struct rproc *rproc,
return -EINVAL;
}
- dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n",
- rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags);
+ dev_dbg(dev, "carveout rsc: name: %.*s, da 0x%x, pa 0x%x, len 0x%x, flags 0x%x\n",
+ (int)sizeof(rsc->name), rsc->name, rsc->da, rsc->pa, rsc->len,
+ rsc->flags);
/*
* Check carveout rsc already part of a registered carveout,
* Search by name, then check the da and length
*/
- carveout = rproc_find_carveout_by_name(rproc, rsc->name);
+ carveout = rproc_find_carveout_by_name(rproc, "%.*s",
+ (int)sizeof(rsc->name),
+ rsc->name);
if (carveout) {
if (carveout->rsc_offset != FW_RSC_ADDR_ANY) {
@@ -866,7 +869,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
/* Register carveout in list */
carveout = rproc_mem_entry_init(dev, NULL, 0, rsc->len, rsc->da,
rproc_alloc_carveout,
- rproc_release_carveout, rsc->name);
+ rproc_release_carveout, "%.*s",
+ (int)sizeof(rsc->name), rsc->name);
if (!carveout) {
dev_err(dev, "Can't allocate memory entry structure\n");
return -ENOMEM;
--
2.56.1.708.g77570a6a1d-goog
reply other threads:[~2026-11-19 17:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119170505.1515029-1-irogers@google.com \
--to=irogers@google.com \
--cc=andersson@kernel.org \
--cc=elkin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®