From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795107916; b=Pfjf/fsR9AKnFVs4p62EB3kQFm7DQ1uxaLZQB+7rsOeu5NPzRdJxCaW7H6JzSs+e7bGX 6Nrbwyz8lQqT+PZIL4o+r6vpZMgr3z/Kf67rXiBcVyVISHpL8pnQYbNZ/ovkUGS9igNUn 7uwszISaGEnRbL1PuPhRTQF2sfEa9E5sTl5NWmlrHb3ydknsC59lKwy0lYn1dcDWXjAnP bNw3aejHh0d4dUx2t8MkdgsQ37ZGqvZB367hm0kq82kcpVJc37BCwFGc6TXYbxUvnJeI1 7qPfJYS82faSeqmO+H6fdNrcJMkopsYy7+JbAK73BsBbhV3MNKAJvUbVRB7wqHDfBLQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795107916; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:Mime-Version: X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=sqmCZzPodY7a2eZN9hiYKdyxOr9vBaN6CDvJ9v3zNlA=; b=ntwN2x78nV/Bs6y0N93hry9JITHHFNEX+l266Qs5YnDgRzU/vDc8IgETZnMgjHX7dWjZ hXQwVVuhBmV2B6P2OjkCSaiH4CJ4jxY/5UZ/BPaGhwwAe5nI1iqGibvcWhXDnPv8oo6ez M/kH1PGcYKWbzlcoqR4XaMTAQA+Nu5983bKaDiebcj8pe4i4EjzE5CeSQ0yMLMnid3gOK 54aFCnWPez3gEQ2YIzIQ832HbQjNnw6x8wWfNjr8Rgs7eKsFTGQMYZW8S9vvUJG1Od09t t0xo6Icmp/bTacitDiTQb8yjuasqPZlDNnsFblzUcfc8uIVdwHGyH+7w/pBeKmWDeeA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=E5RmdONf; arc=none smtp.remote-ip=74.125.82.198 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCD8C606A32A for ; Thu, 19 Nov 2026 17:05:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DCD8C606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=E5RmdONf Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3846d5f54c1so1026455eec.1 for ; Thu, 19 Nov 2026 09:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795107915; x=1795712715; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sqmCZzPodY7a2eZN9hiYKdyxOr9vBaN6CDvJ9v3zNlA=; b=E5RmdONfYCJ299MPD3h2XC5pKfYyvH4ECAiLFxs2sQmHLP2dYrNORApVOAxHh5Y4/x w3ujwifVrtK3n+RsFDDcB0aTfaeY+WCYyttnfKGHavWgVRg3/EIF0QG8c7Hv6BkHTHjN VX7Z8ZG7G2Lf/rIDY95TQmYb4emV2pDkKTI3eCzQxPOzvarwOKuRQUl3u/N8nDeFDR2N kbecQvLqDLBMvbXSCpe9oCARgyfeoP5uJ8Eqbxct4aqLY1gYYpAvN9F3YRWWayP6sgzn 1IG3XAFzfo4BdZfWLgEhC/5Bjht6QhuHqsF5xax/HaymN+YG4FJMY4ISIXrZUnVk1cgB p6Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795107915; x=1795712715; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sqmCZzPodY7a2eZN9hiYKdyxOr9vBaN6CDvJ9v3zNlA=; b=qsZs+lXMiV0Et3Y3364a62Ka0jF/a7CvkJMlUpKroxaaEvukfsjwSBvOOwFOQml4qZ yc9fLkUi2V+DNp9zvE0yeM6iL3nC3h2GFm6T8gSQbFY+SJ63Ty8JYH+jHROjKiBzZGN3 tiiMD1dIhOrUhsOWwcWyUY1s+CIFOyuhQC4WIghWWue1aIIvNBj5xh+4J58+DCpfQ8LU F0N+QAQAEfgl8guVgi+80yRKOphp8rQyfxI24lnlFBwmQlO/I/bjTc27QPYtdZ8XDQIt a388Wo1DTW5K8e5+ZEbvgWwBpx82B/q9tPRx5b10NJNxccT9k3GDRiTyd3z8ewWMOulD p/sw== X-Forwarded-Encrypted: i=1; AL+hErHCS31NQ9Sces736aYJNprW5pn/vKV1+SUJCo93k1eCbU2iXAwbmEEmMhpKGiLTexJb72akrnrqVysvd/8=@vger.kernel.org X-Gm-Message-State: APuU4Z+ZrihiHvsclsoOzH+q24iw4P4uNgZK4hA6fJsygT+/bGLVVn7q rYqjVm+TNxK+Pu/BYJwg277GJnixwvuQ8O1b1PDoUrPN5NtvKPyZn88AE6cw+NT21xOaF03w6hD iLvhwBOzjfg== X-Received: from dybsl7.prod.google.com ([2002:a05:7301:7307:b0:359:a8c8:38e2]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:791:b0:384:e31e:3c39 with SMTP id 5a478bee46e88-384e31e4317mr1074891eec.37.1795107914692; Thu, 19 Nov 2026 09:05:14 -0800 (PST) Date: Thu, 19 Nov 2026 09:05:11 -0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 X-Mailer: git-send-email 2.56.1.708.g77570a6a1d-goog Message-ID: <20261119170511.1515433-1-irogers@google.com> Subject: [PATCH] scsi: qla2xxx: Format SFP EEPROM vendor strings with %.*s From: Ian Rogers To: Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Elkin Cruz , Ian Rogers Content-Type: text/plain; charset="UTF-8" In qla2xxx_print_sfp_info(), the verbose logging path passes the 16-byte SFF-8472 transceiver EEPROM fields a0->vendor_name and a0->vendor_pn directly as the format string argument to snprintf(). Per SFF-8472, these ASCII fields are space-padded rather than NUL-terminated, and their bytes originate from pluggable SFP optics over I2C; any '%' byte in EEPROM data or a corrupted I2C read is interpreted as a printf format specifier with no variadic arguments supplied. Format a0->vendor_name and a0->vendor_pn directly in ql_dbg() using "%.*s" bounded by sizeof(), matching the non-verbose ql_dbg() call immediately above in the same function. Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with -Wformat-security enabled; fix and changelog drafted with an AI coding assistant. Build-tested under LLVM=1 W=1 and -Wformat-security; not tested on QLogic Fibre Channel hardware. Fixes: e4e3a2ce9556 ("scsi: qla2xxx: Add ability to autodetect SFP type") Signed-off-by: Ian Rogers --- drivers/scsi/qla2xxx/qla_init.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index ccb039d97353..77504cfc0741 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -4126,15 +4126,13 @@ static void qla2xxx_print_sfp_info(struct scsi_qla_host *vha) if (!(ql2xextended_error_logging & ql_dbg_verbose)) return; - memset(str, 0, STR_LEN); - snprintf(str, SFF_VEN_NAME_LEN+1, a0->vendor_name); ql_dbg(ql_dbg_init, vha, 0x015a, - "SFP MFG Name: %s\n", str); + "SFP MFG Name: %.*s\n", + (int)sizeof(a0->vendor_name), a0->vendor_name); - memset(str, 0, STR_LEN); - snprintf(str, SFF_PART_NAME_LEN+1, a0->vendor_pn); ql_dbg(ql_dbg_init, vha, 0x015c, - "SFP Part Name: %s\n", str); + "SFP Part Name: %.*s\n", + (int)sizeof(a0->vendor_pn), a0->vendor_pn); /* media */ memset(str, 0, STR_LEN); -- 2.56.1.708.g77570a6a1d-goog