From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795108225; b=LfgzsHb9APZVHcGIQ/Lck7ZDxIiRmVefof9KKTVix5zvGot6k4lLO7wCzM+OjHRPzkjQ WjZH1nRLnlP/GaRD4kPqph/c/8AxSrBxre8H+0Hwox8KvWNRVuRWB+mk8Qz8jT1rZON1H 8IxNhpilJBmxQPDQZzcMQt7C0ljIATpaFXIvog9SDPL0W3v7DiJv3ooiUilEeFzvV7kzy M5BtYGqbC9hYJ3bbyjf4istHZPTpWXCr+pmOsiesDgdcIq9qQVyL94UGaDf0HmWLhkBu3 BpeFkd+VQqWiMqTwnLA6xugPrdYtMCpy/+vJCnYrsf8mY5X3KaIjq9CYuCsUOsSz92w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795108225; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:Mime-Version: X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=B7nlDoGtQsbCYF5zM2CHlDtWyCwjewwKLZSkkjg+Gqk=; b=IIPbVMXBv4LiHgCV3QZX6E862DCJK3D/+FG2VvDl8H0ohgdF2AKPNdRq0obCH/goWEyw X9L21l73AVl4Mbuz44fHgfJxFS25DrHud3xlY5etZhHDT9lGpww+XSstTftghYKXTgqmv HxBwuxRV9iKiMx65HQB8+ldqwoSKPu1FX1/vCbFUa9nn32OP7rsn2/Gyg5wC9OhvHEbvS nYdJj24DBcICNEMx8G5lt71NI228iLzPvhgGmQJ81hxaFGRdTcL6mzdXByyWcpV/AVuyM c3JLfBxyt69o4NKSPni50/EI3w5H2NTXH8t5T1Dtj+0xdnJJc3sv+gAXM3s5f0LkUWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=iNorJu68; arc=none smtp.remote-ip=209.85.214.198 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D2760A3832 for ; Thu, 19 Nov 2026 17:10:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 43D2760A3832 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=iNorJu68 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2efa9aea3c0so30769845ad.1 for ; Thu, 19 Nov 2026 09:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795108225; x=1795713025; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B7nlDoGtQsbCYF5zM2CHlDtWyCwjewwKLZSkkjg+Gqk=; b=iNorJu68GrFwSRJtcwkfCon1uAi2P0UIqg1t35ZXFHCo/+q/KJH6+pyKCB6+7iHE7u eY+gvfCI6eWuDNdPoWjWjAr6dTqWCyFPLjH8c90N2tEIc/JN8ImJCd/qHAFsYUZEtxdR WZS6EV/lZbLX1IzHcyepDekL8EGi5WHjaZ5VngMq6S78eYgFKyEau6MoiO/1AsSe7fJh HOw/OU6WBClNL38W9o5uhZ7ilvYwmrKMCfOBwUVAQXKcAebPvqfFxtcS9/GctcrRuVeK Y1UZkCMks00JhGoQcadaEJ9HY6kkw5l349ZDG7V5Perm1oLGtx//69GJoCtXEUm2nv2x TGQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795108225; x=1795713025; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B7nlDoGtQsbCYF5zM2CHlDtWyCwjewwKLZSkkjg+Gqk=; b=WkVYNo4ti4vZu1rCCDhRoAcXgIZqKQriEG7gBRQ3HkMPUDqq7jV6uSGJCTPm1uXNn9 T4tABNlXCfVmpDvjJ82FDwdnXtri8UT11dH5kbfwdUE+SjhDBm0tC2UkYdbA4Brudtuv 0NjHgXM82Gs2/uLeO4U9KwXuaJzd3UM6n9DkTJjTNomxl2hAxTRReiAT0CAaHRjmxF1X uTGOS61RFsbyR7VY+X/5p56HumybyX2+5cc9txq0wI8cUV7KxU7R2grmRqtQr908fgbx jmyjhfwP7gm3OHOpdozAOei/t2g+sqRQ6n35+CYlv2jrPvlGbClHiQlx/9Y3ECht/mMc 8HVA== X-Forwarded-Encrypted: i=1; AL+hErFbcUPL9UU0Ic5V2itNsq6uJJvt3dRHc+6ZqWhppVIknr2IjJ3M+JufmaT/K9nuP9r4hHx8UkvSM/k7FDY=@vger.kernel.org X-Gm-Message-State: APuU4Z/GY+uXddsEfzDc3yfQWgh5VNnN/gS9wyaKnsn1l6aFGQLPnW13 sakKVvrsGvedgaHa0u2cCrA508mbtfUQt6CNmLXxz9KBUwjWFpT+dOOwCArkXA8twkVRKj0RM3W HlBKCHZAFzg== X-Received: from plbkf8.prod.google.com ([2002:a17:903:5c8:b0:2ea:7221:e753]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2b0f:b0:2ef:d981:9576 with SMTP id d9443c01a7336-2f03f181ee6mr4877595ad.54.1795108224402; Thu, 19 Nov 2026 09:10:24 -0800 (PST) Date: Thu, 19 Nov 2026 09:10:21 -0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 X-Mailer: git-send-email 2.56.1.708.g77570a6a1d-goog Message-ID: <20261119171021.1535172-1-irogers@google.com> Subject: [PATCH net] tg3: Propagate PHY reset retry failures in tg3_phy_reset_5703_4_5() From: Ian Rogers To: Pavan Chebbi , Michael Chan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Elkin Cruz , Ian Rogers Content-Type: text/plain; charset="UTF-8" In tg3_phy_reset_5703_4_5(), the 10-iteration retry loop discards the return value of both tg3_readphy() calls on continue and never checks err after the loop terminates. If MDIO reads fail across all 10 retries, phy9_orig is never initialized before being written back to MII_CTRL1000; if tg3_phy_write_and_check_testpat() fails across all 10 retries, the function silently continues as if the PHY test pattern succeeded. Record err on both tg3_readphy() calls and return err if the retry loop finishes with an error. Found via Clang -Wconditional-uninitialized on an x86_64 allyesconfig build. Verified by building drivers/net/ethernet/broadcom/tg3.o with LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized; not runtime-tested on BCM5703/5704/5705 hardware. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ian Rogers --- drivers/net/ethernet/broadcom/tg3.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 95827df4cf6a..be2410e718fd 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -2558,7 +2558,8 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp) } /* Disable transmitter and interrupt. */ - if (tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32)) + err = tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32); + if (err) continue; reg32 |= 0x3000; @@ -2569,7 +2570,8 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp) BMCR_FULLDPLX | BMCR_SPEED1000); /* Set to master mode. */ - if (tg3_readphy(tp, MII_CTRL1000, &phy9_orig)) + err = tg3_readphy(tp, MII_CTRL1000, &phy9_orig); + if (err) continue; tg3_writephy(tp, MII_CTRL1000, @@ -2587,6 +2589,9 @@ static int tg3_phy_reset_5703_4_5(struct tg3 *tp) break; } while (--retries); + if (err) + return err; + err = tg3_phy_reset_chanpat(tp); if (err) return err; -- 2.56.1.708.g77570a6a1d-goog