From: Ian Rogers <irogers@google.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Elkin Cruz <elkin@google.com>,
Ian Rogers <irogers@google.com>
Subject: [PATCH] drm/msm/dp: Return MODE_BAD instead of -EINVAL from mode_valid callbacks
Date: Thu, 19 Nov 2026 09:10:46 -0800 [thread overview]
Message-ID: <20261119171046.1536673-1-irogers@google.com> (raw)
msm_dp_display_mode_valid() and msm_edp_bridge_mode_valid() have
return type enum drm_mode_status, but return -EINVAL (-22) when dp,
dp->connector, or mode->clock is zero/NULL. If a mode with zero pixel
clock is validated and pruned, passing -22 to
drm_get_mode_status_name() computes a negative array index and fires
WARN_ON().
Return MODE_BAD instead of -EINVAL in both callbacks.
Found via Clang -Wassign-enum on an x86_64 allyesconfig build.
Verified by building drivers/gpu/drm/msm/dp/dp_display.o and dp_drm.o
with LLVM=1 W=1 (-Werror) and -Wassign-enum; not runtime-tested on
Qualcomm Snapdragon DP/eDP hardware.
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Fixes: 05d001352733 ("drm/msm/dp: use the eDP bridge ops to validate eDP modes")
Signed-off-by: Ian Rogers <irogers@google.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
drivers/gpu/drm/msm/dp/dp_drm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index c0c150e2c575..51649b584573 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -759,7 +759,7 @@ enum drm_mode_status msm_dp_display_mode_valid(struct msm_dp *dp,
if (!dp || !mode_pclk_khz || !dp->connector) {
DRM_ERROR("invalid params\n");
- return -EINVAL;
+ return MODE_BAD;
}
msm_dp_display = container_of(dp, struct msm_dp_display_private, msm_dp_display);
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index c1e4147bfef1..dd4e8426cfe0 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -251,7 +251,7 @@ static enum drm_mode_status msm_edp_bridge_mode_valid(struct drm_bridge *bridge,
if (!dp || !mode_pclk_khz || !dp->connector) {
DRM_ERROR("invalid params\n");
- return -EINVAL;
+ return MODE_BAD;
}
if (msm_dp_wide_bus_available(dp))
--
2.56.1.708.g77570a6a1d-goog
reply other threads:[~2026-11-19 17:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119171046.1536673-1-irogers@google.com \
--to=irogers@google.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elkin@google.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®