From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.72 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795114362; b=irN3SGrd+HpGOYt2OUBkK4HmEYBPQlaN2FUDCiIBDNn5lpHEkcInAPIAtRNZ34gUvsjM nOp4YUu0XKuM9VqITT1INHSZUwFlHcvMavMnXoTb2M652wkbkLzwsLVEt2pjEFdUiCJm8 ImYWztexuPJXUPKhhvpLjHYQuCrJXl4dpQFuhETvX4rDDV+KYyKJa1sGt/4OEoQbvtGaO 0q2nQPHvt32WXaOIuusModaY71zG3lbFB8eCdXXbai8NqIW3dLVWXHZowBxQMaqjQSk8t NZc+Hrpqelqf6QFD9rkX8I1lLFlbMwWwydOPIQJ0J5gDqk29XQ+/3+iRVfmmnT4zXLw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795114362; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=FFPgXiiazla35XDoHe2VRdMYq0SrMDfs5EMKUnqJLEg=; b=vm4UIoXhqlsAlHh+Fo37Mef358C5Eqkhb3QsuINLgbo/LOD3hx+BthWhXMoNGlpcx/Wm xjQVa4PPajAp8uWG/QAwVxua3QEUAFfDN+USmcjmjgR9S6V2upqyWUgJ6/E6RMJNDYrC1 HB2oei4snPouVv+O7OnHo0KLJ/3HXOZI3hdOiRESCD5lFAFbO4bpROJOwqc64nOHmoJSv HeBxcwwi5MqGgar4uAlEs0k77xCOCdu5nYJueiHJUyGEkiFWPGZEh44Rhk+xONX60RJMF g6ApmOY1BC86c5ROeZe27jW7dlbMj4RDhvhNO0oMZGXBTIaBdZAWLwO9CzCduwDDpoA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=QoxGqnw5; arc=none smtp.remote-ip=209.85.160.72 Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA11B60A3801 for ; Thu, 19 Nov 2026 18:52:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AA11B60A3801 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--coltonlewis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=QoxGqnw5 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-4ab90cdf747so1637492fac.1 for ; Thu, 19 Nov 2026 10:52:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795114361; x=1795719161; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FFPgXiiazla35XDoHe2VRdMYq0SrMDfs5EMKUnqJLEg=; b=QoxGqnw5MnWI+YzinmwsjZHef5uF1Zt+ipWC+nszZev6CzAbus7DpLXrzCjXNUhblv 54dvRSv6uhu0PsVrSLiYOYL4kshp/c271RIh1KUQKesBEc7ThwAa8p00c+EfZr8VklUy F16dOWrk7SqyBrxYEUYrKL93ZU/jk7jmQvw8J+5RHjZzLpCQAyzQVWI7hATnSg+A09L3 Z+8/ca3O0ApwcRDQxwLRiilqHWSplF1IJwnFNid3ebREnvcBUWZ8v72bQaXGas3Bt4Si X2itVPNUGx7Bdu3AiIX5Bprb650cUsSgvknhy/omNGSXG0LsXm660vxSd7FpLFNH23x7 x3gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795114361; x=1795719161; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FFPgXiiazla35XDoHe2VRdMYq0SrMDfs5EMKUnqJLEg=; b=OerT9j8zXbP5bAvITJvo4jXTqSWTeyylo1DT+sG3vCCMAZlmUR1lGVQEcv+pFM1u0D 87WuH+AYwWYsAlnf7L3XTUJ61yh8YyGTZkxk+amKuqwWm53DBLdPQ61Hu4tbGhUm3GDV lIm0+nwuHHouWSMgo4nXZUmYSnPT/qTMnb1OUa/wVKtJeh5MSvhtBzydB9AlHeNAMOL0 LRAYKCIUzoK9fvdBkiX4CiMM9bCz+jyP5R2sZfxHVt47YqODBS7HzX3uNQf0NcUwKxCx 09WWIHZRmiyLpS3i3pxuxKemROP9f7YR2Lmz714dy4+OpGX+84Jbh11nnQ3bun8w/RR4 X7ww== X-Forwarded-Encrypted: i=1; AL+hErHyjvDhTMzWhn37wMxM+seCXxpNcdrzO25GzOk77NsgeNqG3/jVBL9K92mkKtsY74f69xrNOLwBjhDdd6I=@vger.kernel.org X-Gm-Message-State: APuU4Z9wEtCTDnfcKUCZaC0qeN7BArh/9QujoiNb3HEkqS7RGEshrDxU Dzw9VvETxDMc0Gw+D+yYhyDG+meB/ZOd8+dXFnR32Zq+jzJ71kwv7o6/dN+HpDxNGG1IL/SNGXP ib477TLxeGib4Rix0mPX46vWTTw== X-Received: from ilbeb1.prod.google.com ([2002:a05:6e02:4601:b0:54f:8d15:4dbc]) (user=coltonlewis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:2383:b0:572:f8ec:5340 with SMTP id 5614622812f47-5797dd97e12mr1488800b6e.40.1795114360210; Thu, 19 Nov 2026 10:52:40 -0800 (PST) Date: Thu, 19 Nov 2026 18:52:07 +0000 In-Reply-To: <20261119185215.632334-1-coltonlewis@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261119185215.632334-1-coltonlewis@google.com> X-Mailer: git-send-email 2.56.1.809.ga0b61035b5-goog Message-ID: <20261119185215.632334-26-coltonlewis@google.com> Subject: [PATCH v10 25/33] KVM: arm64: Detect overflows for the Partitioned PMU From: Colton Lewis To: Marc Zyngier , Oliver Upton Cc: Catalin Marinas , Will Deacon , Mark Rutland , Peter Zijlstra , Ingo Molnar , Paolo Bonzini , Russell King , Jonathan Corbet , Fuad Tabba , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Shuah Khan , James Clark , Alexandru Elisei , Mingwei Zhang , Ganapatrao Kulkarni , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Evaluate whether any enabled and unmasked guest counter has overflowed in kvm_pmu_part_overflow_status() so KVM updates the virtual PMU interrupt level in the vGIC (or userspace IRQ state) across VM entries and host PMU overflow interrupts: - Harvest any live guest overflow bits from physical pmovsset_el0 into shadow PMOVSSET_EL0 and clear them in hardware when the partitioned PMU is loaded on the local CPU. - Check (PMOVSSET_EL0 & PMINTENSET_EL1) against PMCR_EL0.E for guest counters 0..HPMN-1 and PMCCNTR_EL0, and against MDCR_EL2.HPME for nested hypervisor counters HPMN..N-1. - In kvm_pmu_handle_guest_irq(), raise KVM_REQ_IRQ_PENDING and kick the vCPU (or queue overflow_work when running in NMI context) when an unmasked guest overflow occurs. Signed-off-by: Colton Lewis --- arch/arm64/kvm/pmu-direct.c | 65 +++++++++++++++++++++++++++++++++++++ arch/arm64/kvm/pmu-emul.c | 4 +-- arch/arm64/kvm/pmu.c | 8 +++++ include/kvm/arm_pmu.h | 2 ++ 4 files changed, 77 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kvm/pmu-direct.c b/arch/arm64/kvm/pmu-direct.c index 21357decce214..b0491d32b5d7b 100644 --- a/arch/arm64/kvm/pmu-direct.c +++ b/arch/arm64/kvm/pmu-direct.c @@ -823,6 +823,71 @@ void kvm_pmu_handle_guest_irq(u64 pmovsr) return; __vcpu_rmw_sys_reg(vcpu, PMOVSSET_EL0, |=, govf); + + if (kvm_pmu_part_overflow_status(vcpu)) { + kvm_make_request(KVM_REQ_IRQ_PENDING, vcpu); + + if (!in_nmi()) + kvm_vcpu_kick(vcpu); + else + irq_work_queue(&vcpu->arch.pmu.overflow_work); + } +} + +/** + * kvm_pmu_part_overflow_status() - Determine if any guest counters have overflowed + * @vcpu: Pointer to struct kvm_vcpu + * + * Determine if any guest counters have overflowed and therefore an + * IRQ needs to be injected into the guest. If an overflow is detected + * while access is VCPU_PMU_ACCESS_FREE (for example, after state + * restoration via KVM_SET_ONE_REG), transition the vCPU to + * VCPU_PMU_ACCESS_GUEST_OWNED. + * + * Return: True if there was an overflow, false otherwise + */ +bool kvm_pmu_part_overflow_status(struct kvm_vcpu *vcpu) +{ + u64 mask = kvm_vcpu_pmu_guest_counter_mask(vcpu); + u64 hyp_mask = kvm_pmu_hyp_counter_mask(vcpu); + u64 pmovs, pmint, pmcr, reg; + unsigned long flags; + bool overflow; + + local_irq_save(flags); + if (vcpu->arch.pmu.loaded_on_cpu && + vcpu == kvm_get_running_vcpu()) { + u64 hw_ovf = read_sysreg(pmovsset_el0) & mask; + + if (hw_ovf) { + __vcpu_rmw_sys_reg(vcpu, PMOVSSET_EL0, |=, hw_ovf); + write_sysreg(hw_ovf, pmovsclr_el0); + } + pmint = read_pmintenset(); + pmcr = read_pmcr(); + } else { + pmint = __vcpu_sys_reg(vcpu, PMINTENSET_EL1); + pmcr = __vcpu_sys_reg(vcpu, PMCR_EL0); + } + + pmovs = __vcpu_sys_reg(vcpu, PMOVSSET_EL0); + local_irq_restore(flags); + + reg = pmovs & pmint & mask; + if (!(pmcr & ARMV8_PMU_PMCR_E)) + reg &= hyp_mask; + if (hyp_mask && !(__vcpu_sys_reg(vcpu, MDCR_EL2) & MDCR_EL2_HPME)) + reg &= ~hyp_mask; + + overflow = !!reg; + + if (overflow && !in_interrupt() && + kvm_pmu_get_access(vcpu) == VCPU_PMU_ACCESS_FREE) { + scoped_guard(preempt) + kvm_pmu_set_guest_owned(vcpu); + } + + return overflow; } /** diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c index da66162c68042..a72bdc5a0b3ea 100644 --- a/arch/arm64/kvm/pmu-emul.c +++ b/arch/arm64/kvm/pmu-emul.c @@ -268,7 +268,7 @@ void kvm_pmu_reprogram_counter_mask(struct kvm_vcpu *vcpu, u64 val) * counter where the values of the global enable control, PMOVSSET_EL0[n], and * PMINTENSET_EL1[n] are all 1. */ -bool kvm_pmu_overflow_status(struct kvm_vcpu *vcpu) +bool kvm_pmu_emul_overflow_status(struct kvm_vcpu *vcpu) { u64 reg = __vcpu_sys_reg(vcpu, PMOVSSET_EL0); @@ -400,7 +400,7 @@ static void kvm_pmu_perf_overflow(struct perf_event *perf_event, kvm_pmu_counter_increment(vcpu, BIT(idx + 1), ARMV8_PMUV3_PERFCTR_CHAIN); - if (kvm_pmu_overflow_status(vcpu)) { + if (kvm_pmu_emul_overflow_status(vcpu)) { kvm_make_request(KVM_REQ_IRQ_PENDING, vcpu); if (!in_nmi()) diff --git a/arch/arm64/kvm/pmu.c b/arch/arm64/kvm/pmu.c index 7389d61957fa9..9d4ad4b7bd8d5 100644 --- a/arch/arm64/kvm/pmu.c +++ b/arch/arm64/kvm/pmu.c @@ -409,6 +409,14 @@ u64 kvm_pmu_evtyper_mask(struct kvm *kvm) return mask; } +bool kvm_pmu_overflow_status(struct kvm_vcpu *vcpu) +{ + if (kvm_pmu_is_partitioned(vcpu->kvm)) + return kvm_pmu_part_overflow_status(vcpu); + + return kvm_pmu_emul_overflow_status(vcpu); +} + static void kvm_pmu_update_state(struct kvm_vcpu *vcpu) { struct kvm_pmu *pmu = &vcpu->arch.pmu; diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h index 9800514019630..fcd8e6331943e 100644 --- a/include/kvm/arm_pmu.h +++ b/include/kvm/arm_pmu.h @@ -91,6 +91,8 @@ bool kvm_set_pmuserenr(u64 val); void kvm_vcpu_pmu_restore_guest(struct kvm_vcpu *vcpu); void kvm_vcpu_pmu_restore_host(struct kvm_vcpu *vcpu); void kvm_vcpu_pmu_resync_el0(void); +bool kvm_pmu_emul_overflow_status(struct kvm_vcpu *vcpu); +bool kvm_pmu_part_overflow_status(struct kvm_vcpu *vcpu); #define kvm_vcpu_has_pmu(vcpu) \ (vcpu_has_feature(vcpu, KVM_ARM_VCPU_PMU_V3)) -- 2.56.1.708.g77570a6a1d-goog