mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Song <xinmengs@nvidia.com>
To: <dakr@kernel.org>, <acourbot@nvidia.com>, <kvm@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>, <nova-gpu@lists.linux.dev>,
	<linux-pci@vger.kernel.org>
Cc: Simon Song <xinmengs@nvidia.com>, <alex@shazbot.org>,
	<jgg@nvidia.com>, <yishaih@nvidia.com>, <skolothumtho@nvidia.com>,
	<kevin.tian@intel.com>, <airlied@gmail.com>, <simona@ffwll.ch>,
	<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
	<boqun.feng@gmail.com>, <gary@garyguo.net>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <aliceryhl@google.com>,
	<tmgross@umich.edu>, <jhubbard@nvidia.com>,
	<ecourtney@nvidia.com>, <cjia@nvidia.com>, <smitra@nvidia.com>,
	<kjaju@nvidia.com>, <alkumar@nvidia.com>, <ankita@nvidia.com>,
	<aniketa@nvidia.com>, <kwankhede@nvidia.com>,
	<targupta@nvidia.com>, <linux-kernel@vger.kernel.org>,
	<zhiwang@kernel.org>, <zhiw@nvidia.com>, <boqun@kernel.org>,
	<daniel.almeida@collabora.com>, <tamird@kernel.org>,
	<work@onurozkan.dev>, <jgg@ziepe.ca>, <bhelgaas@google.com>,
	<kwilczynski@kernel.org>, <dri-devel@lists.freedesktop.org>,
	<peter@colberg.org>
Subject: [PATCH v3 0/9] Rust VFIO PCI support and NVIDIA vGPU driver
Date: Thu, 19 Nov 2026 13:50:35 -0800	[thread overview]
Message-ID: <20261119215046.2892839-1-xinmengs@nvidia.com> (raw)

This is v3 of the Rust VFIO PCI abstractions and the NVIDIA VFIO variant
driver [1]. The driver uses nova-core's typed SR-IOV PF interface to
create, reset and release vGPU instances while VFIO provides userspace
access to the PCI device.

Patches 1-5 add the PCI helpers and callbacks the VFIO abstractions
need. Patch 6 adds the VFIO device handling common to all buses, and
patch 7 the VFIO PCI abstractions on top of it. Patch 8 publishes the
typed Nova PF interface, and patch 9 adds the NVIDIA VFIO variant
driver.

This series is based on drm-rust-next with the Rust PCI SR-IOV series
[2] applied. Patches 1-7 need nothing else. Patches 8 and 9 also depend
on Alok's vGPU manager series [3] and can follow once it has landed.

Runtime PM is not part of this series anymore. As Danilo suggested, it
will follow as a separate series based on Beata's generic Rust runtime
PM work [4], so that the rest can land independently. Until then,
vfio::pci::Registration keeps the device runtime active while it is
registered, so a VF bound to the driver is not runtime suspended.

Changes since v2:
- Drop runtime PM from this series (v2 patch 08 and the runtime PM
  parts of v2 patches 04, 09 and 12), see above.
- Put the common VFIO device handling first (v2 patch 10, now patch 6)
  and squash v2 patches 04 and 09 into one patch (patch 7) (Danilo).
- Drop the bind callback (v2 patch 06). A driver registers its VFIO
  device with vfio::pci::Registration::new(), for example from probe,
  and unregisters it by dropping the Registration (Danilo).
- Patch 1: say first what the function does in its documentation
  (Gary).
- Patch 2: return Result<u16> from vf_id(), and add a C helper so that
  it builds without CONFIG_PCI_IOV (Danilo).
- Patch 3: make DRIVER_MANAGED_DMA an unsafe marker, until the DMA
  setup tokens exist (Danilo).
- Patches 4 and 5: use Device::drvdata_borrow() and #[optional]; add
  the pci::ChannelState and pci::ErsResult types (Danilo).
- Patch 6: add vfio::DeviceBase and RawDevice; use GATs instead of
  ForLt/CovariantForLt and drop the covariance requirement on the
  registration data (Danilo).
- Patch 8: drop the CONFIG_PCI_IOV guards, use a pin-init
  self-reference for the GPU, simplify the SAFETY comment and use
  enable_all() (Danilo).
- Patch 9: rename the driver to nova-vgpu (Danilo), and adapt it to the
  changes above.

v2 patches 01, 02, 03, 05, 07, 10, 04+09, 11 and 12 are now patches
1 to 9.

[1] https://lore.kernel.org/nova-gpu/20261023154009.2246627-1-xinmengs@nvidia.com/
[2] https://lore.kernel.org/all/20261111223337.508989-1-xinmengs@nvidia.com/
[3] https://lore.kernel.org/all/cover.1793906667.git.alkumar@nvidia.com/
[4] https://lore.kernel.org/all/20261026120523.526942-2-beata.michalska@arm.com/

Danilo Krummrich (5):
  rust: pci: add VFIO override device IDs
  rust: pci: expose the VF index within its PF
  rust: pci: allow drivers to manage DMA ownership
  rust: vfio: add PCI variant driver abstractions
  vfio/nova-vgpu: add the Rust VFIO variant driver

Simon Song (2):
  rust: pci: add reset callbacks
  rust: pci: add an error_detected callback

Zhi Wang (2):
  rust: vfio: add common VFIO device handling
  gpu: nova-core: publish typed SR-IOV PF APIs

 drivers/gpu/Makefile                    |  15 +-
 drivers/gpu/nova-core/driver.rs         |  34 +-
 drivers/gpu/nova-core/nova_core.rs      |   3 +-
 drivers/gpu/nova-core/vgpu.rs           |   1 -
 drivers/gpu/nova-core/vgpu/vgpu_api.rs  | 178 ++++--
 drivers/vfio/pci/Kconfig                |   2 +
 drivers/vfio/pci/Makefile               |   2 +
 drivers/vfio/pci/nova-vgpu/Kconfig      |  20 +
 drivers/vfio/pci/nova-vgpu/Makefile     |   3 +
 drivers/vfio/pci/nova-vgpu/nova_vgpu.rs | 375 ++++++++++++
 rust/bindings/bindings_helper.h         |   4 +
 rust/helpers/pci.c                      |   5 +
 rust/kernel/lib.rs                      |   2 +
 rust/kernel/pci.rs                      | 194 ++++++
 rust/kernel/pci/iov.rs                  |  11 +
 rust/kernel/vfio.rs                     | 433 +++++++++++++
 rust/kernel/vfio/pci.rs                 | 777 ++++++++++++++++++++++++
 17 files changed, 2011 insertions(+), 48 deletions(-)
 create mode 100644 drivers/vfio/pci/nova-vgpu/Kconfig
 create mode 100644 drivers/vfio/pci/nova-vgpu/Makefile
 create mode 100644 drivers/vfio/pci/nova-vgpu/nova_vgpu.rs
 create mode 100644 rust/kernel/vfio.rs
 create mode 100644 rust/kernel/vfio/pci.rs

-- 
2.43.7


             reply	other threads:[~2026-11-19 21:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 21:50 Simon Song [this message]
2026-11-19 21:50 ` [PATCH v3 1/9] rust: pci: add VFIO override device IDs Simon Song
2026-11-19 21:50 ` [PATCH v3 2/9] rust: pci: expose the VF index within its PF Simon Song
2026-11-19 21:50 ` [PATCH v3 3/9] rust: pci: allow drivers to manage DMA ownership Simon Song
2026-11-19 21:50 ` [PATCH v3 4/9] rust: pci: add reset callbacks Simon Song
2026-11-19 21:50 ` [PATCH v3 5/9] rust: pci: add an error_detected callback Simon Song
2026-11-19 21:50 ` [PATCH v3 6/9] rust: vfio: add common VFIO device handling Simon Song
2026-11-19 21:50 ` [PATCH v3 7/9] rust: vfio: add PCI variant driver abstractions Simon Song
2026-11-19 21:50 ` [PATCH v3 8/9] gpu: nova-core: publish typed SR-IOV PF APIs Simon Song
2026-11-19 21:50 ` [PATCH v3 9/9] vfio/nova-vgpu: add the Rust VFIO variant driver Simon Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119215046.2892839-1-xinmengs@nvidia.com \
    --to=xinmengs@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=alex@shazbot.org \
    --cc=aliceryhl@google.com \
    --cc=alkumar@nvidia.com \
    --cc=aniketa@nvidia.com \
    --cc=ankita@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=boqun@kernel.org \
    --cc=cjia@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jgg@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=kjaju@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=peter@colberg.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=skolothumtho@nvidia.com \
    --cc=smitra@nvidia.com \
    --cc=tamird@kernel.org \
    --cc=targupta@nvidia.com \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    --cc=yishaih@nvidia.com \
    --cc=zhiw@nvidia.com \
    --cc=zhiwang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®