From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.69 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795132633; b=tCtjZ7hUotc+O+KXUbmjqZvAuFhPJ1e28zdpS4cVZGoO7dxBUzp01tCAS88cWoM2lQv1 8iyGVXvHaUyx8ULHA90M1922e3otKgcW0tNdR5XnrTA9AkX/6VDJAA6hIaUU2HgiKyjjj BBflp2s+kkeLlfuDynUtOgN/j3FdI/LLs3hPbBBc5b1TX6eTAsj7zVnCeAF4EtlrLKmGF rvHtLwA9S0kjsZj3+t84Y+Auw6m6/1FZLENm9DehEdpgJZmAunPZ82oFF5u7vXbBxSL5y Nmd1oICy6obO5PhO3x+O4M4LZ5UdqzVaSNJnYCUnvgktRlTK+XGygjHi2SxL/V8fjTw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795132633; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Reply-To:Date: In-Reply-To:Mime-Version:References:X-Mailer:Message-ID:Subject:From: To:Cc:Content-Type; bh=CxL1JG/eaAvQmtg2HGu1fjGYJ5Z2sLLivJqdimcugHQ=; b=bs4l/gQ0uFVuPzAoSTbw97OUnHx12F5aN8nmw1O1nNfU7cecRISBedoOvgNtndFT+lvM s8bnCkNYDw+J080CJhn96FDl5fmU9dMw9Dmo6lLJT2bFosPkDPrQvGRyGjh00fcpttmKy fK2v/jG2pdJEAn5D9I8hyDWPB+8N7+B7FsoW0omEcbLU2+eYVFeCWp7hA8Ur9KzFhg0j7 11PgaiR0qPV5pP5ysOM885mYkZ+mK9X4f88hR5FjWdc28dMPn4dRympeNTZLAgEFGCDiQ pp/Hy3QFhe/4qIUDBtltN8nmfX8t/Hs8vMIEO/fP6NXxtwFsmhl5nAXTUifX6Rinl7A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b="n+AKW/mn"; arc=none smtp.remote-ip=209.85.216.69 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 063A2606A33C for ; Thu, 19 Nov 2026 23:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 063A2606A33C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=n+AKW/mn Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3b41e8c1ac0so340562a91.2 for ; Thu, 19 Nov 2026 15:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795132632; x=1795737432; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=CxL1JG/eaAvQmtg2HGu1fjGYJ5Z2sLLivJqdimcugHQ=; b=n+AKW/mn3+R19SrYgtrVtFd5Qzdj+LpN0rbt9HhVWurSSmftxyAqZLc2Ri+jJSwGMH 3oW4785YiQiD6nhey27+2loE0WJAlKuId2XNQDRYREF6Yc3LOXg1YMgqOZqbP/4aRfbA NBH+zJLF+ZKUavTqOkTHNs2Rmc51wkGjZgEfDpYYr0A+UWd7vFkm2IALPMZvu1LYLFy6 2tEqwhb5eAorQJOHqGH07yxmXpNNWALYYsegF7QPBb00NqxK3LJqkQmD3H14verS0jMw JrLv3MBdUm4+FfLokFk1NUFs+ug7XZ3LHCM0qBV+QTqBznGUNBnnKpw6Zzc+c3R5S7w8 LUnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795132632; x=1795737432; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CxL1JG/eaAvQmtg2HGu1fjGYJ5Z2sLLivJqdimcugHQ=; b=d/LH1d4Jam0d15dHxT9GsRguXEozDysVNj9xwtWn5FTZvS0E4ZsBzFpmqjSHntVtoJ yxrX0xEGL0WL3ANJCouWvC9aQKwnEAba9easgEkehxVNCVs8atimVkvR9squjnwOUuAG hByNJ6e/hrp9D696ayaYUzG/X7tVhruXn0QxZzwNhzY3YaRqtqaBzAkPRGzSiy4nhEaE 9httMfqs8DAmtuWMDZPc9/8XFP4On7ZGFOi6a7VSeymwV3e+iojQwQJDYSMkWOA3wPE0 AJfLFkTVVClB/rsY7ybhUjj/v4widWseXKoi9shk7G6l1klJ/dXHcjreSHkbdhfJBRQw OPbQ== X-Forwarded-Encrypted: i=1; AL+hErEUjgOBySY0rNOOgX77vD/+/yz/BzTvfHfovL6USkpDkcxQ63eqPmj5ArlBX7sIoBkrKN8faqgrU54OsoI=@vger.kernel.org X-Gm-Message-State: APuU4Z8VzjENsEvZGfdAIHxaJDL5WYMrbZhztx4KC25IPDtuf/rmQmKW jf0k9plfSDvt7BEkY7xcnhO1yJGiw4OrchNBqINquhdfQUoN/e34BwkM8odY3zQ5vl5Yr+0c3Ud vesvv1A== X-Received: from pjbhs15.prod.google.com ([2002:a17:90b:200f:b0:3b4:a90:5a08]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2f8f:b0:3ac:9f24:44be with SMTP id 98e67ed59e1d1-3b41c92a3dbmr971067a91.29.1795132632118; Thu, 19 Nov 2026 15:57:12 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 19 Nov 2026 15:56:56 -0800 In-Reply-To: <20261119235656.70315-1-seanjc@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261119235656.70315-1-seanjc@google.com> X-Mailer: git-send-email 2.56.1.708.g77570a6a1d-goog Message-ID: <20261119235656.70315-7-seanjc@google.com> Subject: [PATCH v2 6/6] KVM: Extract and dedup the kick code to check if a CPU needs an IPI From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Satish Kharat , Sashiko Bot , Oliver Upton , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Extract the kick logic's code to determine if a target CPU actually needs an IPI into a helper function. In addition to deduplicating the existing checks in common KVM, the helper can "likely" (read: will) be eventually used in arch specific code as well. No functional change intended: KVM always uses '-1' to indicate an invalid vcpu->cpu, so "!= -1", "(unsigned int)cpu < nr_cpu_ids", and ">= 0" are all functionally equivalent. Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 48fef91b8530..d8027ea0c447 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -209,6 +209,11 @@ static bool kvm_request_needs_ipi(struct kvm_vcpu *vcpu, unsigned req) return mode == IN_GUEST_MODE; } +static bool kvm_cpu_needs_ipi(int cpu, int me) +{ + return cpu >= 0 && cpu != me && cpu_online(cpu); +} + static void ack_kick(void *_completed) { } @@ -273,7 +278,7 @@ static void kvm_make_vcpu_request(struct kvm_vcpu *vcpu, */ if (kvm_request_needs_ipi(vcpu, kick->req)) { cpu = READ_ONCE(vcpu->cpu); - if (cpu != -1 && cpu != kick->me && cpu_online(cpu)) { + if (kvm_cpu_needs_ipi(cpu, kick->me)) { kick->need_kick = true; if (kick->cpus) __cpumask_set_cpu(cpu, kick->cpus); @@ -3951,7 +3956,7 @@ void __kvm_vcpu_kick(struct kvm_vcpu *vcpu, bool wait) */ if (kvm_arch_vcpu_should_kick(vcpu)) { cpu = READ_ONCE(vcpu->cpu); - if (cpu != me && (unsigned int)cpu < nr_cpu_ids && cpu_online(cpu)) { + if (kvm_cpu_needs_ipi(cpu, me)) { /* * Use a reschedule IPI to kick the vCPU if the caller * doesn't need to wait for a response, as KVM allows -- 2.56.1.708.g77570a6a1d-goog