mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srikanth Boyapally <srikanth.boyapally@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<michal.simek@amd.com>, <git@amd.com>,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Srikanth Boyapally <srikanth.boyapally@amd.com>
Subject: [PATCH] spi: cadence-quadspi: Bypass STIG for Versal and Versal Gen 2 OSPI data
Date: Fri, 20 Nov 2026 14:49:26 +0530	[thread overview]
Message-ID: <20261120-ospi_stig-v1-1-54f4d5f9f7b9@amd.com> (raw)

From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>

The OSPI controllers on Versal and Versal Gen 2 support STIG data
transfers in 1-1-1 and 8-8-8 modes. Short data transfers in 1-1-8 and
1-8-8 modes fail when routed through STIG.

Set CQSPI_DISABLE_STIG_MODE in the platform data for both controllers
to route addressed data transfers through the regular data path. Keep
STIG for register reads and writes without an address.

Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>
---
 drivers/spi/spi-cadence-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 844df97111d7..4e2ae41ffee3 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -2122,7 +2122,7 @@ static const struct cqspi_driver_platdata socfpga_qspi = {
 static const struct cqspi_driver_platdata versal_ospi = {
 	.hwcaps_mask = CQSPI_SUPPORTS_OCTAL,
 	.quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_SUPPORT_EXTERNAL_DMA |
-		  CQSPI_DMA_SET_MASK,
+		  CQSPI_DMA_SET_MASK | CQSPI_DISABLE_STIG_MODE,
 	.indirect_read_dma = cqspi_versal_indirect_read_dma,
 	.get_dma_status = cqspi_get_versal_dma_status,
 };
@@ -2130,7 +2130,8 @@ static const struct cqspi_driver_platdata versal_ospi = {
 static const struct cqspi_driver_platdata versal2_ospi = {
 	.hwcaps_mask = CQSPI_SUPPORTS_OCTAL,
 	.quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_SUPPORT_EXTERNAL_DMA |
-		  CQSPI_DMA_SET_MASK | CQSPI_SUPPORT_DEVICE_RESET,
+		  CQSPI_DMA_SET_MASK | CQSPI_DISABLE_STIG_MODE |
+		  CQSPI_SUPPORT_DEVICE_RESET,
 	.indirect_read_dma = cqspi_versal_indirect_read_dma,
 	.get_dma_status = cqspi_get_versal_dma_status,
 };

---
base-commit: 715e17fd0157db208c893de8afb5072b86c0a562
change-id: 20261120-ospi_stig-52de3a66a8f5

Best regards,
--  
Srikanth Boyapally <srikanth.boyapally@amd.com>


                 reply	other threads:[~2026-11-20  9:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120-ospi_stig-v1-1-54f4d5f9f7b9@amd.com \
    --to=srikanth.boyapally@amd.com \
    --cc=broonie@kernel.org \
    --cc=git@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=sai.krishna.potthuri@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®