mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev-bot+sashiko@kernel.org
Cc: o.rempel@pengutronix.de, robin@protonic.nl,
	socketcan@hartkopp.net,  shuah@kernel.org, kernel@pengutronix.de,
	linux-can@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, fmaurer@redhat.com,
	 mailhol@kernel.org, alexander.hoelzl@gmx.net,
	quchaosheng000406@163.com,  penguin-kernel@i-love.sakura.ne.jp,
	kuba@kernel.org
Subject: Re: [PATCH can-next v4 7/9] selftests: can: add J1939 TP/ETP multi-frame tests against CAN_RAW
Date: Fri, 20 Nov 2026 11:30:21 +0100	[thread overview]
Message-ID: <20261120-practical-labrador-from-pluto-e9dfc0-mkl@pengutronix.de> (raw)
In-Reply-To: <179513247817.3132.9443006972128193443@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On 19.11.2026 23:54:38, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The commit message argues that test_j1939_multi.sh can stay in
>   the default TEST_PROGS run (not TEST_PROGS_EXTENDED or XFAIL) because…
> - [Low] In j1939_helpers.h, errqueue_empty_ok() is documented as "Is the
>   error queue of s still empty after J1939_NEG_RECV_TIMEOUT_MS?".

pw-bot: cr

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-20 10:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:42 [PATCH can-next v4 0/9] selftests: can: add J1939 socket and transport tests Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 1/9] selftests: can: install net/lib.sh with the CAN tests Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 2/9] selftests: can: add J1939 test helper header and library Oleksij Rempel
2026-11-19 23:54   ` netdev-bot+sashiko
2026-11-18  8:42 ` [PATCH can-next v4 3/9] selftests: can: add J1939 base functional tests Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 4/9] selftests: can: add J1939 socket option and metadata tests Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 5/9] selftests: can: add J1939 addressing and concurrency tests Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 6/9] selftests: can: add J1939 wire-format tests against CAN_RAW Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 7/9] selftests: can: add J1939 TP/ETP multi-frame " Oleksij Rempel
2026-11-19 23:54   ` netdev-bot+sashiko
2026-11-20 10:30     ` Marc Kleine-Budde [this message]
2026-11-18  8:42 ` [PATCH can-next v4 8/9] selftests: can: cover J1939 transport abort and timeout paths Oleksij Rempel
2026-11-18  8:42 ` [PATCH can-next v4 9/9] selftests: can: check SO_J1939_PROMISC receive effect Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120-practical-labrador-from-pluto-e9dfc0-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=alexander.hoelzl@gmx.net \
    --cc=fmaurer@redhat.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=quchaosheng000406@163.com \
    --cc=robin@protonic.nl \
    --cc=shuah@kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®