From: Seonghyeon Lim via B4 Relay <devnull+forfortuna.naver.com@kernel.org>
To: Harald Mommer <harald.mommer@oss.qualcomm.com>,
Matias Ezequiel Vara Larsen <mvaralar@redhat.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Mikhail Golubev-Ciuchea
<mikhail.golubev-ciuchea@oss.qualcomm.com>,
Francesco Valla <francesco@valla.it>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux.dev, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, Jason Wang <jasowangio@gmail.com>,
stable@vger.kernel.org, Seonghyeon Lim <forfortuna@naver.com>
Subject: [PATCH v2 2/2] can: virtio: fix virtqueue use before DRIVER_OK
Date: Fri, 20 Nov 2026 15:56:04 +0900 [thread overview]
Message-ID: <20261120-virtio-can-ready-v2-2-0defda2af8cb@naver.com> (raw)
In-Reply-To: <20261120-virtio-can-ready-v2-0-0defda2af8cb@naver.com>
From: Seonghyeon Lim <forfortuna@naver.com>
virtio_can_probe() and virtio_can_restore() fill the RX virtqueue and
kick it before the device is set DRIVER_OK. The virtio specification
does not allow the driver to notify the device before DRIVER_OK.
In restore, if the interface was up, virtio_can_open() then sends a
START control message and waits for the reply. DRIVER_OK is only set
by the virtio core after restore returns, so the device may never
handle the request and the wait never completes, which hangs system
resume:
task:kworker/u4:5 state:D
Workqueue: async async_run_entry_fn
Call Trace:
__wait_for_common
virtio_can_send_ctrl_msg
virtio_can_open
virtio_can_restore
virtio_device_restore_priv
dpm_run_callback
device_resume
In probe, an ndo_open() right after register_candev() can likewise
send the START message before DRIVER_OK.
Call virtio_device_ready() before the first virtqueue use in both
probe and restore, as virtio-net does. Config change callbacks are
still deferred by the virtio core until probe or restore returns, and
virtqueue callbacks that arrive before NAPI is enabled are handled in
virtio_can_napi_enable().
Fixes: 083082a4e6d8 ("can: virtio: Add virtio CAN driver")
Cc: stable@vger.kernel.org
Signed-off-by: Seonghyeon Lim <forfortuna@naver.com>
---
drivers/net/can/virtio_can.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/can/virtio_can.c b/drivers/net/can/virtio_can.c
index 9055d7e43235..549e8d789d74 100644
--- a/drivers/net/can/virtio_can.c
+++ b/drivers/net/can/virtio_can.c
@@ -925,6 +925,9 @@ static int virtio_can_probe(struct virtio_device *vdev)
err = -ENOMEM;
goto on_failure;
}
+
+ virtio_device_ready(vdev);
+
virtio_can_populate_rx_vq(vdev);
err = register_virtio_can_dev(dev);
@@ -979,6 +982,9 @@ static int __maybe_unused virtio_can_restore(struct virtio_device *vdev)
virtio_can_del_vq(vdev);
return -ENOMEM;
}
+
+ virtio_device_ready(vdev);
+
virtio_can_populate_rx_vq(vdev);
if (netif_running(ndev)) {
--
2.43.0
prev parent reply other threads:[~2026-11-20 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:56 [PATCH v2 0/2] can: virtio: fix NAPI stall and " Seonghyeon Lim via B4 Relay
2026-11-20 6:56 ` [PATCH v2 1/2] can: virtio: fix RX/TX stall on interrupt before NAPI is enabled Seonghyeon Lim via B4 Relay
2026-11-20 6:56 ` Seonghyeon Lim via B4 Relay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120-virtio-can-ready-v2-2-0defda2af8cb@naver.com \
--to=devnull+forfortuna.naver.com@kernel.org \
--cc=forfortuna@naver.com \
--cc=francesco@valla.it \
--cc=harald.mommer@oss.qualcomm.com \
--cc=jasowangio@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mikhail.golubev-ciuchea@oss.qualcomm.com \
--cc=mkl@pengutronix.de \
--cc=mst@redhat.com \
--cc=mvaralar@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®