mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: "Haneen Mohammed" <hamohammed.sa@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Melissa Wen" <melissa.srw@gmail.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	jose.exposito89@gmail.com, "Jonathan Corbet" <corbet@lwn.net>,
	"Oarora Etimis" <oaroraetimis@gmail.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Lucas De Marchi" <demarchi@kernel.org>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Louis Chauvet" <louis.chauvet@bootlin.com>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	 Kory Maincent <kory.maincent@bootlin.com>,
	sebastian.wick@redhat.com,  victoria@system76.com,
	thomas.petazzoni@bootlin.com,  dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,  linux-doc@vger.kernel.org,
	Simona Vetter <simona.vetter@ffwll.ch>,
	 llvm@lists.linux.dev
Subject: [PATCH v6 13/43] drm/vkms: Add KUnit test for device lifecycle
Date: Fri, 20 Nov 2026 18:58:55 +0100	[thread overview]
Message-ID: <20261120-vkms-all-config-v6-13-78ace90f4fc1@bootlin.com> (raw)
In-Reply-To: <20261120-vkms-all-config-v6-0-78ace90f4fc1@bootlin.com>

The configuration objects are now reference-counted and their lifetime is
driven by explicit get/put calls. Add tests aiming to spot UAF and leaks
using KASAN.

Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
 drivers/gpu/drm/vkms/tests/.kunitconfig          |  12 ++
 drivers/gpu/drm/vkms/tests/Makefile              |   3 +-
 drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c | 259 +++++++++++++++++++++++
 drivers/gpu/drm/vkms/vkms_drv.c                  |   3 +
 4 files changed, 276 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vkms/tests/.kunitconfig b/drivers/gpu/drm/vkms/tests/.kunitconfig
index 6a2d87068edc..b72899f06088 100644
--- a/drivers/gpu/drm/vkms/tests/.kunitconfig
+++ b/drivers/gpu/drm/vkms/tests/.kunitconfig
@@ -2,3 +2,15 @@ CONFIG_KUNIT=y
 CONFIG_DRM=y
 CONFIG_DRM_VKMS=y
 CONFIG_DRM_VKMS_KUNIT_TEST=y
+CONFIG_KASAN=y
+CONFIG_KASAN_INLINE=y
+CONFIG_KASAN_VMALLOC=y
+CONFIG_KUNIT_ALL_TESTS=n
+CONFIG_DEBUG_KMEMLEAK=y
+CONFIG_DEBUG_OBJECTS=y
+CONFIG_DEBUG_OBJECTS_FREE=y
+CONFIG_DEBUG_OBJECTS_TIMERS=y
+CONFIG_DEBUG_SLAB=y
+CONFIG_PAGE_POISONING=y
+CONFIG_PAGE_POISONING_NO_SANITY=n
+CONFIG_PAGE_POISONING_ZERO=y
diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
index d4d9ba8d4c54..a7810a12c9c8 100644
--- a/drivers/gpu/drm/vkms/tests/Makefile
+++ b/drivers/gpu/drm/vkms/tests/Makefile
@@ -3,6 +3,7 @@
 vkms-kunit-tests-y := \
 	vkms_config_test.o \
 	vkms_format_test.o \
-	vkms_color_test.o
+	vkms_color_test.o \
+	vkms_lifecycle_test.o \
 
 obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += vkms-kunit-tests.o
diff --git a/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c b/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c
new file mode 100644
index 000000000000..b319f6424285
--- /dev/null
+++ b/drivers/gpu/drm/vkms/tests/vkms_lifecycle_test.c
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include <kunit/test.h>
+#include <linux/string.h>
+
+#include "../vkms_config.h"
+#include "../vkms_drv.h"
+
+MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");
+
+#define LIFECYCLE_ITERATIONS 50
+#define STRESS_ITERATIONS    500
+
+static void vkms_lifecycle_test_create_destroy_default(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+		config = vkms_config_default_create(true, true, false, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_create_destroy_with_overlay(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+		config = vkms_config_default_create(true, true, true, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_create_destroy_with_pipeline(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+		config = vkms_config_default_create(true, true, true, true);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_create_destroy_minimal(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+		config = vkms_config_default_create(false, false, false, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_create_destroy_writeback(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < LIFECYCLE_ITERATIONS; i++) {
+		config = vkms_config_default_create(false, true, false, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_stress_many_cycles(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < STRESS_ITERATIONS; i++) {
+		config = vkms_config_default_create(true, true, true, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_interleaved_create_destroy(struct kunit *test)
+{
+	struct vkms_config *configs[5];
+	const char *new_name;
+	char name[32];
+	int ret, i, j;
+
+	for (j = 0; j < 20; j++) {
+		for (i = 0; i < 5; i++) {
+			configs[i] = vkms_config_default_create(i & 1, i & 2, i & 4, false);
+			KUNIT_ASSERT_NOT_ERR_OR_NULL(test, configs[i]);
+
+			snprintf(name, sizeof(name), "vkms-interleaved-%d", i);
+			new_name = kstrdup_const(name, GFP_KERNEL);
+			KUNIT_ASSERT_NOT_NULL(test, new_name);
+			kfree_const(configs[i]->dev_name);
+			configs[i]->dev_name = new_name;
+
+			ret = vkms_create(configs[i]);
+			KUNIT_ASSERT_EQ(test, ret, 0);
+		}
+
+		for (i = 4; i >= 0; i--) {
+			vkms_destroy(configs[i]);
+			vkms_config_destroy(configs[i]);
+		}
+	}
+}
+
+static void vkms_lifecycle_test_destroy_uncreated_device(struct kunit *test)
+{
+	struct vkms_config *config;
+
+	config = vkms_config_default_create(true, true, false, false);
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+	KUNIT_ASSERT_NULL(test, config->dev);
+
+	vkms_config_destroy(config);
+}
+
+static void vkms_lifecycle_test_double_destroy(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret;
+
+	config = vkms_config_default_create(true, true, false, false);
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+	ret = vkms_create(config);
+	KUNIT_ASSERT_EQ(test, ret, 0);
+
+	vkms_destroy(config);
+	KUNIT_ASSERT_NULL(test, config->dev);
+
+	vkms_config_destroy(config);
+}
+
+static void vkms_lifecycle_test_create_after_destroy(struct kunit *test)
+{
+	struct vkms_config *config;
+	int ret, i;
+
+	for (i = 0; i < 20; i++) {
+		config = vkms_config_default_create(true, true, false, false);
+		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+
+		ret = vkms_create(config);
+		KUNIT_ASSERT_EQ(test, ret, 0);
+
+		vkms_destroy(config);
+		vkms_config_destroy(config);
+	}
+}
+
+static void vkms_lifecycle_test_connector_ref_outlives_config(struct kunit *test)
+{
+	struct vkms_config_connector *connector_cfg;
+	struct vkms_config *config;
+
+	config = vkms_config_default_create(false, false, false, false);
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+	KUNIT_ASSERT_FALSE(test, list_empty(&config->connectors));
+
+	connector_cfg = list_first_entry(&config->connectors,
+					 struct vkms_config_connector, link);
+
+	/* Simulate the rmdir while DRM hold the device */
+	vkms_config_connector_get(connector_cfg);
+	vkms_config_destroy_connector(connector_cfg);
+	vkms_config_destroy(config);
+
+	/* The connector must survive, detached from the configuration. */
+	KUNIT_EXPECT_EQ(test, kref_read(&connector_cfg->refcnt), 1);
+	KUNIT_EXPECT_TRUE(test, list_empty(&connector_cfg->link));
+
+	/* Last reference: connector and configuration are freed here. */
+	vkms_config_connector_put(connector_cfg);
+}
+
+static void vkms_lifecycle_test_connector_static_drmm_release(struct kunit *test)
+{
+	struct vkms_config *config;
+
+	config = vkms_config_default_create(true, true, false, false);
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, config);
+
+	KUNIT_ASSERT_EQ(test, vkms_create(config), 0);
+
+	/* vkms_destroy() runs the drmm action, which frees and detaches the connector. */
+	vkms_destroy(config);
+	vkms_config_destroy(config);
+}
+
+static struct kunit_case vkms_lifecycle_test_cases[] = {
+	KUNIT_CASE(vkms_lifecycle_test_create_destroy_default),
+	KUNIT_CASE(vkms_lifecycle_test_create_destroy_with_overlay),
+	KUNIT_CASE(vkms_lifecycle_test_create_destroy_with_pipeline),
+	KUNIT_CASE(vkms_lifecycle_test_create_destroy_minimal),
+	KUNIT_CASE(vkms_lifecycle_test_create_destroy_writeback),
+	KUNIT_CASE(vkms_lifecycle_test_stress_many_cycles),
+	KUNIT_CASE(vkms_lifecycle_test_interleaved_create_destroy),
+	KUNIT_CASE(vkms_lifecycle_test_destroy_uncreated_device),
+	KUNIT_CASE(vkms_lifecycle_test_double_destroy),
+	KUNIT_CASE(vkms_lifecycle_test_create_after_destroy),
+	KUNIT_CASE(vkms_lifecycle_test_connector_ref_outlives_config),
+	KUNIT_CASE(vkms_lifecycle_test_connector_static_drmm_release),
+	{}
+};
+
+static struct kunit_suite vkms_lifecycle_test_suite = {
+	.name = "vkms-lifecycle",
+	.test_cases = vkms_lifecycle_test_cases,
+};
+
+kunit_test_suite(vkms_lifecycle_test_suite);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit test for VKMS device lifecycle, aiming to catch UAF and memory issues");
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 64c75b038869..a4bc3d02a6cd 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -18,6 +18,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_colorop.h>
+#include <kunit/visibility.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_shmem.h>
 #include <drm/drm_file.h>
@@ -250,6 +251,7 @@ static int __init vkms_init(void)
 
 	return 0;
 }
+EXPORT_SYMBOL_IF_KUNIT(vkms_create);
 
 void vkms_destroy(struct vkms_config *config)
 {
@@ -269,6 +271,7 @@ void vkms_destroy(struct vkms_config *config)
 
 	config->dev = NULL;
 }
+EXPORT_SYMBOL_IF_KUNIT(vkms_destroy);
 
 static void __exit vkms_exit(void)
 {

-- 
2.56.0


  parent reply	other threads:[~2026-11-20 18:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:58 [PATCH v6 00/43] VKMS: Introduce multiple configFS attributes Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 01/43] drm/vkms: Explicitly display connector status Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 02/43] drm/vkms: Lock the config dump against concurrent configfs changes Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 03/43] drm/vkms: Add new lines for configfs attributes Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 04/43] drm/drm_mode_config: Add helper to get plane type name Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 05/43] drm/blend: Get a rotation name from its bitfield Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 06/43] drm/tests: Add test cases for DRM rotation name Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 07/43] drm/drm_color_mgmt: Expose drm_get_color_encoding_name Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 08/43] drm/drm_color_mgmt: Expose drm_get_color_range_name Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 09/43] drm/connector: Export drm_get_colorspace_name Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 10/43] drm/drm_atomic_state_helper: Properly load default value for rotation Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 11/43] Documentation: ABI: vkms: Add current VKMS ABI documentation Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 12/43] drm/vkms: Reference-count vkms_config and vkms_config_connector Louis Chauvet
2026-11-20 17:58 ` Louis Chauvet [this message]
2026-11-20 17:58 ` [PATCH v6 14/43] drm/vkms: Add error handling in plane config creation Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 15/43] drm/vkms: Simplify plane_release code Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 16/43] drm/vkms: Explicitly display plane type Louis Chauvet
2026-11-20 17:58 ` [PATCH v6 17/43] drm/vkms: Use enabled/disabled instead of 1/0 for debug Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 18/43] drm/vkms: Introduce config for plane name Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 19/43] drm/vkms: Use plane folder name as " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 20/43] drm/vkms: Introduce config for plane rotation Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 21/43] drm/vkms: Introduce configfs " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 22/43] drm/vkms: Introduce config for plane color encoding Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 23/43] drm/vkms: Introduce configfs " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 24/43] drm/vkms: Introduce config for plane color range Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 25/43] drm/vkms: Introduce configfs " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 26/43] drm/vkms: Introduce config for plane format Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 27/43] drm/vkms: Introduce configfs " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 28/43] drm/vkms: Properly render plane using their zpos Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 29/43] drm/vkms: Introduce config for plane zpos property Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 30/43] drm/vkms: Introduce configfs " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 31/43] drm/vkms: Introduce back pointer to connector Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 32/43] drm/vkms: Introduce connector type Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 33/43] drm/vkms: Introduce configfs for " Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 34/43] drm/vkms: Rename vkms_connector_init to vkms_connector_init_static Louis Chauvet
2026-11-20 17:59 ` [PATCH v6 35/43] drm/vkms: Introduce config for connector supported colorspace Louis Chauvet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120-vkms-all-config-v6-13-78ace90f4fc1@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=airlied@gmail.com \
    --cc=corbet@lwn.net \
    --cc=demarchi@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=harry.wentland@amd.com \
    --cc=jose.exposito89@gmail.com \
    --cc=justinstitt@google.com \
    --cc=kory.maincent@bootlin.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=melissa.srw@gmail.com \
    --cc=morbo@google.com \
    --cc=mripard@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=oaroraetimis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sebastian.wick@redhat.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tzimmermann@suse.de \
    --cc=victoria@system76.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®