From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795197891; b=u6dVtOLSwtkAXLqnvruuWF7sfDKAvB6sR92O8Z3jiLKfmUNKCZICG/TgIXO94c9hlHa/ tIb90z/FH3cqLL+QS2Ef3DxAvb1sHUggtNoJ8Yf7LuGBKoOLn6RzgA1dNc//4kwymEFjn WBCk1pL5HWttFlQTi/l+w6253ksoBmq/TemEUsqJAPW82B/ySnDzsQc5e1K49Dr8PeJLi 9jDjv/MS44ft994z+4lltkVzflWnz5l24jO6ZN+We0JqhmvrBWF3tu2sb9lzA9CDKMhU1 vFjCRVYCgwZQTgOB+WfURMGd4/owqygU7s1lRXq4Xcg9ktKwEnv4AWetoIgCWZ1jh2w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795197891; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Last-TLS-Session-Version; bh=PsycCMPqP2h+PaWMIfIr9kQkEPdFW8dS26pMRsWGeu4=; b=fxzjhlM6rs0elcIbJqgfpVFySYwnaOQfJfEzYvolkKMmh4F+sRR3uc9XDYFqbP5472m7 uUDT1Ia2DmeuXjXl9IU+9eQH0mzovQo4kUMc70l9d2NmPVvcENhZZ/lcpwOpo3avih9vI AbajXIhnC10uKYp5VMSlfGD4db7rFJD2J3gsdNdaZI6oSRk8SYMOqp8hafU+InFIlwHS2 owFIqUV0sEVxavBOCdqds6OoTwD94LEURP5+WcaiDplbIdVlT0WAQgQmLOOEHmdamVdJR yYDEQdtHqh72xFR/dKXMxYKd5CC0ZdACXER6jcNNIbNaDjEHjSQUPDvZgMKyXt6SG+w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=rTARKxv6; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0C6160A2609; Fri, 20 Nov 2026 18:04:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F0C6160A2609 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=rTARKxv6 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id CCF544E41690; Fri, 20 Nov 2026 18:04:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9AE44601B9; Fri, 20 Nov 2026 18:04:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4B47D11BC08D7; Fri, 20 Nov 2026 19:04:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795197886; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PsycCMPqP2h+PaWMIfIr9kQkEPdFW8dS26pMRsWGeu4=; b=rTARKxv6WPST9JYoNWQvQg03+SSepjTOOYRXkQjY1a7QR5ZPJGRHS6LRQSJIm9aL/fkD50 +9fQqG9VvikD/Huk4qkVVbYF6S1Qmp3K7vQ4joJ4YGlE5U2nAdOaR/U0IbyZtjI10X47bi G2rUcGcrOb79eCsPD1c0y91gojVozMPvAcwaem/IrWpZbHlKM/8I3Mkaqr92RSmXx71Nus 4rkmamFxjss43zSL1U0efCguM4uyFesqzpE/8mfc7v6/687RV0+zrY48dbEjKHvvbK4hut FBRrhNMHwyw2hLxjiWBPEDR2bniGZxslKVPSZ25fLBPvypMzNbXhfyrFvzpj1g== From: Louis Chauvet Date: Fri, 20 Nov 2026 18:59:07 +0100 Subject: [PATCH v6 25/43] drm/vkms: Introduce configfs for plane color range X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261120-vkms-all-config-v6-25-78ace90f4fc1@bootlin.com> References: <20261120-vkms-all-config-v6-0-78ace90f4fc1@bootlin.com> In-Reply-To: <20261120-vkms-all-config-v6-0-78ace90f4fc1@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet , Oarora Etimis , Harry Wentland , Lucas De Marchi , =?utf-8?q?Ville_Syrj=C3=A4l=C3=A4?= , Randy Dunlap , Nick Desaulniers , Louis Chauvet , Shuah Khan , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: Luca Ceresoli , Kory Maincent , sebastian.wick@redhat.com, victoria@system76.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Simona Vetter , llvm@lists.linux.dev X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=7502; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=tYjvzaGGGCxX2XzUqQ7y+eoVRW5Vjp3caDpHYFZb4g8=; b=owEBiQJ2/ZANAwAIASCtLsZbECziAcsmYgBrAIsA6xS00mqmTrUsAP4EuvReapA5vaAeaEr/U YxNx13Il+SJAk8EAAEIADkWIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCawCLABsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQIK0uxlsQLOIwTw//RffZ+x2Nx9ao0GqRVsTE3bov+mXZdWn tY1in/iGtOrm6kssOfj27rBaSzTO/WM+smgfEJdhts4kRH8/01qNRASOv/YD5WX3ijnrThVtgIm oZRVkI0MtvFn2eY4E2fExYbTW1ncZut82+AzKuBwgycVg4lwphDFbZEJdWhsRcQLYcV9J15R6XS Pt+B+nj/Z4T/wHJYESGyUKULFcTC4OlOS0iLIlUACBwDLmzwIciIPK9H5VYEIwWyGOYcyaBg+TN hbV32T6LTcCVXzNPAPoQbSJH5edDKAOxxQkQ6ny5gTf44wvSLmAU7yGKQSGY+uCp1vm8bCh74E7 YpyWvhnTGLT3pe73gdtOXVsmk+O9+UyinFcUCmRf2pkTR1b3S/fUpmCXYC/paBlvSgxORHokVre 1YHxrXrZJlC83QO2kn0htzZlArWLpvLvKYiPJtwNcsuUG5u6epGBsRyCsSBcGA828NpmVxFj5pR xfulUooAvPnUO4Ej3bQwM8gejUW5OBHamZz1qXOIbusOHl/ORgY7O4zs09Z/mgJOe5+qCvkb8R2 FjkIkBAWaA7ibC0IZc9sTLKsIxVOejM05GFAKZunFJcWxn4E8ONlF8bRQPzJFKIO42CZkfjEnhy muWIsI3kH94nMOj8gqiYPw11WSj/IdZJv1mo6azfEyPo14V64dYU= X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 To allows the userspace to test many hardware configuration, introduce a new interface to configure the available color ranges per planes. VKMS supports multiple color ranges, so the userspace can choose any combination. The supported color ranges are configured by writing a color range bitmask to the file `supported_color_ranges` and the default color range is chosen by writing a color range bitmask to `default_color_range`. Signed-off-by: Louis Chauvet --- Documentation/ABI/testing/configfs-vkms | 19 +++++++ Documentation/gpu/vkms.rst | 10 +++- drivers/gpu/drm/vkms/vkms_configfs.c | 91 +++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/configfs-vkms b/Documentation/ABI/testing/configfs-vkms index 592df5602065..16a44cc60e4a 100644 --- a/Documentation/ABI/testing/configfs-vkms +++ b/Documentation/ABI/testing/configfs-vkms @@ -145,6 +145,25 @@ Description: must be a single bit: 1 - YCBCR_BT601, 2 - YCBCR_BT709, 4 - YCBCR_BT2020. +What: /sys/kernel/config/vkms//planes//supported_color_ranges +Date: Nov 2025 +Contact: dri-devel@lists.freedesktop.org +Description: + Available color ranges for the plane, as a bitmask: + 0x1 - DRM_COLOR_YCBCR_LIMITED_RANGE, + 0x2 - DRM_COLOR_YCBCR_FULL_RANGE. The value may be + written in decimal or hexadecimal (with a 0x prefix) and + is read back as a decimal number. + +What: /sys/kernel/config/vkms//planes//default_color_range +Date: Nov 2025 +Contact: dri-devel@lists.freedesktop.org +Description: + Default color range presented to userspace. Value is a + decimal number with exactly one bit set: 1 - + DRM_COLOR_YCBCR_LIMITED_RANGE, 2 - + DRM_COLOR_YCBCR_FULL_RANGE. + What: /sys/kernel/config/vkms//planes//possible_crtcs Date: Nov 2025 Contact: dri-devel@lists.freedesktop.org diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 7206cd2b231a..7e8f4fe3b392 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -87,7 +87,7 @@ Start by creating one or more planes:: sudo mkdir /config/vkms/my-vkms/planes/plane0 -Planes have 5 configurable attributes: +Planes have 7 configurable attributes: - type: Plane type: 0 overlay, 1 primary, 2 cursor (same values as those exposed by the "type" property of a plane) @@ -98,10 +98,16 @@ Planes have 5 configurable attributes: supported_rotations. - supported_color_encodings: Available encodings for a plane, as a bitmask: 0x01 YCBCR_BT601, 0x02 YCBCR_BT709, 0x04 YCBCR_BT2020 (same values as those exposed - by the COLOR_ENCODING property of a plane). If set, supported_color_range + by the COLOR_ENCODING property of a plane). If set, supported_color_ranges must be set too. - default_color_encoding: Default color encoding presented to the userspace, same values as supported_color_encodings +- supported_color_ranges: Available color range for a plane, as a bitmask: + 0x1 DRM_COLOR_YCBCR_LIMITED_RANGE, 0x2 DRM_COLOR_YCBCR_FULL_RANGE (same values as + those exposed by the COLOR_RANGE property of a plane). If set, supported_color_encoding + must be set too. +- default_color_range: Default color range presented to the userspace, same + values as supported_color_ranges Continue by creating one or more CRTCs:: diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c index 809daec90ecf..910b69f532f8 100644 --- a/drivers/gpu/drm/vkms/vkms_configfs.c +++ b/drivers/gpu/drm/vkms/vkms_configfs.c @@ -17,6 +17,13 @@ BIT(DRM_COLOR_YCBCR_BT709) | \ BIT(DRM_COLOR_YCBCR_BT2020)) +/** + * VKMS_SUPPORTED_COLOR_RANGES - Bitmask of all supported color ranges in VKMS + */ +#define VKMS_SUPPORTED_COLOR_RANGES ( \ + BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | \ + BIT(DRM_COLOR_YCBCR_FULL_RANGE)) + /* To avoid registering configfs more than once or unregistering on error */ static bool is_configfs_registered; @@ -410,6 +417,86 @@ static ssize_t plane_default_rotation_store(struct config_item *item, return count; } +static ssize_t plane_supported_color_ranges_show(struct config_item *item, char *page) +{ + struct vkms_configfs_plane *plane = plane_item_to_vkms_configfs_plane(item); + unsigned int supported_color_ranges; + + scoped_guard(mutex, &plane->dev->config->lock) + supported_color_ranges = vkms_config_plane_get_supported_color_ranges(plane->config); + + return sprintf(page, "%u\n", supported_color_ranges); +} + +static ssize_t plane_supported_color_ranges_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane = plane_item_to_vkms_configfs_plane(item); + int ret; + unsigned int val = 0; + + ret = kstrtouint(page, 0, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~VKMS_SUPPORTED_COLOR_RANGES) + return -EINVAL; + /* Should at least provide one color range */ + if ((val & VKMS_SUPPORTED_COLOR_RANGES) == 0) + return -EINVAL; + + scoped_guard(mutex, &plane->dev->config->lock) { + if (plane->dev->enabled) + return -EBUSY; + + vkms_config_plane_set_supported_color_ranges(plane->config, val); + } + + return count; +} + +static ssize_t plane_default_color_range_show(struct config_item *item, char *page) +{ + struct vkms_configfs_plane *plane = plane_item_to_vkms_configfs_plane(item); + unsigned int default_color_range; + + scoped_guard(mutex, &plane->dev->config->lock) + default_color_range = vkms_config_plane_get_default_color_range(plane->config); + + return sprintf(page, "%lu\n", BIT(default_color_range)); +} + +static ssize_t plane_default_color_range_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_plane *plane = plane_item_to_vkms_configfs_plane(item); + int ret, val = 0; + + ret = kstrtouint(page, 10, &val); + if (ret) + return ret; + + /* Should be a supported value */ + if (val & ~VKMS_SUPPORTED_COLOR_RANGES) + return -EINVAL; + + if (!is_power_of_2(val)) + return -EINVAL; + + /* Convert bit position to the proper enum value */ + val = ffs(val) + DRM_COLOR_YCBCR_LIMITED_RANGE - 1; + + scoped_guard(mutex, &plane->dev->config->lock) { + if (plane->dev->enabled) + return -EBUSY; + + vkms_config_plane_set_default_color_range(plane->config, val); + } + + return count; +} + static ssize_t plane_supported_color_encodings_show(struct config_item *item, char *page) { struct vkms_configfs_plane *plane = plane_item_to_vkms_configfs_plane(item); @@ -492,6 +579,8 @@ static ssize_t plane_default_color_encoding_store(struct config_item *item, CONFIGFS_ATTR(plane_, type); CONFIGFS_ATTR(plane_, supported_rotations); CONFIGFS_ATTR(plane_, default_rotation); +CONFIGFS_ATTR(plane_, supported_color_ranges); +CONFIGFS_ATTR(plane_, default_color_range); CONFIGFS_ATTR(plane_, supported_color_encodings); CONFIGFS_ATTR(plane_, default_color_encoding); @@ -499,6 +588,8 @@ static struct configfs_attribute *plane_item_attrs[] = { &plane_attr_type, &plane_attr_supported_rotations, &plane_attr_default_rotation, + &plane_attr_supported_color_ranges, + &plane_attr_default_color_range, &plane_attr_supported_color_encodings, &plane_attr_default_color_encoding, NULL, -- 2.56.0