From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrei Simion <andrei.simion@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [RFC PATCH 0/2] ASoC: atmel: mchp-spdifrx: Fix format handling and MR configuration
Date: Fri, 20 Nov 2026 10:59:37 +0700 [thread overview]
Message-ID: <20261120035939.12774-1-phucduc.bui@gmail.com> (raw)
From: bui duc phuc <phucduc.bui@gmail.com>
Hi all,
This series addresses two issues in the mchp-spdifrx driver: inconsistent
handling of the 16-bit big-endian format and MR register updates
in hw_params().
This series was developed on top of the previous series:
https://lore.kernel.org/all/20261119103413.31729-1-phucduc.bui@gmail.com/
Since this is an RFC series, I have kept it separate rather than including
these changes in the previous series. The previous series should be
applied first to avoid conflicts when applying these patches.
The changes are not hardware-tested, and I would appreciate feedback from
someone with access to the hardware.
In particular, the MR register change needs verification. If the current
code works as expected, the existing full-register write in hw_params()
may be intentional, and the actual issue could instead be the default
configuration in dai_probe().
For the 16-bit big-endian format, the current format check is clearly
inconsistent with MCHP_SPDIF_FORMATS. However, it is also possible that
the advertised format should be corrected instead of changing the check
in hw_params(). Furthermore, I could not find datasheet documentation
confirming support for big-endian 16-bit and 20-bit formats.
Therefore, hardware testing is needed to determine whether these changes
are correct.
Compile-tested only.
Best regards,
Phuc
bui duc phuc (2):
ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check
ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params
sound/soc/atmel/mchp-spdifrx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.43.0
next reply other threads:[~2026-11-20 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 3:59 phucduc.bui [this message]
2026-11-20 3:59 ` [RFC PATCH 1/2] ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check phucduc.bui
2026-11-20 3:59 ` [RFC PATCH 2/2] ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120035939.12774-1-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®