From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.173 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795154977; b=Ui5pON39nda1p7xf3J0oLLWYJpfI46aCkWbqfId4zRh+Ndo+OiVvzo3XsWE1Vp+UTqPp h1bVC//KmAUew01N8tzIHC+Jk7yWTzCFVHo1C1PmNZyeOSqX8mPvan8JQFCy06r3dVvmP VTeIv8tuq23tpavWP82zX8CeZqIrGzA7P4E8UE1+Dnn7WkN87nn3iofjik3GHyLIlJ9au ykM5FaPlep0sAGbHAcZOEAzBR22Zx1wvmc1XpFIQFlwP7lY8efYdXKca6LmKdSEG4KRWZ hjfaUVXPVVHdO1acNcMQd53apweoQn7UGjmnNPTvJcij0OMWgAhsIEoziOS4DJAfEZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795154977; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=pazKh6DOiqyGRyM8W6LynGdwm0L0tbIyWQaJbyYaTnU=; b=BAe3VlDNnSPxCFp9PXp81zz2phdwqkmn7RXZedvriyL53JfgTpm9DDFD/Yyvn54PQMBl KwEqzbHmSX8eDaVej1VJAL/FvJMQG9PtjvHkHQ5h5uWAW74l3wykA4Cwhso2Y3v2tlLQR 7djUvKDX7kqAZflKoXT/OJ8A3O4KHP7SfjanRe1GRXxIgXAcpTjexfQZoUvcm+3f98BRF FCDjS/Bvnk0hr/IpAmHEcOLhhVUnaklavBcS8sVbANuwmvbUS6nxeLiZj9iL6KqT1vgJx 60hrA5vU+3O3rDa01TaiFfXTWwe7GQtFalRmPcMnY//BWUQGx0R2VeVpmojp5al/8Vw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=T6iJuHPR; arc=none smtp.remote-ip=74.125.82.173 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5BA606A528 for ; Fri, 20 Nov 2026 06:09:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7E5BA606A528 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=T6iJuHPR Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-38587f3de36so572477eec.0 for ; Thu, 19 Nov 2026 22:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795154976; x=1795759776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pazKh6DOiqyGRyM8W6LynGdwm0L0tbIyWQaJbyYaTnU=; b=T6iJuHPR/Sng6NdMz5T8pKivDBJYsFFYVpBjArLgNAckPgMMnHKhx40t2YMTRhEYtx 5rVoDcRcWwvo0B8fDLqdGO6nQgM2DAdXnHsWbSUVv6Hi+r0KJqoCdiAv8uujCBqr1x6f dX2E9ErPPMxyKkpu4R4FLnrDK3ZFd1sQxHw70gsxT74MrwkDOgalG8+eK7qWKElhaFV4 Gst1n0+toVruNTU9zNlJmY6VprlDqC64zEOy/69EeSk51M/N5cc7rl9WygeOVqUJUpUl r/NcRf2nZVDOmK2iMi3erHREloz+1oLgTOn4KU75TxLxsXB27eR3xpJawbhbyGE7H2bu 3LNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795154976; x=1795759776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pazKh6DOiqyGRyM8W6LynGdwm0L0tbIyWQaJbyYaTnU=; b=F6Es0VYbGCiy8SZsXbtE3hTnrI1YbMSeI7QtYKVx5pBfBNdMbktckvciKrvt2KzR3p Bj9ov0hFxscJzcNIEN9WF5uuFzYSOAaz7aZK3lgA+Av6SnGml399WduDyl4HsHr3+rhL tEZnAPKR97OvwiqiTUUCG+pP0O1kGzQNfQHxogm1OOyCupLJtBzxNDkgA9sk/wNjbADv 2CoWsqaF3/9EUDwOCnKfZEymHv1j0a6KPnpeHfAgBCG3+YbVGHAclwpVNk+9IfhuIusq WVs4/WzfozNlGcsiVz7dVY4zisU0lQOJpUpp90crdlC7JcILJgXxA3YLrW9yF7GUZgUZ 0saA== X-Forwarded-Encrypted: i=1; AL+hErFfz2fLqeDVem5yepb5s2TgPHVBRGZwBWCxQMc8lMQHl/LkF9cQg0JJSzmgCKXQBqay3VOcmZMERcH4Svg=@vger.kernel.org X-Gm-Message-State: APuU4Z/Pb/dq0au0/azld769oCZvCfYEA3QuK5lJMlUKyFI3vH/pxYdA V3qXCzqcRGr8XGUYI0NtyQ/M6m62BEFfOBivj5T/q303v4yJi7MJP+bG X-Gm-Gg: AZFdTZe8dAoPgo1uX2BVJkzZ3sXJqFaUvXd9dzYm1T47gavCa3GPlwZ5SoJcDkcb7qC 1Ct9T8j0UjEauJbWfukUp7yNenHbF6sas6r99QpK9PK7mTCJUIcGxAjROib/qld4DMzKUlOju0c LAZ2EvcGqYR9z4lXnraHCJcfIDBdjYt4RZ8i0id2+GuLDFuOvpvn8lXaNWopM32Vsa5IYCLHidj TC4B9EYg8CeSFPbX8H06Xi0/9BWhd/VzDuAHLM646Q0NHdW37okEr222Sw2K83UD3mbKdoFq314 pxQdReJeGr2WcUXycEtL+EO1XADdq0q1tW8P55754sVcpna4Ui9zyhU5YgFAGowCzYWSwV/ZkXQ KlKTI5Yq+UGrNZh8hYb4dxJxutLGWiLYdad1qHz1PgusGFsFgOy9ccl+mZobiRT5AFWxLkn3u9X liM82nM0AmdOUdDZPtfZw3xiRQFj02AqeYr0kPz2VgZdXuIOt1QBuShIiHFro3TBRJzhxAX+ZwB l4pGplxx02PW9NsQWuKxfBbilarbdqJASqwV7R7ruOd+vvXLebYoasENVd88jeTW88Pxfo7KF2R NsUWa9B9GVWJWYXHl5R1 X-Received: by 2002:a05:7300:ce11:b0:381:6b5:56e6 with SMTP id 5a478bee46e88-3856f65aed4mr1730052eec.16.1795154975566; Thu, 19 Nov 2026 22:09:35 -0800 (PST) Received: from a1-free ([161.33.196.121]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385677c0c1dsm4609725eec.21.2026.11.19.22.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 22:09:35 -0800 (PST) From: TAKANO Mitsuhiro To: linux-perf-users@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim Cc: Ian Rogers , James Clark , John Garry , linux-arm-kernel@lists.infradead.org, Ilkka Koskinen , linux-kernel@vger.kernel.org, TAKANO Mitsuhiro , Will Deacon , Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter Subject: [PATCH v11 0/2] perf jevents: Fail the build on a key the tables may not carry Date: Fri, 20 Nov 2026 06:09:29 +0000 Message-ID: <20261120060931.711483-1-takano32@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261113032927.634183-1-takano32@gmail.com> References: <20261113032927.634183-1-takano32@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit v11. The shape is James's: the check is not an option any more, so a typo in a key stops the build instead of being dropped without a word. --check is gone. Every event and metric table goes through JsonEvent.__init__, so the keys of each object are compared there with _valid_keys. No new option, no second walk over the directory, and no way to run the generator without the check. (metricgroups.json is a plain dictionary of group names and is not checked.) The test is jevents_bad_key.sh and checks the failing case only. 1/2 is the prerequisite James asked for: the tree carries 19 objects with a key the tables may not carry, so 2/2 cannot land on an unfixed tree. It is the two fixes posted on their own, squashed. The AMD one went into perf-tools-next on 11 November and the arm64 v2 has Ilkka's Acked-by, so if both are in your tree, 2/2 is all that is left; if the AMD one is in but the arm64 one is not, 1/2 will need -3 or its AMD hunks dropped. Measured: on 1/2 + 2/2, the generator run over all architectures, over x86 alone and over arm64 alone exits 0. Putting BriefDescript6ion back into one AMD table makes the x86 run exit 1 with "jevents.py: : unknown key(s): ['BriefDescript6ion']"; the arm64 run does not read the x86 tables and still exits 0. TAKANO Mitsuhiro (2): perf vendor events: Fix misspelled keys in the event tables perf jevents: Fail the build on a key the tables may not carry .../arch/arm64/ampere/ampereonex/mmu.json | 32 ++++----- .../pmu-events/arch/x86/amdzen4/cache.json | 2 +- .../arch/x86/amdzen5/load-store.json | 2 +- .../arch/x86/amdzen6/load-store.json | 2 +- tools/perf/pmu-events/jevents.py | 70 +++++++++++++++---- tools/perf/tests/shell/jevents_bad_key.sh | 43 ++++++++++++ 6 files changed, 117 insertions(+), 34 deletions(-) create mode 100755 tools/perf/tests/shell/jevents_bad_key.sh base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb -- 2.53.0