mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Keisuke Tsukuda <catnyaaan@outlook.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"syzbot+a83a5a1ba9ff57935171@syzkaller.appspotmail.com"
	<syzbot+a83a5a1ba9ff57935171@syzkaller.appspotmail.com>,
	"syzbot+d31109047baed8f3b590@syzkaller.appspotmail.com"
	<syzbot+d31109047baed8f3b590@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2 1/2] usb: gadget: composite: avoid warning on aborted delayed status
Date: Fri, 20 Nov 2026 12:52:20 +0100	[thread overview]
Message-ID: <2026112008-hungry-scorer-f2b0@gregkh> (raw)
In-Reply-To: <20260908203348.95825-2-tkdkei@outlook.jp>

On Tue, Sep 08, 2026 at 08:33:53PM +0000, Keisuke Tsukuda wrote:
> A SET_CONFIGURATION request that disables the current configuration, or a
> disconnect, can abort a control transfer whose status stage was delayed by
> a function driver. The asynchronous function work can nevertheless finish
> later and call usb_composite_setup_continue() after reset_config() has
> cleared delayed_status.
> 
> This is an expected consequence of aborting the old control transfer, and
> does not require a kernel warning. Keep the diagnostic available under
> dynamic debug and ignore the obsolete completion as before.
> 
> Fixes: 2bac51a1827a ("usb: gadget: composite: reset delayed_status on reset_config")
> Reported-by: syzbot+a83a5a1ba9ff57935171@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=a83a5a1ba9ff57935171
> Signed-off-by: Keisuke Tsukuda <tkdkei@outlook.jp>
> ---
>  drivers/usb/gadget/composite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index df39e34..1b22381 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -2740,7 +2740,7 @@ void usb_composite_setup_continue(struct usb_composite_dev *cdev)
>  	spin_lock_irqsave(&cdev->lock, flags);
>  
>  	if (cdev->delayed_status == 0) {
> -		WARN(cdev, "%s: Unexpected call\n", __func__);
> +		DBG(cdev, "%s: Ignoring obsolete call\n", __func__);
>  
>  	} else if (--cdev->delayed_status == 0) {
>  		DBG(cdev, "%s: Completing delayed status\n", __func__);
> -- 
> 2.50.1 (Apple Git-155)
> 

Please use Linux to send this, it's corrupted as-is for some reason.

greg k-h

  reply	other threads:[~2026-11-20 11:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 20:33 [PATCH v2 0/2] usb: gadget: avoid warnings during configuration transitions Keisuke Tsukuda
2026-09-08 20:33 ` [PATCH v2 1/2] usb: gadget: composite: avoid warning on aborted delayed status Keisuke Tsukuda
2026-11-20 11:52   ` Greg Kroah-Hartman [this message]
2026-09-08 20:33 ` [PATCH v2 2/2] usb: gadget: f_mass_storage: ignore class requests while inactive Keisuke Tsukuda
2026-09-09  1:49   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112008-hungry-scorer-f2b0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=catnyaaan@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+a83a5a1ba9ff57935171@syzkaller.appspotmail.com \
    --cc=syzbot+d31109047baed8f3b590@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®