From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrei Simion <andrei.simion@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 2/3] ASoC: atmel: mchp-spdiftx: Use devm helpers for runtime PM
Date: Fri, 20 Nov 2026 16:43:53 +0700 [thread overview]
Message-ID: <20261120094354.6814-3-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261120094354.6814-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Use devm_pm_runtime_enable() and a devm action to handle runtime PM
cleanup automatically.
This removes the manual runtime PM cleanup from the probe error
paths and the remove callback.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/atmel/mchp-spdiftx.c | 46 ++++++++++++++++++----------------
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/sound/soc/atmel/mchp-spdiftx.c b/sound/soc/atmel/mchp-spdiftx.c
index 6ab32f0b8b8e..b034bd46cd5a 100644
--- a/sound/soc/atmel/mchp-spdiftx.c
+++ b/sound/soc/atmel/mchp-spdiftx.c
@@ -778,6 +778,15 @@ static const struct dev_pm_ops mchp_spdiftx_pm_ops = {
NULL)
};
+/* Runtime suspend the device on cleanup if necessary */
+static void mchp_spdiftx_runtime_suspend_action(void *data)
+{
+ struct device *dev = data;
+
+ if (!pm_runtime_status_suspended(dev))
+ mchp_spdiftx_runtime_suspend(dev);
+}
+
static int mchp_spdiftx_probe(struct platform_device *pdev)
{
struct mchp_spdiftx_dev *dev;
@@ -836,11 +845,22 @@ static int mchp_spdiftx_probe(struct platform_device *pdev)
dev->regmap = regmap;
platform_set_drvdata(pdev, dev);
- pm_runtime_enable(dev->dev);
+ err = devm_add_action(dev->dev, mchp_spdiftx_runtime_suspend_action,
+ dev->dev);
+ if (err)
+ return err;
+
+ err = devm_pm_runtime_enable(dev->dev);
+ if (err)
+ return err;
if (!pm_runtime_enabled(dev->dev)) {
err = mchp_spdiftx_runtime_resume(dev->dev);
- if (err)
+ if (err) {
+ devm_remove_action(dev->dev,
+ mchp_spdiftx_runtime_suspend_action,
+ dev->dev);
return err;
+ }
}
dev->playback.addr = (dma_addr_t)mem->start + SPDIFTX_CDR;
@@ -849,7 +869,7 @@ static int mchp_spdiftx_probe(struct platform_device *pdev)
err = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
if (err) {
dev_err(&pdev->dev, "failed to register PMC: %d\n", err);
- goto pm_runtime_suspend;
+ return err;
}
err = devm_snd_soc_register_component(&pdev->dev,
@@ -857,32 +877,14 @@ static int mchp_spdiftx_probe(struct platform_device *pdev)
&mchp_spdiftx_dai, 1);
if (err) {
dev_err(&pdev->dev, "failed to register component: %d\n", err);
- goto pm_runtime_suspend;
+ return err;
}
return 0;
-
-pm_runtime_suspend:
- if (!pm_runtime_status_suspended(dev->dev))
- mchp_spdiftx_runtime_suspend(dev->dev);
- pm_runtime_disable(dev->dev);
-
- return err;
-}
-
-static void mchp_spdiftx_remove(struct platform_device *pdev)
-{
- struct mchp_spdiftx_dev *dev = platform_get_drvdata(pdev);
-
- if (!pm_runtime_status_suspended(dev->dev))
- mchp_spdiftx_runtime_suspend(dev->dev);
-
- pm_runtime_disable(dev->dev);
}
static struct platform_driver mchp_spdiftx_driver = {
.probe = mchp_spdiftx_probe,
- .remove = mchp_spdiftx_remove,
.driver = {
.name = "mchp_spdiftx",
.of_match_table = mchp_spdiftx_dt_ids,
--
2.43.0
next prev parent reply other threads:[~2026-11-20 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 9:43 [PATCH 0/3] ASoC: atmel: mchp-spdiftx: Improve probe and PM handling phucduc.bui
2026-11-20 9:43 ` [PATCH 1/3] ASoC: atmel: mchp-spdiftx: Improve probe error handling phucduc.bui
2026-11-20 9:43 ` phucduc.bui [this message]
2026-11-20 9:43 ` [PATCH 3/3] ASoC: atmel: mchp-spdiftx: Move IRQ request after runtime PM setup phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120094354.6814-3-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®