From: Ibrahim Elshahed <lshahed@amazon.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Josh Don <joshdon@google.com>, <linux-kernel@vger.kernel.org>,
<nh-open-source@amazon.com>, Fernand Sieber <sieberf@amazon.com>,
Roman Kagan <rkagan@amazon.de>
Subject: Re: [PATCH 2/2] sched/core: Don't skip a pending core-wide pick on idle re-entry
Date: Fri, 20 Nov 2026 10:41:08 +0000 [thread overview]
Message-ID: <20261120104108.73673-1-lshahed@amazon.de> (raw)
In-Reply-To: <20261118144027.GZ1779021@noisy.programming.kicks-ass.net>
On Wed, Nov 18, 2026 at 03:40:41PM +0100, Peter Zijlstra wrote:
> I'm not sure I understand the rq->core_pick condition here. We already
> have !rq->nr_running, and if we have rq->core_pick, then nr_running must
> be non-zero, right?
Right, the check only mattered without patch 1. I'll drop it in v2 and
keep only core_forceidle_count.
next prev parent reply other threads:[~2026-11-20 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:27 [PATCH 0/2] sched/core: Fix stale core_pick and forced idle after SM_IDLE fast path Ibrahim Elshahed
2026-11-17 14:27 ` [PATCH 1/2] sched/core: Clear a stale rq->core_pick after dequeue Ibrahim Elshahed
2026-11-17 14:27 ` [PATCH 2/2] sched/core: Don't skip a pending core-wide pick on idle re-entry Ibrahim Elshahed
2026-11-18 14:40 ` Peter Zijlstra
2026-11-20 10:41 ` Ibrahim Elshahed [this message]
2026-11-17 14:27 ` [PATCH 0/2] sched/core: Fix stale core_pick and forced idle after SM_IDLE fast path Ibrahim Elshahed
2026-11-18 14:41 ` Peter Zijlstra
2026-11-20 10:41 ` Ibrahim Elshahed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120104108.73673-1-lshahed@amazon.de \
--to=lshahed@amazon.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nh-open-source@amazon.com \
--cc=peterz@infradead.org \
--cc=rkagan@amazon.de \
--cc=rostedt@goodmis.org \
--cc=sieberf@amazon.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®