mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yang Siyuan <hsyysy@163.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: phy: generic: request the vbus supply only when it is described
Date: Fri, 20 Nov 2026 16:38:31 +0100	[thread overview]
Message-ID: <2026112011-macaroni-manatee-e057@gregkh> (raw)
In-Reply-To: <20261117094539.13527-1-hsyysy@163.com>

On Tue, Nov 17, 2026 at 05:45:39PM +0800, Yang Siyuan wrote:
> usb_phy_gen_create_phy() unconditionally asks for an exclusive "vbus"
> regulator. The legacy usb_phy_generic platform device registered by USB
> glue drivers (e.g. sunxi MUSB) has no firmware node, so the lookup ends
> up in the dummy-regulator path and the regulator core warns:
> 
>   usb_phy_generic usb_phy_generic.1.auto: dummy supplies not allowed for
>   exclusive requests (id=vbus)
> 
> Only issue the request when the device firmware actually describes a
> vbus-supply, and keep treating -ENODEV as "not present".
> 
> Fixes: 03e607cbb293 ("usb: phy: generic: Get the vbus supply")
> 
> Signed-off-by: Yang Siyuan <hsyysy@163.com>

No blank line after the Fixes: tag please.

thanks,

greg k-h

      parent reply	other threads:[~2026-11-20 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:19 [PATCH RESEND] " Yang Siyuan
2026-11-17  9:45 ` [PATCH v2] " Yang Siyuan
2026-11-18 11:23   ` Freimut Diener
2026-11-20 15:38   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112011-macaroni-manatee-e057@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=hsyysy@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®