From: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
To: perex@perex.cz, tiwai@suse.de
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Subject: [PATCH] ALSA: pcm: Fix incorrect numerator selection in snd_interval_ratden()
Date: Fri, 20 Nov 2026 11:36:32 +0000 [thread overview]
Message-ID: <20261120113632.2761-1-sreekuttan2156239@gmail.com> (raw)
When the calculated numerator is smaller than num_min, the
function incorrectly sets it to num_max instead of num_min.
This can produce an invalid interval by making the calculated
minimum numerator larger than the maximum numerator, even when
a valid range exists.
Set the numerator to num_min when it falls below the minimum
allowed value. This allows the function to calculate the correct
lower bound and prevents valid intervals from being rejected.
Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
---
sound/core/pcm_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index bb16738bb591..65c7472ef22e 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -966,7 +966,7 @@ static int snd_interval_ratden(struct snd_interval *i,
if (num > rats[k].num_max)
continue;
if (num < rats[k].num_min)
- num = rats[k].num_max;
+ num = rats[k].num_min;
else {
unsigned int r;
r = (num - rats[k].num_min) % rats[k].num_step;
--
2.55.0
reply other threads:[~2026-11-20 11:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120113632.2761-1-sreekuttan2156239@gmail.com \
--to=sreekuttan2156239@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®