From: Avi Weiss <thnkslprpt@gmail.com>
To: rostedt@goodmis.org, mhiramat@kernel.org
Cc: mathieu.desnoyers@efficios.com,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
Avi Weiss <thnkslprpt@gmail.com>
Subject: [PATCH] tracing: Restore custom event creation selector
Date: Fri, 20 Nov 2026 14:28:38 +0200 [thread overview]
Message-ID: <20261120122837.1597798-2-thnkslprpt@gmail.com> (raw)
The custom event generator undefines CREATE_CUSTOM_TRACE_EVENTS to avoid
recursion, but restores a different macro - CREATE_CUSTOM_TRACE_POINTS
when processing is complete. A second custom event header included under
the same selector is then skipped, leaving its generated update helper
undefined.
Likely a simple copy-paste error.
Restore CREATE_CUSTOM_TRACE_EVENTS after processing so subsequent custom
event headers can generate their definitions.
Fixes: 3a73333fb370f ("tracing: Add TRACE_CUSTOM_EVENT() macro")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
include/trace/define_custom_trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/define_custom_trace.h b/include/trace/define_custom_trace.h
index 5827a4c92c744..177c628f2d567 100644
--- a/include/trace/define_custom_trace.h
+++ b/include/trace/define_custom_trace.h
@@ -72,6 +72,6 @@
#endif
/* We may be processing more files */
-#define CREATE_CUSTOM_TRACE_POINTS
+#define CREATE_CUSTOM_TRACE_EVENTS
-#endif /* CREATE_CUSTOM_TRACE_POINTS */
+#endif /* CREATE_CUSTOM_TRACE_EVENTS */
base-commit: 65e4fd942f72a9dba0e4e257290c4fa1aa756854
--
2.43.0
reply other threads:[~2026-11-20 12:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120122837.1597798-2-thnkslprpt@gmail.com \
--to=thnkslprpt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®