From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.154 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795179753; b=kptCbud4pEX0IdEhgM+9DIE8KIkItvjNqkLlHnbJxtWSG/R3sDcqg8qBqbAHFNK21DZC MCEBxbntH+yX7IGZTPhd9+7NKhWRaoi5fAouMWYNC9vmPmf3FrJh/jC3x+bCeSwkP0Oxt vS6jREdx7o18GGfflDzjIj7gwj0kQJQZ3t4otMGkSQktacm5tNtk8RlirfoxGJ+8J9ho4 NViyUGs5QFVral0KsLs1UGPN4fMhLE6d9ni+LBBz22S2kTquKOW5yFIQHsGeQlqg6dK8w LGILfYcnVkHNFfMh6YdqCQqV0TM4GrApfZBAijFLbT1pr8RTEGPl40gII1hYpE1VhRw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795179753; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding; bh=Sf9a1TadTPAXHY3roGFF0ghdBi+uNkgT8oVClrxeJsM=; b=j99TCdwrZSnpChgKwV5CGckWj6eQ2LpmIqi1aHRtK+nXk6sw6gXMQJXiqHtY6lc0eTQO GqGcHwO7H+21LdNPS0SWm/dE+ADYmAC04P6Yxr9aX5IspJRcWCE02wel/Z3qq56u3WqAp 6KlmtVIf2EcVge+rLmZ+I/VF3xw/hXr5EtApyGixzMXiLTz52UZM1+3pLQDItZb3vUzCm nSk5Qyt+qGuyRmt+JBceT7MK0SI02NjhqaKdm3HfpNOZ4ziEbyZ2dswozZ8LfOq1f9t+s LVJ5LheI5g9veJNHZGzldf9e+dvqXGInzTnppoiMKDBhOJJOLTlG1dTtXTsoRNCQO7g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=jschaer.ch; spf=pass smtp.mailfrom=jschaer.ch; dkim=pass header.d=jschaer.ch header.i=@jschaer.ch header.a=rsa-sha256 header.s=fm3 header.b=hHVPng2S; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=fM90GntZ; arc=none smtp.remote-ip=202.12.124.154 Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E3FD606A326 for ; Fri, 20 Nov 2026 13:02:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2E3FD606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=jschaer.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jschaer.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=jschaer.ch header.i=@jschaer.ch header.a=rsa-sha256 header.s=fm3 header.b=hHVPng2S; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=fM90GntZ Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8AC937A03A0 for ; Fri, 20 Nov 2026 08:02:32 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Fri, 20 Nov 2026 08:02:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jschaer.ch; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm3; t=1795179751; x=1795266151; bh=Sf 9a1TadTPAXHY3roGFF0ghdBi+uNkgT8oVClrxeJsM=; b=hHVPng2SdqBv5VRO9H HFB7nrZ8I7Syy8fO2Xlc6VUfGWfqEW/xS5Y7NFtmvvm+XPaRC/PFcEdouWHRNW1j 9Z+2DwMLqCfUCo3hnPG2PU/1xVCPdGWDqQfdtAQ7fyjFZSpP3k46hn1Z8K9M9rAF z/wEoX3Er1FGJ0D1QIDzQIQJUXfYIidE+OyATLz02tSbsyqBj+q/qgG+mIA2tJEo VkkLF0GlOn0l0YHOJXRYZNz3M9r8IFYV04GpG2EYEeqDc51GBNkEPvmSlTf/WDQr FJ/OxwmK8Q5C3x3MrGtVPPBPAe9I0atG5MKWS2V6FUsBPo5yVO5sGu9kaTVv3bIO HqLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1795179751; x=1795266151; bh=Sf9a1TadTPAXHY3roGFF0ghdBi+u NkgT8oVClrxeJsM=; b=fM90GntZbPNjkOMnf7Enp6/8+He9MA/94usCBolMpyy6 WhNSqQFQmZDMenxhptwWELgLRqY6XQ2v4pTjPQS0A8nccI+o2yuaw6XOy9C1NiWm L+mziBbwH04JKb4vDHC5ldvbM1MvI6rHmaqy/EZuZI56KemR5dA3Smv0o9bCxD/N sbAhh/7a2O3fB3X6v3PufXI75xoPoZNhEM2MwZzBhjuE45lhG/p5hgYV9u+8/ETl cZLG1yeXnz4G6PIZQVqz+kIj8KvUwZOpw73aavy3JupgXsO9CKlcXgEWSU04dbSY Adi0TJ+ueTnZMeKO4K8ZLS2d2VzDCK0b4TP1A2OpiQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=jschaer.ch a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1795179751; d=jschaer.ch; mf=PGphbkBqc2NoYWVyLmNoPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:H05ONVmb43CSxmKWQnsIAQiNK9Rrl8tRK2YYtFDcNETIPqk StM3CJHfW6H/PIoaK6FXr8uEMWCOMP65YjP2yd9ChZXtaMWJLFkKrClxDD8BTUDZ KiPXtDJ1Gs1mgmTLiG7Cr+FANtTwhTxDd1pSnuWBcJf/N5EJtA+OrjPsyzd8zjVs lohrC6u+ogWd3j/7fJC3jqCDFTEu3brhUybx90V8+3VjibsU5KK9PyrgxUkEnP4L qbfHhePBZhAuLr6N9ZSzCjw0sXnEwr0ZY5LWm3AkoyyySOVa8EpEWFnY1f/ajjUO kGOfgsJ0CWuKVTELKGFGopFWn+Z5E4AyxxcOyIw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=10; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,message-id,mime-version,subject,to; Message-Instance: m=1; h=sha256:sxkv3jZUfRs6osHl0SmSOSI5AdHa7a+LQ+6awwz6vDM=:rphMyLdZDRyhD7SlfxBjbT68Qk6TexzpLzYDzVCwHGE=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE1d9BpAt3ZrY4MvgNAVww7WbsFfu59mGi65YVhaFr2AbFJI6+lrfaVXJkakZ5Wup HW3Xx+DFKxjUlYSprz+B45XNQ8OnqdxiqzfYiGOLaStaN40JUdlfHUg+YRzT+YhVM53KER TOchZFI5QnW8k+MGpze1+1PQJm4DXTjV07iAsTnDat6Ls/JHOIXs0klQxD+cSzRDATrZ1r 7mtQcf0gvtEtwnzSzcFASn+j3Q9WJdID+7cqZTem+KU7wLLJ950b1Zgm19OkGlmdAu/zx1 h3of4pxG19cAMQY1nR4/xLjF2JopZAN8PLSC/+tvWBVlI3lb44enFub2/nMDil+yeOhzCv 4IrFs6eCSuG2Z9R7hyWB49mpzw0fwMtfOotjRClM0HHMXlN8VxHld8IMNhATheGhPcNSSG qml5fFKjzfWUhHlmjE8i3NVIF5mKsY0Mxp/gzx+GmuwVx35nmFnaUEA0SR5i0O0tV3HDSR ZGGb2r8kIt9ycCv+Ay8aK/KgAKqvvbzc4u3831qUPG74bqW96rnpBhhrRAQ6TeV6DouS3z /nCIF2Z79iB6+IjwwGeN+GAbRr+hRRaB2wv1uDgHDW3fVEN6Q24x/UcaCj85ul/4Fa8uOK a4yePEjSR9oVzDipgxAfZHMVvS0zj4jmIFZkdNwAo4tSWnpfvZ6Z1DMm60VQ X-ME-Proxy: Feedback-ID: ie67446dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Nov 2026 08:02:30 -0500 (EST) From: =?UTF-8?q?Jan=20Sch=C3=A4r?= To: Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Jan=20Sch=C3=A4r?= Subject: [PATCH] gpiolib: fix inverted trace values in gpiod_get_array_value() Date: Fri, 20 Nov 2026 14:02:08 +0100 Message-ID: <20261120130208.89621-1-jan@jschaer.ch> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Almost all trace_gpio_value() calls report the raw value. gpiod_get_array_value_complex() is the only exception; it reports the logical value in traces unless the caller requests raw values. This inconsistency makes GPIO traces confusing. Move the trace call earlier, where the value is still raw. Now, all GPIO traces consistently report raw values. Fixes: eec1d566cdf9 ("gpio: Introduce ->get_multiple callback") Signed-off-by: Jan Schär --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 2a220f10f0e5..c924fc65c622 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3644,10 +3644,10 @@ int gpiod_get_array_value_complex(bool raw, bool can_sleep, int hwgpio = gpiod_hwgpio(desc); int value = test_bit(hwgpio, bits); + trace_gpio_value(desc_to_gpio(desc), 1, value); if (!raw && test_bit(GPIOD_FLAG_ACTIVE_LOW, &desc->flags)) value = !value; __assign_bit(j, value_bitmap, value); - trace_gpio_value(desc_to_gpio(desc), 1, value); j++; if (array_info) base-commit: c6d8ebd7324cefda867a701b4341605b681aa3f5 -- 2.53.0