From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Luis Henriques <luis@igalia.com>,
Miklos Szeredi <mszeredi@redhat.com>,
stable@vger.kernel.org
Subject: [PATCH v2 2/2] fuse: do not schedule dentry_tree_work after fuse_dentry_tree_cleanup()
Date: Sat, 21 Nov 2026 00:00:06 +0900 [thread overview]
Message-ID: <20261120150008.1144420-3-ekffu200098@gmail.com> (raw)
In-Reply-To: <20261120150008.1144420-1-ekffu200098@gmail.com>
fuse_dentry_tree_cleanup() cancels dentry_tree_work at module unload.
But a sysfs write can call inval_wq_set() after that and schedule the
work again, leading to use-after-free.
So do not schedule the work in inval_wq_set() after
fuse_dentry_tree_cleanup() cancels it. Also hold kernel_param_lock()
in fuse_dentry_tree_cleanup(), because a sysfs write can call
inval_wq_set() at the same time.
Fixes: ab84ad597386 ("fuse: new work queue to periodically invalidate expired dentries")
Cc: stable@vger.kernel.org
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
fs/fuse/dir.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 0d5d04df477b..04ca6c9be2bf 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -63,7 +63,10 @@ static int inval_wq_set(const char *val, const struct kernel_param *kp)
*((unsigned int *)kp->arg) = num;
- /* Defer the work until fuse_dentry_tree_init() sets it up. */
+ /*
+ * Do not touch the work before fuse_dentry_tree_init() or after
+ * fuse_dentry_tree_cleanup().
+ */
if (!inval_wq_ready)
return 0;
@@ -243,8 +246,11 @@ void fuse_dentry_tree_cleanup(void)
{
int i;
+ kernel_param_lock(THIS_MODULE);
+ inval_wq_ready = false;
inval_wq = 0;
cancel_delayed_work_sync(&dentry_tree_work);
+ kernel_param_unlock(THIS_MODULE);
for (i = 0; i < FUSE_HASH_SIZE; i++)
WARN_ON_ONCE(!RB_EMPTY_ROOT(&dentry_hash[i].tree));
--
2.53.0
prev parent reply other threads:[~2026-11-20 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:00 [PATCH v2 0/2] fuse: schedule dentry_tree_work only between dentry tree init and cleanup Sang-Heon Jeon
2026-11-20 15:00 ` [PATCH v2 1/2] fuse: defer dentry_tree_work until fuse_dentry_tree_init() Sang-Heon Jeon
2026-11-20 15:00 ` Sang-Heon Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120150008.1144420-3-ekffu200098@gmail.com \
--to=ekffu200098@gmail.com \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@igalia.com \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®