From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795188522; b=mJju0pxPmY6L9eI4sr7YaY72Hv4eR+pxQlJ6x4X+Vf78q5CawF/pZRdsQvWvO2RpAeSr MT4tBhecX93BUjgF7stwXpROY8NMH+5RRqem80vwtNEjQ5dE52dB52ZiP/GuOM71pW1Se gAmD7BV9iwhu9NrXWn9pR68Kq78YOJivuYNJNE/K+UmwKyjv+4pywwN8Vb+lgKsSDy/Yj ewyPA8gzeUX1K9JCy14+rtmmha23IPv5kONnJdoHx07e4iFbdRuFZITLVcCHGetFGk6CR 9WsAuTxKfWtzbKEjy9t1zvv2LCetRv+EDGCLv4AEHDYAvcGQd1fW7rq/tnrbqit4KmQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795188522; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=zXTRJAoOuhwgv6K3/hgMVInOSV4KNQqD3bcfaDnRvQ0=; b=GY1497RNX6W/E2HWQRtA+QYQiATjzuAEQcwoYUIAJqU50rkKVMG9UcLPaNyFiEW7DqNU /Qt8UT8sCM3taeiPBg2LNCVLiImkPq1jKd7P6/RxKxnvd3TWNvqdsOuP/lIERA/5paoRr k+BsjJBMNqss80EKEVBvwbJlBfHb+A0eDPpLMsjmtceX47GICf6y6GP+vq2dA8tA54YGS zWmw1yPue8ugmpBCLwKBF2xO41er5B+6Hp1Dp0S1IRGmsmObn8XR4r9dhjxq65XoUmB6d IdA70EFLW/34Rod03wSAyuXdhqEAVMf5Pf46KReuVjWX5+zTKmqpnbfVLqBcoQ8lBBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass header.d=dama-to.20260707.gappssmtp.com header.i=@dama-to.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=IbKQ9U44; arc=none smtp.remote-ip=209.85.216.53 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70FA60A2601 for ; Fri, 20 Nov 2026 15:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E70FA60A2601 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20260707.gappssmtp.com header.i=@dama-to.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=IbKQ9U44 Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3b09a83d12aso807171a91.2 for ; Fri, 20 Nov 2026 07:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20260707.gappssmtp.com; s=20260707; t=1795188521; x=1795793321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zXTRJAoOuhwgv6K3/hgMVInOSV4KNQqD3bcfaDnRvQ0=; b=IbKQ9U441mvUpOCf5AN9AqCTS3l5kw++bv0vXra/SVCRluvwyI1YXYPCMCAtcBSz+c W6znSwySMdcXTH73F1VCad2A8OBL+LsbYUTnR0yGF7mn5aVNFBH6UZQQLmZ12/Y+XrZz V/S6lhX9lwrd7yNmBFU8k7Z/1PujnDmOT8lKzrKWjnp93xhlSegPdASUEPgxX5bGr4bc VvAspiW8JKI9vjDdruBfQsq4FYTeyAYUWyCHjZImkn5oTPwJL3jC9hhvoDKHCdCglvdY G4A0IMCprFZNfQOfCj7yv0Tibrjfjnghw7yqbK3tR53GuHTQw/+QtnT+yZdOa7FxBPNu WQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795188521; x=1795793321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zXTRJAoOuhwgv6K3/hgMVInOSV4KNQqD3bcfaDnRvQ0=; b=zeKxqFma4rtalvkv6yGZ/ST7NGoayI3Baserdz2vxJv5uzw5H9io6Fur2CZOPq9jvI +lbj/DBHz3j99nBEqQF3G3e/de16Sqy7NkdePdYDmhYn+amRsl9lvVIJqqem4NYwQbuP urX9KdDUl5JQuQtMfhi91bJN3+sf9o/DRkQZx1V+fPTUEfafSrJhp9yl4/zyH5LE6S9x h0NKxzomGOFQQlUEKIfNdZYdM1HsP6GHX3WEGn6cf5Q3jCOjPGXRZYxMnWAllTvaFp1S 6cBhPjPlNUDgY5n8dAhae64svtcdNQyWEzFLJtnGSdBLKc8uhdiuXGewbCBdwRmVYO92 yWiw== X-Forwarded-Encrypted: i=1; AL+hErGPA3swMO8XQZ1TRkPbM3rm24eiI0syuai0gZQahhuMTA1Eov6GbCf4lZliVxl78Cx+S3+ti1c+7089hfY=@vger.kernel.org X-Gm-Message-State: APuU4Z+tIWD3SDvFHHG7oEJAXojCKjjvk0gSnc7wknYbfpxgAL4t5HJO Ut7G7kpw/CYdMmEQTH6/DoIg5up6sZf4ZU0kdydUGgX+zNzleAb+4uXSX0yJrEeJIWI= X-Gm-Gg: AZFdTZe7BRsOiwfmWWB2WMVGvoHhp3bRcavIMrAlbGt+VWPP/YHHF8iM9bpg4Gxyha0 0BdI+/8senPRFoTCp0FyO1U0GV24pqZkxeHtpebPGu4eLlSHHCw8AEA244EhMhK5aNSZ3foGBG1 l9ea/OV68wQV0FVr9bXxDsVYJgGa3MsLGT+PZtRFSjLRQ8ofv5dDSkL5Z5tqFgKAiEwkURcb1u9 Lg6hLRfd+ZL0eRd8SG3QHUDXKmKpbcGyEhRs/fl8bs9m1HKPrijcy6yBx+uBXa36Jd/BFLKfjhQ kLYj2UyEx5CoEip7gUlEcGYuFkwPZ/W4/4nSVjKBJfnw8pSWbXNjVddoxYBpRnwXEY/BwqvHzjH kVsSOMFt+yrllKl8AQ1nqmC3/M/PdCJ4QgYDmgm9+/vzWziPL3xGzEVhmxbZaT/GuCJJzyDgJCx a40sZNJoUDgUzv4QI7d9twj8qAlZHjDwKINosr4fg8FkVSmm9SMMRjWRZ593X60wgEgXakyby2r zOsRC9nh0E5PG2avkhU/Zy6GjN+NgRNZ956yEUUdID3ytN8txbSigce2kj8srvBDA4Y69b0OaYJ 5wJQ/8f5EtTCniYnGHvcIZH2M/qSPnzaPyUyltLUNGU= X-Received: by 2002:a17:90b:268a:b0:3ac:7c52:fae5 with SMTP id 98e67ed59e1d1-3b41c9778e9mr3152403a91.50.1795188521252; Fri, 20 Nov 2026 07:28:41 -0800 (PST) Received: from localhost ([2a03:2880:2ff:49::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b41abb1b66sm5081385a91.1.2026.11.20.07.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 07:28:40 -0800 (PST) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Prashant Sreedharan Cc: edumazet@google.com, horms@kernel.org, selvin.xavier@broadcom.com, kalesh-anakkur.purayil@broadcom.com, linux-kernel@vger.kernel.org, Joe Damato Subject: [PATCH net v6 1/5] bnxt_en: return the RING_FREE status to callers Date: Fri, 20 Nov 2026 07:28:23 -0800 Message-ID: <20261120152830.699712-2-joe@dama.to> X-Mailer: git-send-email 2.53.1 In-Reply-To: <20261120152830.699712-1-joe@dama.to> References: <20261120152830.699712-1-joe@dama.to> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hwrm_ring_free_send_msg() reports failure to its caller, but always as -EIO, so a caller cannot tell whether the firmware rejected HWRM_RING_FREE or never answered it. The TX, RX and AGG ring free helpers discard the value. Return the errno from hwrm_req_send() instead. -EBUSY means no response arrived: the wait timed out, was abandoned, or the firmware channel is down. An error reported by the firmware keeps its own errno, for example a firmware BUSY reply becomes -EAGAIN. Return the value from the TX, RX and AGG ring free helpers. No caller acts on it yet, so there is no functional change. Fixes: 74608fc98d28 ("bnxt_en: Ring free response from close path should use completion ring") Signed-off-by: Joe Damato --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 50 +++++++++++++---------- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index e78cf7ad3cbc..c3413354e758 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -7673,55 +7673,62 @@ static int hwrm_ring_free_send_msg(struct bnxt *bp, if (rc || error_code) { netdev_err(bp->dev, "hwrm_ring_free type %d failed. rc:%x err:%x\n", ring_type, rc, error_code); + if (rc) + return rc; return -EIO; } return 0; } -static void bnxt_hwrm_tx_ring_free(struct bnxt *bp, - struct bnxt_tx_ring_info *txr, - bool close_path) +static int bnxt_hwrm_tx_ring_free(struct bnxt *bp, + struct bnxt_tx_ring_info *txr, + bool close_path) { struct bnxt_ring_struct *ring = &txr->tx_ring_struct; u32 cmpl_ring_id; + int rc; if (ring->fw_ring_id == INVALID_HW_RING_ID) - return; + return 0; cmpl_ring_id = close_path ? bnxt_cp_ring_for_tx(bp, txr) : INVALID_HW_RING_ID; - hwrm_ring_free_send_msg(bp, ring, RING_FREE_REQ_RING_TYPE_TX, - cmpl_ring_id); + rc = hwrm_ring_free_send_msg(bp, ring, RING_FREE_REQ_RING_TYPE_TX, + cmpl_ring_id); ring->fw_ring_id = INVALID_HW_RING_ID; + return rc; } -static void bnxt_hwrm_rx_ring_free(struct bnxt *bp, - struct bnxt_rx_ring_info *rxr, - bool close_path) +static int bnxt_hwrm_rx_ring_free(struct bnxt *bp, + struct bnxt_rx_ring_info *rxr, + bool close_path) { struct bnxt_ring_struct *ring = &rxr->rx_ring_struct; u32 grp_idx = rxr->bnapi->index; u32 cmpl_ring_id; + int rc; if (ring->fw_ring_id == INVALID_HW_RING_ID) - return; + return 0; cmpl_ring_id = bnxt_cp_ring_for_rx(bp, rxr); - hwrm_ring_free_send_msg(bp, ring, - RING_FREE_REQ_RING_TYPE_RX, - close_path ? cmpl_ring_id : - INVALID_HW_RING_ID); + rc = hwrm_ring_free_send_msg(bp, ring, + RING_FREE_REQ_RING_TYPE_RX, + close_path ? cmpl_ring_id : + INVALID_HW_RING_ID); ring->fw_ring_id = INVALID_HW_RING_ID; bp->grp_info[grp_idx].rx_fw_ring_id = INVALID_HW_RING_ID; + return rc; } -static void bnxt_hwrm_rx_agg_ring_free(struct bnxt *bp, - struct bnxt_rx_ring_info *rxr, - bool close_path) +static int bnxt_hwrm_rx_agg_ring_free(struct bnxt *bp, + struct bnxt_rx_ring_info *rxr, + bool close_path) { struct bnxt_ring_struct *ring = &rxr->rx_agg_ring_struct; u32 grp_idx = rxr->bnapi->index; u32 type, cmpl_ring_id; + int rc; if (bp->flags & BNXT_FLAG_CHIP_P5_PLUS) type = RING_FREE_REQ_RING_TYPE_RX_AGG; @@ -7729,14 +7736,15 @@ static void bnxt_hwrm_rx_agg_ring_free(struct bnxt *bp, type = RING_FREE_REQ_RING_TYPE_RX; if (ring->fw_ring_id == INVALID_HW_RING_ID) - return; + return 0; cmpl_ring_id = bnxt_cp_ring_for_rx(bp, rxr); - hwrm_ring_free_send_msg(bp, ring, type, - close_path ? cmpl_ring_id : - INVALID_HW_RING_ID); + rc = hwrm_ring_free_send_msg(bp, ring, type, + close_path ? cmpl_ring_id : + INVALID_HW_RING_ID); ring->fw_ring_id = INVALID_HW_RING_ID; bp->grp_info[grp_idx].agg_fw_ring_id = INVALID_HW_RING_ID; + return rc; } static void bnxt_hwrm_cp_ring_free(struct bnxt *bp, -- 2.53.1-Meta