From: Peter Zijlstra <peterz@infradead.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Usama Arif <usama.arif@linux.dev>,
tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, kees@kernel.org,
hpa@zytor.com, gustavoars@kernel.org, ardb@kernel.org,
hca@linux.ibm.com, nathan@kernel.org, ndesaulniers@google.com,
morbo@google.com, justinstitt@google.com,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, riel@surriel.com,
shakeel.butt@linux.dev, kernel-team@meta.com, rkeilty@meta.com,
atish.patra@linux.dev, dgreid@meta.com
Subject: Re: [PATCH 2/2] x86/kstack_erase: Use REP STOSQ for large stack fills
Date: Fri, 20 Nov 2026 16:35:39 +0100 [thread overview]
Message-ID: <20261120153539.GW2668564@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261120140200.53ec2557@pumpkin>
On Fri, Nov 20, 2026 at 02:02:00PM +0000, David Laight wrote:
> On Fri, 20 Nov 2026 11:45:34 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Thu, Nov 19, 2026 at 01:31:08PM -0800, Usama Arif wrote:
> > > +#ifdef CONFIG_X86_64
> > > +#define __stackleak_poison __stackleak_poison
> > > +static __always_inline void __stackleak_poison(unsigned long erase_low,
> > > + unsigned long erase_high,
> > > + unsigned long poison)
> > > +{
> > > + unsigned long count;
> > > +
> > > + /* Short spans do not amortize the startup cost of REP STOSQ. */
> > > + if (erase_high <= erase_low + 512) {
> > > + while (erase_low < erase_high) {
> > > + *(unsigned long *)erase_low = poison;
> > > + erase_low += sizeof(unsigned long);
> > > + }
> > > + return;
> > > + }
> > > +
> > > + count = (erase_high - erase_low) / sizeof(unsigned long);
> > > + asm volatile("rep stosq"
> > > + : "+D" (erase_low), "+c" (count)
> > > + : "a" (poison)
> > > + : "memory");
> > > +}
> > > +#endif
> >
> > Gemini seems to suggest 16-32 words would be sufficient to amortize the
> > REP STOS setup.
>
> That really does sound like wishful thinking.
> Especially if you go back a few generations on the cpu architecture.
How old? I mean, Interlagos old, sure, but nobody should care about
performance there I think.
AFAICT Nehalem and later should be good with the 16-32 words. As would
all the various Zen chips.
next prev parent reply other threads:[~2026-11-20 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 21:31 [PATCH 0/2] x86/kstack_erase: Faster stack poisoning, plus a startup build fix Usama Arif
2026-11-19 21:31 ` [PATCH 1/2] x86/boot/startup: Disable kernel stack depth tracking Usama Arif
2026-11-19 22:30 ` Nick Desaulniers
2026-11-19 21:31 ` [PATCH 2/2] x86/kstack_erase: Use REP STOSQ for large stack fills Usama Arif
2026-11-19 22:28 ` Nick Desaulniers
2026-11-20 11:38 ` David Laight
2026-11-20 12:42 ` David Laight
2026-11-20 10:45 ` Peter Zijlstra
2026-11-20 12:26 ` Peter Zijlstra
2026-11-20 14:02 ` David Laight
2026-11-20 15:35 ` Peter Zijlstra [this message]
2026-11-20 16:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120153539.GW2668564@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ardb@kernel.org \
--cc=atish.patra@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=dgreid@meta.com \
--cc=gustavoars@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=riel@surriel.com \
--cc=rkeilty@meta.com \
--cc=shakeel.butt@linux.dev \
--cc=tglx@kernel.org \
--cc=usama.arif@linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®