mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chad Aldreda <ca@modelmiser.com>
To: Farhad Alemi <farhad.alemi@berkeley.edu>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Jeff Johnson" <jjohnson@kernel.org>,
	"Mikołaj Pisula" <mikolaj@pisu.la>,
	falemi@asu.edu, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] ath9k_htc_tx_cleanup_timer -- ODEBUG free-active-timer and use-after-free on USB unplug
Date: Fri, 20 Nov 2026 18:26:21 +0000	[thread overview]
Message-ID: <20261120182614.1799276-2-ca@modelmiser.com> (raw)
In-Reply-To: <CA+0ovCgukr_PwQ89iC+YW6FC-m==na4iW6fUkiCM5xp09PMt-Q@mail.gmail.com>

Hi Farhad,

Thanks for the reproducer. It hits neither of the two paths I guessed
at. It withholds the reply to WMI_TARGET_IC_UPDATE_CMDID, so
ath9k_htc_update_cap_target() times out in ath9k_htc_start(), which
logs that only at debug level, still arms tx.cleanup_timer, and returns
the error. mac80211 treats the start as failed and never calls
ath9k_htc_stop(), so the timer is still pending when the device is
unplugged, and then fires on the freed hw (the KASAN report).

Mikołaj Pisula found the same thing and posted a fix this week, which
Toke has applied to ath9k-pending:

https://lore.kernel.org/linux-wireless/20261117103918.33701-1-mikolaj@pisu.la/
https://git.kernel.org/toke/ath9k-pending/c/176a947f3d98

I haven't run your reproducer against it. If you do, a Tested-by on
that thread would still be welcome.

Chad

This reply was drafted with an AI assistant (Claude Opus 5.5).


      reply	other threads:[~2026-11-20 18:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  5:25 Farhad Alemi
2026-11-09 10:34 ` Chad Aldreda
2026-11-20 17:21   ` Farhad Alemi
2026-11-20 18:26     ` Chad Aldreda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120182614.1799276-2-ca@modelmiser.com \
    --to=ca@modelmiser.com \
    --cc=falemi@asu.edu \
    --cc=farhad.alemi@berkeley.edu \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mikolaj@pisu.la \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®