From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.199 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795201250; b=sa6YdTqSXhvEN7OArANJRFmgaTmRERDdRuDu62NqPGg2i4GPxjDgpkBGLx/ouHLrD4rP fAtqWEQvfwqLSluxs4HK8+coEA3Riids0AcEm9lOMmJ8blCZPMVSkvJakiafldqpluLJp 8eaejwpmD9OswCNeIL/Wh3qml+zoQeend2IWh5/Bsg3mewQ0vloewhAwqWjWs9QXoQBXI SS35hxZjL5rQrejYMx6eZTQD9j40Imz8irM+f+bfgu5V9upyt1N4M9cT072yGgAhYqyg+ 6tK5sYgVFV7Fak6La1XIrjCjGpqVNRn2wehczRQhh04EJV+X0uB2SMLwUKBkbgnrXMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795201250; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=2IUJ4prZfGsGzb0Qck/GAuOjhnwEHRfiPDhs17Z4SoU=; b=lmLboZ0+q+tz8A/r5fV6mcCj4nJCitibzgB6V6QPqACh2Ht/ASkS8rd7plvxVon9AZMK iesGc7vHVjFbbZCIpzWIiK02ZmO+FsfgnZEWEUyQLJP6V24k49C/YztfS94EvbRBnDAf4 JhfCxoGBaw+Ek3RQIlIWuGvw9xyJByTaLDzWE1EEK/Jksv9Y4IR/NwrojYt74dbh1a9CV BZEaHzVcXeMuDcKLQtO2eWsVCvUkEeTKUHLixaj4xOtZIMNEvY0kiUR18vXgeEvAZcTa4 /hOir7PVybe+vqxzg2fDSbzDhC4YaeMHCQqFoync3VbRkO1CzZ0lsjgt8JOX7iCjVeA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=ZklHrKxo; arc=none smtp.remote-ip=209.85.215.199 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D304B60A380C for ; Fri, 20 Nov 2026 19:00:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D304B60A380C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=ZklHrKxo Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cc7361c62b9so857820a12.3 for ; Fri, 20 Nov 2026 11:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795201248; x=1795806048; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2IUJ4prZfGsGzb0Qck/GAuOjhnwEHRfiPDhs17Z4SoU=; b=ZklHrKxo8PI4TUG9EcnZfURC06IahIv2QFJrF+PQZNVoeE3A2hD7BTFl/zpex/XLdE OUgO2LYdQ6DKZPNOz/xkP5oEoaKaPsmZZt1Msxy8xylBNrPBPkXj0pFaW9azq+gosh8d xQ/EbFB6HWiTdCNX6Fpye9Gt/xVojSVWeIfZqJsZMjWxOAS0FUS7erNcJ3tDVHS4NJGV YEq3f10Fe3+KtCCb3ZfhHf52b2RLNiSYi3lOmPC8JYAy7VAMuO1Mo7NUueIj5GhHScph H/rwLYUORCbyiNxh//vYtnJpjPDuA5gR+UobB0V4enDoeA+yrR+yO/fRqubGwQZx6nF8 oY+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795201248; x=1795806048; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2IUJ4prZfGsGzb0Qck/GAuOjhnwEHRfiPDhs17Z4SoU=; b=laIBh7TvlDrzJrahE68P+5iG2Mu04DHIBFy1+QNo/NraN4rDZm5C+h5VAFEwfuvFV8 0k2cLHCojJJen9Upug4tLrA29HuXheaQGZhkzf76R+kv83HD5syJLL8d57IM0h/seUBv U8pVBsfgiQ9/PN3Qp9X9YC6s+RVvVBbdV6W7LP6+HBc3vqJUS53lKgJ47m/3muHx6yPg 5Y8QVr1dxfs53dPDCKoM5RoV/koHzfe60zOgeDxL87YzWBxd8gPJaVZ25rw9cuZP/0TK SLa0nTRVHystDV68NnOhX5l/P/oYpTZaU5K4J2pKnXCUlXOjlC75UCEM5Bu/WR5aPV4B Y6RA== X-Forwarded-Encrypted: i=1; AL+hErEPFlosiR77YqpBSiyHoaGJZImc+I07xrw97dQSk0d+QYL1f3YqIdRQtXfj8+j5uOtGCDi5eRpO4c8KO4g=@vger.kernel.org X-Gm-Message-State: APuU4Z8KFgGSMxwnPIrTCGjybzbGMfh+PufWG4P1NHZUMBKD6z7mgaAG PQO7p0aJkPcTw8yEQB/bxWQrsq5UQ7bmRP0pQK7dLQ0i4b9Aq4ZUisurfqsynGK4wvnN9J10OST SxKYJgG84sA== X-Received: from pgiy3.prod.google.com ([2002:a63:de43:0:b0:cca:d82:9104]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:db97:b0:3dd:a006:ed90 with SMTP id adf61e73a8af0-4014bc4e776mr3903412637.38.1795201247965; Fri, 20 Nov 2026 11:00:47 -0800 (PST) Date: Fri, 20 Nov 2026 11:00:29 -0800 In-Reply-To: <20261120190031.1587531-1-irogers@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261120190031.1587531-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261120190031.1587531-2-irogers@google.com> Subject: [PATCH v2 1/3] scsi: mpi3mr: Return error on all failure exits in mpi3mr_bring_ioc_ready() From: Ian Rogers To: Sathya Prakash Veerichetty , Kashyap Desai , Sumit Saxena , Sreekanth Reddy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Laurence Oberman , mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Elkin Cruz , Ian Rogers , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" In mpi3mr_bring_ioc_ready(), all success paths return 0 directly, while all failure paths either fall through out_failed or jump to out_device_not_present and return retval. However, retval is initialized to 0 at function entry and overwritten with 0 once mpi3mr_setup_admin_qpair() succeeds. As a result, failure paths that do not set retval themselves - including unrecoverable fault checks, PCI device removal during reset or diagnostic-save waits, failure to reach MRIOC_STATE_RESET, and ready-loop fault/reset-history exits or timeouts - return 0 (success) to mpi3mr_init_ioc() and mpi3mr_reinit_ioc(), causing initialization to proceed against a failed or absent controller. Set retval = -1 at out_device_not_present whenever retval is 0 so every failure exit returns a non-zero error while preserving specific error codes from helper calls. Found during an x86_64 LLVM=1 allyesconfig warning audit with AI coding assistant help. Verified with a standalone C logic reproducer and by building drivers/scsi/mpi3mr/mpi3mr_fw.o with LLVM=1 W=1 (-Werror); not runtime-tested on MPI3 hardware. Fixes: 59bd9cfe3fa0 ("scsi: mpi3mr: Code refactor of IOC init - part2") Cc: stable@vger.kernel.org Reviewed-by: Laurence Oberman Signed-off-by: Ian Rogers --- drivers/scsi/mpi3mr/mpi3mr_fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c index f0d3cd398dd0..416f27c37535 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c @@ -1744,6 +1744,8 @@ out_failed: "failed to bring to ready state, current state: %s\n", mpi3mr_iocstate_name(ioc_state)); out_device_not_present: + if (!retval) + retval = -1; return retval; } -- 2.56.1.750.gf70dc682cf-goog